| Message ID | 20220113053734.105813-3-boger@wirenboard.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | sun8i: r40: second ethernet support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dtbs-check | success | |
| robh/dt-meta-schema | success |
On Thu, Jan 13, 2022 at 08:37:33AM +0300, Evgeny Boger wrote: > R40 and A10/A20 share the same EMAC IP. > However, on R40 the EMAC reset needs to be deasserted first, > so resets property is required. > > Signed-off-by: Evgeny Boger <boger@wirenboard.com> Acked-by: Maxime Ripard <maxime@cerno.tech> Maxime
On Thu, 13 Jan 2022 08:37:33 +0300, Evgeny Boger wrote: > R40 and A10/A20 share the same EMAC IP. > However, on R40 the EMAC reset needs to be deasserted first, > so resets property is required. > > Signed-off-by: Evgeny Boger <boger@wirenboard.com> > --- > .../bindings/net/allwinner,sun4i-a10-emac.yaml | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml b/Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml index 8d8560a67abf..d9ed7b547af3 100644 --- a/Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml +++ b/Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml @@ -15,7 +15,9 @@ maintainers: properties: compatible: - const: allwinner,sun4i-a10-emac + enum: + - allwinner,sun4i-a10-emac + - allwinner,sun8i-r40-emac reg: maxItems: 1 @@ -30,6 +32,19 @@ properties: description: Phandle to the device SRAM $ref: /schemas/types.yaml#/definitions/phandle-array + resets: + maxItems: 1 + +if: + properties: + compatible: + contains: + const: allwinner,sun8i-r40-emac + +then: + required: + - resets + required: - compatible - reg
R40 and A10/A20 share the same EMAC IP. However, on R40 the EMAC reset needs to be deasserted first, so resets property is required. Signed-off-by: Evgeny Boger <boger@wirenboard.com> --- .../bindings/net/allwinner,sun4i-a10-emac.yaml | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-)