| Message ID | 20220111063904.7583-3-yong.wu@mediatek.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | MT8186 SMI SUPPORT | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 13 lines checked |
| robh/dtbs-check | success | |
| robh/dt-meta-schema | success |
On 11/01/2022 07:39, Yong Wu wrote: > Mute the warning from "make dtbs_check": > > larb@14017000: clock-names: ['apb', 'smi'] is too short > arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml > ... > > larb@16010000: clock-names: ['apb', 'smi'] is too short > arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml > > larb@17010000: clock-names: ['apb', 'smi'] is too short > arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml > > If a platform's larb supports gals, there will be some larbs have one > more "gals" clock while the others still only need "apb"/"smi" clocks, > then the minItems for clock and clock-names are 2. > > Fixes: 27bb0e42855a ("dt-bindings: memory: mediatek: Convert SMI to DT schema") > Signed-off-by: Yong Wu <yong.wu@mediatek.com> > --- > .../bindings/memory-controllers/mediatek,smi-larb.yaml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > index 80907e357892..884c0c74e5e4 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > @@ -80,10 +80,10 @@ allOf: > then: > properties: > clock: Separate patch: This should be clocks. The same in second if. Now it is simply not working... > - items: Putting min/maxItems under items is wrong. The second if also needs the fixing. Please make it a separate patch before this one. The schema was clearly not tested before... > - minItems: 3 > - maxItems: 3 > + minItems: 2 > + maxItems: 3 > clock-names: > + minItems: 2 > items: > - const: apb > - const: smi > Best regards, Krzysztof
On Wed, 2022-01-12 at 11:18 +0100, Krzysztof Kozlowski wrote: > On 11/01/2022 07:39, Yong Wu wrote: > > Mute the warning from "make dtbs_check": > > > > larb@14017000: clock-names: ['apb', 'smi'] is too short > > arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi- > > burnet.dt.yaml > > ... > > > > larb@16010000: clock-names: ['apb', 'smi'] is too short > > arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi- > > burnet.dt.yaml > > > > larb@17010000: clock-names: ['apb', 'smi'] is too short > > arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi- > > burnet.dt.yaml > > > > If a platform's larb supports gals, there will be some larbs have > > one > > more "gals" clock while the others still only need "apb"/"smi" > > clocks, > > then the minItems for clock and clock-names are 2. > > > > Fixes: 27bb0e42855a ("dt-bindings: memory: mediatek: Convert SMI to > > DT schema") > > Signed-off-by: Yong Wu <yong.wu@mediatek.com> > > --- > > .../bindings/memory-controllers/mediatek,smi-larb.yaml | 6 > > +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/memory- > > controllers/mediatek,smi-larb.yaml > > b/Documentation/devicetree/bindings/memory- > > controllers/mediatek,smi-larb.yaml > > index 80907e357892..884c0c74e5e4 100644 > > --- a/Documentation/devicetree/bindings/memory- > > controllers/mediatek,smi-larb.yaml > > +++ b/Documentation/devicetree/bindings/memory- > > controllers/mediatek,smi-larb.yaml > > @@ -80,10 +80,10 @@ allOf: > > then: > > properties: > > clock: > > Separate patch: > This should be clocks. The same in second if. Now it is simply not > working... > > > - items: > > Putting min/maxItems under items is wrong. The second if also needs > the > fixing. Please make it a separate patch before this one. Oh. I will use a new patch for renaming "clock" to "clocks" and removing the "items". Thanks. > > The schema was clearly not tested before... > > > > - minItems: 3 > > - maxItems: 3 > > + minItems: 2 > > + maxItems: 3 > > clock-names: > > + minItems: 2 > > items: > > - const: apb > > - const: smi > > > > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml index 80907e357892..884c0c74e5e4 100644 --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml @@ -80,10 +80,10 @@ allOf: then: properties: clock: - items: - minItems: 3 - maxItems: 3 + minItems: 2 + maxItems: 3 clock-names: + minItems: 2 items: - const: apb - const: smi
Mute the warning from "make dtbs_check": larb@14017000: clock-names: ['apb', 'smi'] is too short arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml ... larb@16010000: clock-names: ['apb', 'smi'] is too short arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml larb@17010000: clock-names: ['apb', 'smi'] is too short arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml If a platform's larb supports gals, there will be some larbs have one more "gals" clock while the others still only need "apb"/"smi" clocks, then the minItems for clock and clock-names are 2. Fixes: 27bb0e42855a ("dt-bindings: memory: mediatek: Convert SMI to DT schema") Signed-off-by: Yong Wu <yong.wu@mediatek.com> --- .../bindings/memory-controllers/mediatek,smi-larb.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)