diff mbox series

dt-bindings: regulator: maxim,max8973: Document interrupts property

Message ID 20211206153432.226963-1-thierry.reding@gmail.com
State Not Applicable, archived
Headers show
Series dt-bindings: regulator: maxim,max8973: Document interrupts property | expand

Checks

Context Check Description
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success

Commit Message

Thierry Reding Dec. 6, 2021, 3:34 p.m. UTC
From: Thierry Reding <treding@nvidia.com>

One of the examples in the bindings has an interrupts property and the
Linux kernel driver has support for requesting an interrupt as well. It
looks like the absence from the bindings was just an oversight. Add the
property to make sure the examples can be validated.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 Documentation/devicetree/bindings/regulator/maxim,max8973.yaml | 3 +++
 1 file changed, 3 insertions(+)

Comments

Mark Brown Dec. 6, 2021, 3:42 p.m. UTC | #1
On Mon, Dec 06, 2021 at 04:34:32PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> One of the examples in the bindings has an interrupts property and the
> Linux kernel driver has support for requesting an interrupt as well. It
> looks like the absence from the bindings was just an oversight. Add the
> property to make sure the examples can be validated.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
Krzysztof Kozlowski Dec. 6, 2021, 3:57 p.m. UTC | #2
On 06/12/2021 16:34, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> One of the examples in the bindings has an interrupts property and the
> Linux kernel driver has support for requesting an interrupt as well. It
> looks like the absence from the bindings was just an oversight. Add the
> property to make sure the examples can be validated.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  Documentation/devicetree/bindings/regulator/maxim,max8973.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/maxim,max8973.yaml b/Documentation/devicetree/bindings/regulator/maxim,max8973.yaml
> index 54522827265b..35c53e27f78c 100644
> --- a/Documentation/devicetree/bindings/regulator/maxim,max8973.yaml
> +++ b/Documentation/devicetree/bindings/regulator/maxim,max8973.yaml
> @@ -86,6 +86,9 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  interrupts:
> +    maxItems: 1
> +

The subject prefix should be "regulator: dt-bindings: ...".

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


Best regards,
Krzysztof
Rob Herring Dec. 6, 2021, 8:24 p.m. UTC | #3
On Mon, 06 Dec 2021 16:34:32 +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> One of the examples in the bindings has an interrupts property and the
> Linux kernel driver has support for requesting an interrupt as well. It
> looks like the absence from the bindings was just an oversight. Add the
> property to make sure the examples can be validated.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  Documentation/devicetree/bindings/regulator/maxim,max8973.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Mark Brown Dec. 7, 2021, 3:09 p.m. UTC | #4
On Mon, 6 Dec 2021 16:34:32 +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> One of the examples in the bindings has an interrupts property and the
> Linux kernel driver has support for requesting an interrupt as well. It
> looks like the absence from the bindings was just an oversight. Add the
> property to make sure the examples can be validated.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] dt-bindings: regulator: maxim,max8973: Document interrupts property
      commit: 4aafc5c61b4c2be920b8a56b11279c5fadb8a6bf

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/regulator/maxim,max8973.yaml b/Documentation/devicetree/bindings/regulator/maxim,max8973.yaml
index 54522827265b..35c53e27f78c 100644
--- a/Documentation/devicetree/bindings/regulator/maxim,max8973.yaml
+++ b/Documentation/devicetree/bindings/regulator/maxim,max8973.yaml
@@ -86,6 +86,9 @@  properties:
   reg:
     maxItems: 1
 
+  interrupts:
+    maxItems: 1
+
 required:
   - compatible
   - reg