| Message ID | 20211202223609.1171452-1-f.fainelli@gmail.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | dt-bindings: PCI: brcmstb: compatible is required | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dtbs-check | success | |
| robh/dt-meta-schema | success |
On Thu, Dec 2, 2021 at 4:36 PM Florian Fainelli <f.fainelli@gmail.com> wrote: > > The compatible property is required, make sure the binding documents it > as such. Yes, though if 'compatible' is not present and matching, the schema is never applied. I'll apply it later, but I wouldn't be too concerned fixing any others. > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > index 1fe102743f82..7c24d711b377 100644 > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > @@ -76,6 +76,7 @@ properties: > maxItems: 3 > > required: > + - compatible > - reg > - ranges > - dma-ranges > -- > 2.25.1 >
On 12/2/21 2:41 PM, Rob Herring wrote: > On Thu, Dec 2, 2021 at 4:36 PM Florian Fainelli <f.fainelli@gmail.com> wrote: >> >> The compatible property is required, make sure the binding documents it >> as such. > > Yes, though if 'compatible' is not present and matching, the schema is > never applied. I'll apply it later, but I wouldn't be too concerned > fixing any others. OK, just happened to run into that one by accident while converting the iProc PCIe binding to YAML.
On Thu, 02 Dec 2021 14:36:09 -0800, Florian Fainelli wrote: > The compatible property is required, make sure the binding documents it > as such. > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 1 + > 1 file changed, 1 insertion(+) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml index 1fe102743f82..7c24d711b377 100644 --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml @@ -76,6 +76,7 @@ properties: maxItems: 3 required: + - compatible - reg - ranges - dma-ranges
The compatible property is required, make sure the binding documents it as such. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 1 + 1 file changed, 1 insertion(+)