| Message ID | 20211118124819.1902427-3-robert.foss@linaro.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Remove clock-lanes DT property from CAMSS | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | fail | build log |
On Thu 18 Nov 06:48 CST 2021, Robert Foss wrote: > The clock-lanes property is not programmable by the hardware, > and as such it should not be exposed in the dt-binding. > > Signed-off-by: Robert Foss <robert.foss@linaro.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > .../bindings/media/qcom,msm8916-camss.yaml | 10 ---------- > .../bindings/media/qcom,msm8996-camss.yaml | 20 ------------------- > .../bindings/media/qcom,sdm660-camss.yaml | 20 ------------------- > .../bindings/media/qcom,sdm845-camss.yaml | 17 ---------------- > 4 files changed, 67 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml > index 304908072d72..12ec3e1ea869 100644 > --- a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml > @@ -83,10 +83,6 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 1 > - > data-lanes: > description: > An array of physical data lanes indexes. > @@ -99,7 +95,6 @@ properties: > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > port@1: > @@ -114,16 +109,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 1 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > reg: > diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml > index 38be41e932f0..6aeb3d6d02d5 100644 > --- a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml > @@ -105,10 +105,6 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 7 > - > data-lanes: > description: > An array of physical data lanes indexes. > @@ -121,7 +117,6 @@ properties: > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > port@1: > @@ -136,16 +131,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 7 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > port@2: > @@ -160,16 +150,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 7 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > port@3: > @@ -184,16 +169,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 7 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > reg: > diff --git a/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml > index 841a1aafdd13..338ab28d5f3b 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml > @@ -111,16 +111,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 7 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > port@1: > @@ -135,16 +130,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 7 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > port@2: > @@ -159,16 +149,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 7 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > port@3: > @@ -183,16 +168,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 7 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > reg: > diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml > index 9ca5dfa7f226..9404d6b9db54 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml > @@ -105,15 +105,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - maxItems: 1 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > port@1: > @@ -128,16 +124,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 7 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > port@2: > @@ -152,15 +143,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - maxItems: 1 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > port@3: > @@ -175,15 +162,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - maxItems: 1 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > reg: > -- > 2.32.0 >
On Thu, 18 Nov 2021 13:48:17 +0100, Robert Foss wrote: > The clock-lanes property is not programmable by the hardware, > and as such it should not be exposed in the dt-binding. > > Signed-off-by: Robert Foss <robert.foss@linaro.org> > --- > .../bindings/media/qcom,msm8916-camss.yaml | 10 ---------- > .../bindings/media/qcom,msm8996-camss.yaml | 20 ------------------- > .../bindings/media/qcom,sdm660-camss.yaml | 20 ------------------- > .../bindings/media/qcom,sdm845-camss.yaml | 17 ---------------- > 4 files changed, 67 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On Thu 18 Nov 04:48 PST 2021, Robert Foss wrote: > The clock-lanes property is not programmable by the hardware, > and as such it should not be exposed in the dt-binding. > > Signed-off-by: Robert Foss <robert.foss@linaro.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > .../bindings/media/qcom,msm8916-camss.yaml | 10 ---------- > .../bindings/media/qcom,msm8996-camss.yaml | 20 ------------------- > .../bindings/media/qcom,sdm660-camss.yaml | 20 ------------------- > .../bindings/media/qcom,sdm845-camss.yaml | 17 ---------------- > 4 files changed, 67 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml > index 304908072d72..12ec3e1ea869 100644 > --- a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml > @@ -83,10 +83,6 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 1 > - > data-lanes: > description: > An array of physical data lanes indexes. > @@ -99,7 +95,6 @@ properties: > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > port@1: > @@ -114,16 +109,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 1 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > reg: > diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml > index 38be41e932f0..6aeb3d6d02d5 100644 > --- a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml > @@ -105,10 +105,6 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 7 > - > data-lanes: > description: > An array of physical data lanes indexes. > @@ -121,7 +117,6 @@ properties: > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > port@1: > @@ -136,16 +131,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 7 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > port@2: > @@ -160,16 +150,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 7 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > port@3: > @@ -184,16 +169,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 7 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > reg: > diff --git a/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml > index 841a1aafdd13..338ab28d5f3b 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml > @@ -111,16 +111,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 7 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > port@1: > @@ -135,16 +130,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 7 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > port@2: > @@ -159,16 +149,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 7 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > port@3: > @@ -183,16 +168,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 7 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > reg: > diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml > index 9ca5dfa7f226..9404d6b9db54 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml > @@ -105,15 +105,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - maxItems: 1 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > port@1: > @@ -128,16 +124,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - items: > - - const: 7 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > port@2: > @@ -152,15 +143,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - maxItems: 1 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > port@3: > @@ -175,15 +162,11 @@ properties: > unevaluatedProperties: false > > properties: > - clock-lanes: > - maxItems: 1 > - > data-lanes: > minItems: 1 > maxItems: 4 > > required: > - - clock-lanes > - data-lanes > > reg: > -- > 2.32.0 >
diff --git a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml index 304908072d72..12ec3e1ea869 100644 --- a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml @@ -83,10 +83,6 @@ properties: unevaluatedProperties: false properties: - clock-lanes: - items: - - const: 1 - data-lanes: description: An array of physical data lanes indexes. @@ -99,7 +95,6 @@ properties: maxItems: 4 required: - - clock-lanes - data-lanes port@1: @@ -114,16 +109,11 @@ properties: unevaluatedProperties: false properties: - clock-lanes: - items: - - const: 1 - data-lanes: minItems: 1 maxItems: 4 required: - - clock-lanes - data-lanes reg: diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml index 38be41e932f0..6aeb3d6d02d5 100644 --- a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml @@ -105,10 +105,6 @@ properties: unevaluatedProperties: false properties: - clock-lanes: - items: - - const: 7 - data-lanes: description: An array of physical data lanes indexes. @@ -121,7 +117,6 @@ properties: maxItems: 4 required: - - clock-lanes - data-lanes port@1: @@ -136,16 +131,11 @@ properties: unevaluatedProperties: false properties: - clock-lanes: - items: - - const: 7 - data-lanes: minItems: 1 maxItems: 4 required: - - clock-lanes - data-lanes port@2: @@ -160,16 +150,11 @@ properties: unevaluatedProperties: false properties: - clock-lanes: - items: - - const: 7 - data-lanes: minItems: 1 maxItems: 4 required: - - clock-lanes - data-lanes port@3: @@ -184,16 +169,11 @@ properties: unevaluatedProperties: false properties: - clock-lanes: - items: - - const: 7 - data-lanes: minItems: 1 maxItems: 4 required: - - clock-lanes - data-lanes reg: diff --git a/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml index 841a1aafdd13..338ab28d5f3b 100644 --- a/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml @@ -111,16 +111,11 @@ properties: unevaluatedProperties: false properties: - clock-lanes: - items: - - const: 7 - data-lanes: minItems: 1 maxItems: 4 required: - - clock-lanes - data-lanes port@1: @@ -135,16 +130,11 @@ properties: unevaluatedProperties: false properties: - clock-lanes: - items: - - const: 7 - data-lanes: minItems: 1 maxItems: 4 required: - - clock-lanes - data-lanes port@2: @@ -159,16 +149,11 @@ properties: unevaluatedProperties: false properties: - clock-lanes: - items: - - const: 7 - data-lanes: minItems: 1 maxItems: 4 required: - - clock-lanes - data-lanes port@3: @@ -183,16 +168,11 @@ properties: unevaluatedProperties: false properties: - clock-lanes: - items: - - const: 7 - data-lanes: minItems: 1 maxItems: 4 required: - - clock-lanes - data-lanes reg: diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml index 9ca5dfa7f226..9404d6b9db54 100644 --- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml @@ -105,15 +105,11 @@ properties: unevaluatedProperties: false properties: - clock-lanes: - maxItems: 1 - data-lanes: minItems: 1 maxItems: 4 required: - - clock-lanes - data-lanes port@1: @@ -128,16 +124,11 @@ properties: unevaluatedProperties: false properties: - clock-lanes: - items: - - const: 7 - data-lanes: minItems: 1 maxItems: 4 required: - - clock-lanes - data-lanes port@2: @@ -152,15 +143,11 @@ properties: unevaluatedProperties: false properties: - clock-lanes: - maxItems: 1 - data-lanes: minItems: 1 maxItems: 4 required: - - clock-lanes - data-lanes port@3: @@ -175,15 +162,11 @@ properties: unevaluatedProperties: false properties: - clock-lanes: - maxItems: 1 - data-lanes: minItems: 1 maxItems: 4 required: - - clock-lanes - data-lanes reg:
The clock-lanes property is not programmable by the hardware, and as such it should not be exposed in the dt-binding. Signed-off-by: Robert Foss <robert.foss@linaro.org> --- .../bindings/media/qcom,msm8916-camss.yaml | 10 ---------- .../bindings/media/qcom,msm8996-camss.yaml | 20 ------------------- .../bindings/media/qcom,sdm660-camss.yaml | 20 ------------------- .../bindings/media/qcom,sdm845-camss.yaml | 17 ---------------- 4 files changed, 67 deletions(-)