diff mbox series

[1/5] dt-bindings: display: vc4: Add optional phandle to firmware

Message ID 20211117145040.334827-2-maxime@cerno.tech
State Changes Requested, archived
Headers show
Series drm/vc4: Use the firmware to stop the display pipeline | expand

Checks

Context Check Description
robh/checkpatch success
robh/dt-meta-schema success
robh/dtbs-check success

Commit Message

Maxime Ripard Nov. 17, 2021, 2:50 p.m. UTC
The firmware can free all the resources it was using to run the display
engine that won't be needed once the kernel has taken over.

Thus, we need a phandle to the firmware DT node to be able to send that
message when relevant.

Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 .../devicetree/bindings/display/brcm,bcm2835-vc4.yaml        | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Rob Herring (Arm) Nov. 29, 2021, 10:49 p.m. UTC | #1
On Wed, Nov 17, 2021 at 03:50:36PM +0100, Maxime Ripard wrote:
> The firmware can free all the resources it was using to run the display
> engine that won't be needed once the kernel has taken over.
> 
> Thus, we need a phandle to the firmware DT node to be able to send that
> message when relevant.

Why? Just use of_find_compatible_node(). 

> 
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
>  .../devicetree/bindings/display/brcm,bcm2835-vc4.yaml        | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml
> index 49a5e041aa49..18de6912b833 100644
> --- a/Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml
> +++ b/Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml
> @@ -21,6 +21,11 @@ properties:
>        - brcm,bcm2835-vc4
>        - brcm,cygnus-vc4
>  
> +  raspberrypi,firmware:
> +    $ref: "/schemas/types.yaml#/definitions/phandle"
> +    description: >
> +      Phandle to the firmware node
> +
>  required:
>    - compatible
>  
> -- 
> 2.33.1
> 
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml
index 49a5e041aa49..18de6912b833 100644
--- a/Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml
+++ b/Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml
@@ -21,6 +21,11 @@  properties:
       - brcm,bcm2835-vc4
       - brcm,cygnus-vc4
 
+  raspberrypi,firmware:
+    $ref: "/schemas/types.yaml#/definitions/phandle"
+    description: >
+      Phandle to the firmware node
+
 required:
   - compatible