| Message ID | 20211007000954.30621-8-zev@bewilderbeest.net |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Dynamic DT device nodes | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On 10/6/21 7:09 PM, Zev Weiss wrote: > The writable status sysfs file enabled by the 'dynamic' DT property > requires CONFIG_OF_DYNAMIC to be useful, but that shouldn't require > dragging in CONFIG_OF_UNITTEST as well. > > Signed-off-by: Zev Weiss <zev@bewilderbeest.net> > --- > drivers/of/Kconfig | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > index 3dfeae8912df..8e0ba87db030 100644 > --- a/drivers/of/Kconfig > +++ b/drivers/of/Kconfig > @@ -55,12 +55,14 @@ config OF_KOBJ > # Hardly any platforms need this. It is safe to select, but only do so if you > # need it. > config OF_DYNAMIC > - bool "Support for dynamic device trees" if OF_UNITTEST > + bool "Support for dynamic device trees" > select OF_KOBJ > help > On some platforms, the device tree can be manipulated at runtime. > - While this option is selected automatically on such platforms, you > - can enable it manually to improve device tree unit test coverage. > + With this option enabled, device tree nodes that are marked with > + the "dynamic" property can have their status toggled between > + "okay" and "reserved" via sysfs. This can also be enabled to > + increase test coverage with CONFIG_OF_UNITTEST if desired. > > config OF_ADDRESS > def_bool y > The help message should be extended to explain the impact of enabling OF_DYNAMIC manually (as opposed to auto selected) - it will be to allow writes to a node's "status" property in sysfs if the node contains a true value for the "dynamic" property.
diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig index 3dfeae8912df..8e0ba87db030 100644 --- a/drivers/of/Kconfig +++ b/drivers/of/Kconfig @@ -55,12 +55,14 @@ config OF_KOBJ # Hardly any platforms need this. It is safe to select, but only do so if you # need it. config OF_DYNAMIC - bool "Support for dynamic device trees" if OF_UNITTEST + bool "Support for dynamic device trees" select OF_KOBJ help On some platforms, the device tree can be manipulated at runtime. - While this option is selected automatically on such platforms, you - can enable it manually to improve device tree unit test coverage. + With this option enabled, device tree nodes that are marked with + the "dynamic" property can have their status toggled between + "okay" and "reserved" via sysfs. This can also be enabled to + increase test coverage with CONFIG_OF_UNITTEST if desired. config OF_ADDRESS def_bool y
The writable status sysfs file enabled by the 'dynamic' DT property requires CONFIG_OF_DYNAMIC to be useful, but that shouldn't require dragging in CONFIG_OF_UNITTEST as well. Signed-off-by: Zev Weiss <zev@bewilderbeest.net> --- drivers/of/Kconfig | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)