| Message ID | 20211006223603.18858-7-ansuelsmth@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Multiple improvement for qca8337 switch | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Thu, Oct 07, 2021 at 12:35:56AM +0200, Ansuel Smith wrote: > Document new qca,rgmii0_1_8v and qca,rgmii56_1_8v needed to setup > mac_pwr_sel register for ar8327 switch. > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > --- > Documentation/devicetree/bindings/net/dsa/qca8k.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > index 8c73f67c43ca..1f6b7d2f609e 100644 > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > @@ -13,6 +13,8 @@ Required properties: > Optional properties: > > - reset-gpios: GPIO to be used to reset the whole device > +- qca,rgmii0-1-8v: Set the internal regulator to supply 1.8v for MAC0 port > +- qca,rgmii56-1-8v: Set the internal regulator to supply 1.8v for MAC5/6 port What is the consumer of these 1.8v? The MACs are normally internal, the regulators are internal, so why is a DT property needed? Andrew
On Thu, Oct 07, 2021 at 02:09:36AM +0200, Andrew Lunn wrote: > On Thu, Oct 07, 2021 at 12:35:56AM +0200, Ansuel Smith wrote: > > Document new qca,rgmii0_1_8v and qca,rgmii56_1_8v needed to setup > > mac_pwr_sel register for ar8327 switch. > > > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > > --- > > Documentation/devicetree/bindings/net/dsa/qca8k.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > > index 8c73f67c43ca..1f6b7d2f609e 100644 > > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt > > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > > @@ -13,6 +13,8 @@ Required properties: > > Optional properties: > > > > - reset-gpios: GPIO to be used to reset the whole device > > +- qca,rgmii0-1-8v: Set the internal regulator to supply 1.8v for MAC0 port > > +- qca,rgmii56-1-8v: Set the internal regulator to supply 1.8v for MAC5/6 port > > What is the consumer of these 1.8v? The MACs are normally internal, > the regulators are internal, so why is a DT property needed? > > Andrew Only some device require this, with these bit at 0, the internal regulator provide 1.5v. It's not really a on/off but a toggle of the different operating voltage. Some device require this and some doesn't.
> Only some device require this, with these bit at 0, the internal > regulator provide 1.5v. It's not really a on/off but a toggle of the > different operating voltage. Some device require this and some doesn't. Can you provide a list of devices which require it? Andrew
On Thu, Oct 07, 2021 at 06:47:10PM +0200, Andrew Lunn wrote: > > Only some device require this, with these bit at 0, the internal > > regulator provide 1.5v. It's not really a on/off but a toggle of the > > different operating voltage. Some device require this and some doesn't. > > Can you provide a list of devices which require it? > > Andrew one bcm device the cisco meraki mx65 doesn't have them set. no qca8327 device have them used. device with qca,rgmii0-1-8v netgear r7500v2 Askey RT4230W REV6 device with qca,rgmii56-1-8v NEC Platforms Aterm WG2600HP3 TP-Link Talon AD7200 Qualcomm Technologies, Inc. IPQ8064/AP-148 AP-161 netgear d7800 dev board DB149 Linksys EA8500 WiFi Router Linksys EA7500 V1 WiFi Router ASRock G10 Netgear r7500 TP-Link Archer VR2600v NEC Aterm WG2600HP Compex WPQ864 Buffalo WXR-2533DHP device with both enabled: ZyXEL NBG6817 Netgear r7800 Here is the list I could have missed some user on the ath79 target but I hope I made a point on how random this is and that we need dedicated binding for this. Thanks for the review anyway.
diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt index 8c73f67c43ca..1f6b7d2f609e 100644 --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt @@ -13,6 +13,8 @@ Required properties: Optional properties: - reset-gpios: GPIO to be used to reset the whole device +- qca,rgmii0-1-8v: Set the internal regulator to supply 1.8v for MAC0 port +- qca,rgmii56-1-8v: Set the internal regulator to supply 1.8v for MAC5/6 port Subnodes:
Document new qca,rgmii0_1_8v and qca,rgmii56_1_8v needed to setup mac_pwr_sel register for ar8327 switch. Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> --- Documentation/devicetree/bindings/net/dsa/qca8k.txt | 2 ++ 1 file changed, 2 insertions(+)