diff mbox series

[v2,2/3] dt-bindings: phy: Add binding includes for lan966x serdes

Message ID 20211006063523.3962427-3-horatiu.vultur@microchip.com
State Changes Requested, archived
Headers show
Series Add driver for lan966x Serdes driver | expand

Checks

Context Check Description
robh/checkpatch success

Commit Message

Horatiu Vultur Oct. 6, 2021, 6:35 a.m. UTC 
Add include bindings for lan966x serdes

Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
---
 include/dt-bindings/phy/lan966x_serdes.h | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 include/dt-bindings/phy/lan966x_serdes.h

Comments

Rob Herring (Arm) Oct. 14, 2021, 6:25 p.m. UTC | #1 
On Wed, Oct 06, 2021 at 08:35:22AM +0200, Horatiu Vultur wrote:
> Add include bindings for lan966x serdes
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
>  include/dt-bindings/phy/lan966x_serdes.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 include/dt-bindings/phy/lan966x_serdes.h
> 
> diff --git a/include/dt-bindings/phy/lan966x_serdes.h b/include/dt-bindings/phy/lan966x_serdes.h
> new file mode 100644
> index 000000000000..06e529473475
> --- /dev/null
> +++ b/include/dt-bindings/phy/lan966x_serdes.h
> @@ -0,0 +1,14 @@
> +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
> +
> +#ifndef __LAN966X_SERDES_H__
> +#define __LAN966X_SERDES_H__
> +
> +#define CU(x)		(x)
> +#define CU_MAX		CU(2)
> +#define SERDES6G(x)	(CU_MAX + 1 + (x))
> +#define SERDES6G_MAX	SERDES6G(3)
> +#define RG(x)		(SERDES6G_MAX + 1 + (x))
> +#define RG_MAX		RG(2)
> +#define SERDES_MAX	(RG_MAX + 1)

I'm guessing these are used for the phy cells? If so, I can't figure out 
how and I shouldn't have to search the driver to figure it out.

What's CU? What's RG?
Horatiu Vultur Oct. 15, 2021, 8:29 a.m. UTC | #2 
The 10/14/2021 13:25, Rob Herring wrote:

> 
> On Wed, Oct 06, 2021 at 08:35:22AM +0200, Horatiu Vultur wrote:
> > Add include bindings for lan966x serdes
> >
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
> >  include/dt-bindings/phy/lan966x_serdes.h | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >  create mode 100644 include/dt-bindings/phy/lan966x_serdes.h
> >
> > diff --git a/include/dt-bindings/phy/lan966x_serdes.h b/include/dt-bindings/phy/lan966x_serdes.h
> > new file mode 100644
> > index 000000000000..06e529473475
> > --- /dev/null
> > +++ b/include/dt-bindings/phy/lan966x_serdes.h
> > @@ -0,0 +1,14 @@
> > +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
> > +
> > +#ifndef __LAN966X_SERDES_H__
> > +#define __LAN966X_SERDES_H__
> > +
> > +#define CU(x)                (x)
> > +#define CU_MAX               CU(2)
> > +#define SERDES6G(x)  (CU_MAX + 1 + (x))
> > +#define SERDES6G_MAX SERDES6G(3)
> > +#define RG(x)                (SERDES6G_MAX + 1 + (x))
> > +#define RG_MAX               RG(2)
> > +#define SERDES_MAX   (RG_MAX + 1)
> 
> I'm guessing these are used for the phy cells? If so, I can't figure out
> how and I shouldn't have to search the driver to figure it out.

These are just some constatns to be able to select between the
integrated PHYs, RGMII, SerDes interfaces. Because these interfaces
needs to be muxed according to the HW.

This is something similar with the Ocelot Serdes where there are only
2 Serdes types.

> 
> What's CU? What's RG?

Cu - copper PHY
RG - RGMII

I will create a new version where I will improve the log message.
diff mbox series

Patch

diff --git a/include/dt-bindings/phy/lan966x_serdes.h b/include/dt-bindings/phy/lan966x_serdes.h
new file mode 100644
index 000000000000..06e529473475
--- /dev/null
+++ b/include/dt-bindings/phy/lan966x_serdes.h
@@ -0,0 +1,14 @@ 
+/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
+
+#ifndef __LAN966X_SERDES_H__
+#define __LAN966X_SERDES_H__
+
+#define CU(x)		(x)
+#define CU_MAX		CU(2)
+#define SERDES6G(x)	(CU_MAX + 1 + (x))
+#define SERDES6G_MAX	SERDES6G(3)
+#define RG(x)		(SERDES6G_MAX + 1 + (x))
+#define RG_MAX		RG(2)
+#define SERDES_MAX	(RG_MAX + 1)
+
+#endif