| Message ID | 20211004151646.73599-1-krzysztof.kozlowski@canonical.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [next] dt-bindings: mmc: arasan,sdci: bring back requirement of clock-output-names | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 9 lines checked |
On Mon, 4 Oct 2021 at 17:17, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > The schema defines dependency only of clock-output-names on #clock-cells. > The dependency in opposite direction - requirement of clock-output-names > if #clock-cells is defined - should be explicitly included in the > bindings. > > Reported-by: Rob Herring <robh@kernel.org> > Fixes: 22ea8ab0dcc4 ("dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells dependency") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > Applied for next, thanks! I took the liberty to squash this into the previous commit, and move the reported-by tag into a reviewed-by tag from Rob. Feel free to yell at me if there is something you don't like with the squashed commit. Kind regards Uffe > --- > > Fixes tag from the linux-next > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml > index dd70431df0b7..de6f076e0ece 100644 > --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml > @@ -158,6 +158,9 @@ properties: > description: > The MIO bank number in which the command and data lines are configured. > > +dependencies: > + '#clock-cells': [ clock-output-names ] > + > required: > - compatible > - reg > -- > 2.30.2 >
diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml index dd70431df0b7..de6f076e0ece 100644 --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml @@ -158,6 +158,9 @@ properties: description: The MIO bank number in which the command and data lines are configured. +dependencies: + '#clock-cells': [ clock-output-names ] + required: - compatible - reg
The schema defines dependency only of clock-output-names on #clock-cells. The dependency in opposite direction - requirement of clock-output-names if #clock-cells is defined - should be explicitly included in the bindings. Reported-by: Rob Herring <robh@kernel.org> Fixes: 22ea8ab0dcc4 ("dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells dependency") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- Fixes tag from the linux-next Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 3 +++ 1 file changed, 3 insertions(+)