| Message ID | 20210928171231.12766-9-stephan@gerhold.net |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add support for Samsung Galaxy S4 Mini Value Edition | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Tue, Sep 28, 2021 at 07:12:24PM +0200, Stephan Gerhold wrote: > Document the qcom,msm8916-smp enable method. It is actually just > an alias for qcom,msm8226-smp since it should be implemented identically. > > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> > --- > Documentation/devicetree/bindings/arm/cpus.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml > index 11e3e09da2e5..5602a8f3c513 100644 > --- a/Documentation/devicetree/bindings/arm/cpus.yaml > +++ b/Documentation/devicetree/bindings/arm/cpus.yaml > @@ -211,6 +211,7 @@ properties: > - qcom,kpss-acc-v1 > - qcom,kpss-acc-v2 > - qcom,msm8226-smp > + - qcom,msm8916-smp I thought arm64 is PSCI only. > - renesas,apmu > - renesas,r9a06g032-smp > - rockchip,rk3036-smp > @@ -295,7 +296,8 @@ properties: > Specifies the ACC* node associated with this CPU. > > Required for systems that have an "enable-method" property > - value of "qcom,kpss-acc-v1", "qcom,kpss-acc-v2" or "qcom,msm8226-smp" > + value of "qcom,kpss-acc-v1", "qcom,kpss-acc-v2", "qcom,msm8226-smp" > + or "qcom,msm8916-smp". > > * arm/msm/qcom,kpss-acc.txt > > -- > 2.33.0 > >
On Mon, Oct 4, 2021 at 1:34 PM Rob Herring <robh@kernel.org> wrote: > > On Tue, Sep 28, 2021 at 07:12:24PM +0200, Stephan Gerhold wrote: > > Document the qcom,msm8916-smp enable method. It is actually just > > an alias for qcom,msm8226-smp since it should be implemented identically. > > > > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> > > --- > > Documentation/devicetree/bindings/arm/cpus.yaml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml > > index 11e3e09da2e5..5602a8f3c513 100644 > > --- a/Documentation/devicetree/bindings/arm/cpus.yaml > > +++ b/Documentation/devicetree/bindings/arm/cpus.yaml > > @@ -211,6 +211,7 @@ properties: > > - qcom,kpss-acc-v1 > > - qcom,kpss-acc-v2 > > - qcom,msm8226-smp > > + - qcom,msm8916-smp > > I thought arm64 is PSCI only. I see the explanation now. Please add that to this commit as well and a comment here that this is for 32-bit only. Rob
On Mon, Oct 04, 2021 at 01:37:58PM -0500, Rob Herring wrote: > On Mon, Oct 4, 2021 at 1:34 PM Rob Herring <robh@kernel.org> wrote: > > > > On Tue, Sep 28, 2021 at 07:12:24PM +0200, Stephan Gerhold wrote: > > > Document the qcom,msm8916-smp enable method. It is actually just > > > an alias for qcom,msm8226-smp since it should be implemented identically. > > > > > > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> > > > --- > > > Documentation/devicetree/bindings/arm/cpus.yaml | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml > > > index 11e3e09da2e5..5602a8f3c513 100644 > > > --- a/Documentation/devicetree/bindings/arm/cpus.yaml > > > +++ b/Documentation/devicetree/bindings/arm/cpus.yaml > > > @@ -211,6 +211,7 @@ properties: > > > - qcom,kpss-acc-v1 > > > - qcom,kpss-acc-v2 > > > - qcom,msm8226-smp > > > + - qcom,msm8916-smp > > > > I thought arm64 is PSCI only. > > I see the explanation now. Please add that to this commit as well and > a comment here that this is for 32-bit only. > I'm not sure why this is literally the only patch in the series where I omitted the explanation. Sorry for the confusion! :) I clarified this in v2 and added the comment as you suggested. Thanks! Stephan
diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml index 11e3e09da2e5..5602a8f3c513 100644 --- a/Documentation/devicetree/bindings/arm/cpus.yaml +++ b/Documentation/devicetree/bindings/arm/cpus.yaml @@ -211,6 +211,7 @@ properties: - qcom,kpss-acc-v1 - qcom,kpss-acc-v2 - qcom,msm8226-smp + - qcom,msm8916-smp - renesas,apmu - renesas,r9a06g032-smp - rockchip,rk3036-smp @@ -295,7 +296,8 @@ properties: Specifies the ACC* node associated with this CPU. Required for systems that have an "enable-method" property - value of "qcom,kpss-acc-v1", "qcom,kpss-acc-v2" or "qcom,msm8226-smp" + value of "qcom,kpss-acc-v1", "qcom,kpss-acc-v2", "qcom,msm8226-smp" + or "qcom,msm8916-smp". * arm/msm/qcom,kpss-acc.txt
Document the qcom,msm8916-smp enable method. It is actually just an alias for qcom,msm8226-smp since it should be implemented identically. Signed-off-by: Stephan Gerhold <stephan@gerhold.net> --- Documentation/devicetree/bindings/arm/cpus.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)