| Message ID | 20210808075328.30961-1-luoj@codeaurora.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | dt-bindings: net: Add the properties for ipq4019 MDIO | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 26 lines checked |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | success |
On Sun, Aug 08, 2021 at 03:53:28PM +0800, Luo Jie wrote: > The new added properties resource "reg" is for configuring > ethernet LDO in the IPQ5018 chipset, the property "clocks" > is for configuring the MDIO clock source frequency. > > This patch depends on the following patch: > Commit 2b8951cb4670 ("net: mdio: Add the reset function for IPQ MDIO > driver") Please always make binding patches part of the series containing the driver code. We sometimes need to see both to do a proper review. Add a comment about when the second address range and clock is required. Does qcom,ipq5018-mdio require them? Andrew
On 8/8/2021 11:47 PM, Andrew Lunn wrote: > On Sun, Aug 08, 2021 at 03:53:28PM +0800, Luo Jie wrote: >> The new added properties resource "reg" is for configuring >> ethernet LDO in the IPQ5018 chipset, the property "clocks" >> is for configuring the MDIO clock source frequency. >> >> This patch depends on the following patch: >> Commit 2b8951cb4670 ("net: mdio: Add the reset function for IPQ MDIO >> driver") > Please always make binding patches part of the series containing the > driver code. We sometimes need to see both to do a proper review. > > Add a comment about when the second address range and clock is > required. Does qcom,ipq5018-mdio require them? > > Andrew Hi Andrew, yes, the second address range is only required for qcom,ipq5018-mdio currently, will document it in next patch set, and send it with the drive code patch, thanks for the comments and review.
diff --git a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml index 0c973310ada0..8f53fa2a00f8 100644 --- a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml +++ b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml @@ -14,7 +14,9 @@ allOf: properties: compatible: - const: qcom,ipq4019-mdio + enum: + - qcom,ipq4019-mdio + - qcom,ipq5018-mdio "#address-cells": const: 1 @@ -23,7 +25,15 @@ properties: const: 0 reg: - maxItems: 1 + minItems: 1 + maxItems: 2 + description: + the first Address and length of the register set for the MDIO controller. + the optional second Address and length of the register for ethernet LDO. + + clocks: + items: + - description: MDIO clock required: - compatible
The new added properties resource "reg" is for configuring ethernet LDO in the IPQ5018 chipset, the property "clocks" is for configuring the MDIO clock source frequency. This patch depends on the following patch: Commit 2b8951cb4670 ("net: mdio: Add the reset function for IPQ MDIO driver") Signed-off-by: Luo Jie <luoj@codeaurora.org> --- .../devicetree/bindings/net/qcom,ipq4019-mdio.yaml | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)