| Message ID | 20210806102930.3024-3-biju.das.jz@bp.renesas.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 10 lines checked |
Hi Biju, On Fri, Aug 6, 2021 at 12:29 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > The DMAC driver on RZ/G2L expects the slave channel configuration > to be passed in dmas property. > This patch updates the example node to include the encoded slave > channel configuration. > > Fixes: 5df6dfbb6de815ba3a("ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support") > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > v3->v4: > * Updated bindings as the DMAC driver on RZ/G2L expects the > slave channel configuration to be passed in dmas property. Thanks for the update! > --- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml > +++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml > @@ -93,8 +93,8 @@ examples: > clock-names = "ssi", "ssi_sfr", "audio_clk1", "audio_clk2"; > power-domains = <&cpg>; > resets = <&cpg R9A07G044_SSI0_RST_M2_REG>; > - dmas = <&dmac 0x255>, > - <&dmac 0x256>; > + dmas = <&dmac 0x2655>, > + <&dmac 0x2656>; > dma-names = "tx", "rx"; > #sound-dai-cells = <0>; > }; I think it would be good to describe the expected format in the description for the dmas property, so the DTS writer knows what the numerical values in the example really mean. Gr{oetje,eeting}s, Geert
Hi Geert, Thanks for the update. > Subject: Re: [PATCH v4 2/3] ASoC: dt-bindings: sound: renesas,rz-ssi: > Update slave dma channel configuration parameters > > Hi Biju, > > On Fri, Aug 6, 2021 at 12:29 PM Biju Das <biju.das.jz@bp.renesas.com> > wrote: > > The DMAC driver on RZ/G2L expects the slave channel configuration to > > be passed in dmas property. > > This patch updates the example node to include the encoded slave > > channel configuration. > > > > Fixes: 5df6dfbb6de815ba3a("ASoC: dt-bindings: sound: renesas,rz-ssi: > > Document DMA support") > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > v3->v4: > > * Updated bindings as the DMAC driver on RZ/G2L expects the > > slave channel configuration to be passed in dmas property. > > Thanks for the update! > > > --- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml > > +++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml > > @@ -93,8 +93,8 @@ examples: > > clock-names = "ssi", "ssi_sfr", "audio_clk1", "audio_clk2"; > > power-domains = <&cpg>; > > resets = <&cpg R9A07G044_SSI0_RST_M2_REG>; > > - dmas = <&dmac 0x255>, > > - <&dmac 0x256>; > > + dmas = <&dmac 0x2655>, > > + <&dmac 0x2656>; > > dma-names = "tx", "rx"; > > #sound-dai-cells = <0>; > > }; > > I think it would be good to describe the expected format in the > description for the dmas property, so the DTS writer knows what the > numerical values in the example really mean. Agree, will add description for dmas property. Regards, Biju
On Mon, Aug 09, 2021 at 02:57:33PM +0200, Geert Uytterhoeven wrote: > Hi Biju, > > On Fri, Aug 6, 2021 at 12:29 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > The DMAC driver on RZ/G2L expects the slave channel configuration > > to be passed in dmas property. > > This patch updates the example node to include the encoded slave > > channel configuration. > > > > Fixes: 5df6dfbb6de815ba3a("ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support") > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > v3->v4: > > * Updated bindings as the DMAC driver on RZ/G2L expects the > > slave channel configuration to be passed in dmas property. > > Thanks for the update! > > > --- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml > > +++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml > > @@ -93,8 +93,8 @@ examples: > > clock-names = "ssi", "ssi_sfr", "audio_clk1", "audio_clk2"; > > power-domains = <&cpg>; > > resets = <&cpg R9A07G044_SSI0_RST_M2_REG>; > > - dmas = <&dmac 0x255>, > > - <&dmac 0x256>; > > + dmas = <&dmac 0x2655>, > > + <&dmac 0x2656>; > > dma-names = "tx", "rx"; > > #sound-dai-cells = <0>; > > }; > > I think it would be good to describe the expected format in the description > for the dmas property, so the DTS writer knows what the numerical > values in the example really mean. Yes, but that's a property of the DMA controller binding, not this one. It could vary from chip to chip. Rob
On Fri, 06 Aug 2021 11:29:29 +0100, Biju Das wrote: > The DMAC driver on RZ/G2L expects the slave channel configuration > to be passed in dmas property. > This patch updates the example node to include the encoded slave > channel configuration. > > Fixes: 5df6dfbb6de815ba3a("ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support") > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > Note:- > This patch is based on [1] > [1]:- https://patchwork.kernel.org/project/linux-renesas-soc/patch/20210806095322.2326-2-biju.das.jz@bp.renesas.com/ > > v3->v4: > * Updated bindings as the DMAC driver on RZ/G2L expects the > slave channel configuration to be passed in dmas property. > v2->v3: > * Merged the binding patch with dmas added > * Updated dt binding example with encoded #dma-cells value. > v1->v2: > * Rebased on 5.14-rc2. > --- > Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
Hi Rob, On Fri, Aug 13, 2021 at 10:12 PM Rob Herring <robh@kernel.org> wrote: > On Mon, Aug 09, 2021 at 02:57:33PM +0200, Geert Uytterhoeven wrote: > > On Fri, Aug 6, 2021 at 12:29 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > > The DMAC driver on RZ/G2L expects the slave channel configuration > > > to be passed in dmas property. > > > This patch updates the example node to include the encoded slave > > > channel configuration. > > > > > > Fixes: 5df6dfbb6de815ba3a("ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support") > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > > v3->v4: > > > * Updated bindings as the DMAC driver on RZ/G2L expects the > > > slave channel configuration to be passed in dmas property. > > > > Thanks for the update! > > > > > --- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml > > > +++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml > > > @@ -93,8 +93,8 @@ examples: > > > clock-names = "ssi", "ssi_sfr", "audio_clk1", "audio_clk2"; > > > power-domains = <&cpg>; > > > resets = <&cpg R9A07G044_SSI0_RST_M2_REG>; > > > - dmas = <&dmac 0x255>, > > > - <&dmac 0x256>; > > > + dmas = <&dmac 0x2655>, > > > + <&dmac 0x2656>; > > > dma-names = "tx", "rx"; > > > #sound-dai-cells = <0>; > > > }; > > > > I think it would be good to describe the expected format in the description > > for the dmas property, so the DTS writer knows what the numerical > > values in the example really mean. > > Yes, but that's a property of the DMA controller binding, not this one. > It could vary from chip to chip. Right, unlike the other Renesas SoCs, RZ/G2L uses the normal DMAC for audio, not an audio-specific one. Gr{oetje,eeting}s, Geert
diff --git a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml index 471937cb8d05..9923e7b8264f 100644 --- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml +++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml @@ -93,8 +93,8 @@ examples: clock-names = "ssi", "ssi_sfr", "audio_clk1", "audio_clk2"; power-domains = <&cpg>; resets = <&cpg R9A07G044_SSI0_RST_M2_REG>; - dmas = <&dmac 0x255>, - <&dmac 0x256>; + dmas = <&dmac 0x2655>, + <&dmac 0x2656>; dma-names = "tx", "rx"; #sound-dai-cells = <0>; };
The DMAC driver on RZ/G2L expects the slave channel configuration to be passed in dmas property. This patch updates the example node to include the encoded slave channel configuration. Fixes: 5df6dfbb6de815ba3a("ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support") Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- Note:- This patch is based on [1] [1]:- https://patchwork.kernel.org/project/linux-renesas-soc/patch/20210806095322.2326-2-biju.das.jz@bp.renesas.com/ v3->v4: * Updated bindings as the DMAC driver on RZ/G2L expects the slave channel configuration to be passed in dmas property. v2->v3: * Merged the binding patch with dmas added * Updated dt binding example with encoded #dma-cells value. v1->v2: * Rebased on 5.14-rc2. --- Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)