diff mbox series

dt-bindings: power: Bindings for Samsung batteries

Message ID 20210806090050.3510671-1-linus.walleij@linaro.org
State Not Applicable, archived
Headers show
Series dt-bindings: power: Bindings for Samsung batteries | expand

Checks

Context Check Description
robh/checkpatch success
robh/dt-meta-schema success
robh/dtbs-check success

Commit Message

Linus Walleij Aug. 6, 2021, 9 a.m. UTC
This adds device tree bindings for Samsung SDI batteries.
Everything can be determined from the product number so the entire
battery is just a specific compatible string.

Cc: devicetree@vger.kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 .../power/supply/samsung,battery.yaml         | 56 +++++++++++++++++++
 1 file changed, 56 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/samsung,battery.yaml

Comments

Rob Herring (Arm) Aug. 13, 2021, 7:09 p.m. UTC | #1
On Fri, 06 Aug 2021 11:00:50 +0200, Linus Walleij wrote:
> This adds device tree bindings for Samsung SDI batteries.
> Everything can be determined from the product number so the entire
> battery is just a specific compatible string.
> 
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  .../power/supply/samsung,battery.yaml         | 56 +++++++++++++++++++
>  1 file changed, 56 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/supply/samsung,battery.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Linus Walleij Aug. 29, 2021, 7:09 p.m. UTC | #2
On Fri, Aug 6, 2021 at 11:02 AM Linus Walleij <linus.walleij@linaro.org> wrote:

> This adds device tree bindings for Samsung SDI batteries.
> Everything can be determined from the product number so the entire
> battery is just a specific compatible string.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Sebastian: can this be merged? I am working on corresponding code
for Linux to populate Samsung batteries from compatible.

Yours,
Linus Walleij
Sebastian Reichel Oct. 5, 2021, 3:23 p.m. UTC | #3
Hi,

On Sun, Aug 29, 2021 at 09:09:47PM +0200, Linus Walleij wrote:
> On Fri, Aug 6, 2021 at 11:02 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> 
> > This adds device tree bindings for Samsung SDI batteries.
> > Everything can be determined from the product number so the entire
> > battery is just a specific compatible string.
> >
> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Sebastian: can this be merged? I am working on corresponding code
> for Linux to populate Samsung batteries from compatible.

Thanks, queued.

-- Sebastian
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/power/supply/samsung,battery.yaml b/Documentation/devicetree/bindings/power/supply/samsung,battery.yaml
new file mode 100644
index 000000000000..40292d581b10
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/supply/samsung,battery.yaml
@@ -0,0 +1,56 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/supply/samsung,battery.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung SDI Batteries
+
+maintainers:
+  - Linus Walleij <linus.walleij@linaro.org>
+
+description: |
+  Samsung SDI (Samsung Digital Interface) batteries are all different versions
+  of lithium ion chemistry devices used for mobile phones, laptops and other
+  portable electronics. The batteries are adapted to a specific product and
+  the physical restrictions make it impossible to use another battery with the
+  product, so product device trees can specify these batteries. Operating
+  systems should determine hardware characteristics of the batteries from the
+  compatible string.
+
+properties:
+  compatible:
+    oneOf:
+      - const: samsung,eb-l1m7flu
+        description: 3.8V 1500 mAh battery used in Samsung GT-I8190
+      - const: samsung,eb425161la
+        description: 3.8V 1500 mAh battery used in Samsung SGH-T599 and SGH-I407
+      - const: samsung,eb425161lu
+        description: 3.8V 1500 mAh battery used in Samsung GT-I8160
+      - const: samsung,eb485159lu
+        description: 3.8V 1700 mAh battery used in Samsung GT-S7710
+      - const: samsung,eb535151vu
+        description: 3.8V 1500 mAh battery used in Samsung GT-I9070
+      - const: samsung,eb585157lu
+        description: 3.8V 2000 mAh battery used in Samsung GT-I8530
+
+required:
+  - compatible
+
+additionalProperties: false
+
+examples:
+  - |
+    power {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      battery: battery {
+        compatible = "samsung,eb425161la";
+      };
+
+      charger@11 {
+        reg = <0x11>;
+        monitored-battery = <&battery>;
+      };
+    };