| Message ID | 20210805085828.3451909-1-linus.walleij@linaro.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/2,v2] dt-bindings: power: Extend battery bindings with type | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | fail | build log |
Hi, On Thu, Aug 05, 2021 at 10:58:27AM +0200, Linus Walleij wrote: > This adds a battery-type property and bindings for the different > "technologies" that are used in Linux. More types can be added. > > This is needed to convert the custom ST-Ericsson AB8500 battery > properties over to the generic battery bindings. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > ChangeLog v1->v2: > - Add devicetree list to Cc > - Use "device-chemistry" instead of "battery-type" as this > has precedence in standards. > I need a bunch of new bindings for switch the STE AB8500 custom > bindings out, but I need to start somewhere, this is as good as > any place to start. > --- Waiting a bit to give Rob a chance to review this. From my side it looks good. Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> -- Sebastian > .../devicetree/bindings/power/supply/battery.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/supply/battery.yaml b/Documentation/devicetree/bindings/power/supply/battery.yaml > index c3b4b7543591..d56ac484fec5 100644 > --- a/Documentation/devicetree/bindings/power/supply/battery.yaml > +++ b/Documentation/devicetree/bindings/power/supply/battery.yaml > @@ -31,6 +31,20 @@ properties: > compatible: > const: simple-battery > > + device-chemistry: > + description: This describes the chemical technology of the battery. > + oneOf: > + - const: nickel-cadmium > + - const: nickel-metal-hydride > + - const: lithium-ion > + description: This is a blanket type for all lithium-ion batteries, > + including those below. If possible, a precise compatible string > + from below should be used, but sometimes it is unknown which specific > + lithium ion battery is employed and this wide compatible can be used. > + - const: lithium-ion-polymer > + - const: lithium-ion-iron-phosphate > + - const: lithium-ion-manganese-oxide > + > over-voltage-threshold-microvolt: > description: battery over-voltage limit > > -- > 2.31.1 >
On Thu, Aug 05, 2021 at 10:58:27AM +0200, Linus Walleij wrote: > This adds a battery-type property and bindings for the different s/battery-type/"device-chemistry"/ Otherwise, Reviewed-by: Rob Herring <robh@kernel.org> > "technologies" that are used in Linux. More types can be added. > > This is needed to convert the custom ST-Ericsson AB8500 battery > properties over to the generic battery bindings. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > ChangeLog v1->v2: > - Add devicetree list to Cc > - Use "device-chemistry" instead of "battery-type" as this > has precedence in standards. > I need a bunch of new bindings for switch the STE AB8500 custom > bindings out, but I need to start somewhere, this is as good as > any place to start. > --- > .../devicetree/bindings/power/supply/battery.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+)
On Fri, Aug 13, 2021 at 8:26 PM Rob Herring <robh@kernel.org> wrote: > On Thu, Aug 05, 2021 at 10:58:27AM +0200, Linus Walleij wrote: > > This adds a battery-type property and bindings for the different > > s/battery-type/"device-chemistry"/ > > Otherwise, > > Reviewed-by: Rob Herring <robh@kernel.org> Thanks Rob, Sebastian tell me if you can fix this when applying or if you want me to respin the patch. Yours, Linus Walleij
Hi, On Fri, Aug 13, 2021 at 11:46:52PM +0200, Linus Walleij wrote: > On Fri, Aug 13, 2021 at 8:26 PM Rob Herring <robh@kernel.org> wrote: > > On Thu, Aug 05, 2021 at 10:58:27AM +0200, Linus Walleij wrote: > > > This adds a battery-type property and bindings for the different > > > > s/battery-type/"device-chemistry"/ > > > > Otherwise, > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > Thanks Rob, Sebastian tell me if you can fix this when applying > or if you want me to respin the patch. No, that's fine. I queued both patches with type changed to chemistry in the commit messages. -- Sebastian
diff --git a/Documentation/devicetree/bindings/power/supply/battery.yaml b/Documentation/devicetree/bindings/power/supply/battery.yaml index c3b4b7543591..d56ac484fec5 100644 --- a/Documentation/devicetree/bindings/power/supply/battery.yaml +++ b/Documentation/devicetree/bindings/power/supply/battery.yaml @@ -31,6 +31,20 @@ properties: compatible: const: simple-battery + device-chemistry: + description: This describes the chemical technology of the battery. + oneOf: + - const: nickel-cadmium + - const: nickel-metal-hydride + - const: lithium-ion + description: This is a blanket type for all lithium-ion batteries, + including those below. If possible, a precise compatible string + from below should be used, but sometimes it is unknown which specific + lithium ion battery is employed and this wide compatible can be used. + - const: lithium-ion-polymer + - const: lithium-ion-iron-phosphate + - const: lithium-ion-manganese-oxide + over-voltage-threshold-microvolt: description: battery over-voltage limit
This adds a battery-type property and bindings for the different "technologies" that are used in Linux. More types can be added. This is needed to convert the custom ST-Ericsson AB8500 battery properties over to the generic battery bindings. Cc: devicetree@vger.kernel.org Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- ChangeLog v1->v2: - Add devicetree list to Cc - Use "device-chemistry" instead of "battery-type" as this has precedence in standards. I need a bunch of new bindings for switch the STE AB8500 custom bindings out, but I need to start somewhere, this is as good as any place to start. --- .../devicetree/bindings/power/supply/battery.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+)