| Message ID | 20210804081352.30595-2-shawn.guo@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add Truly NT35521 panel driver support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | success |
On Wed, Aug 04, 2021 at 06:03:54PM +0200, Sam Ravnborg wrote: > Hi Shawn, > > On Wed, Aug 04, 2021 at 04:13:51PM +0800, Shawn Guo wrote: > > The Truly NT35521 is a 5.24" 1280x720 DSI panel, and the backlight is > > managed through DSI link. > > > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > > Please consider adding an optional port node, so we can use this panels > in a setup using a graph. Sure, will do in v2. > A simple port: true would do the trick. > I am aware that it may not be used today, this is a preparation for > potential future use. > > With this fixed, > Reviewed-by: Sam Ravnborg <sam@ravnborg.org> Thanks, Sam! Shawn
On Wed, Aug 04, 2021 at 04:13:51PM +0800, Shawn Guo wrote: > The Truly NT35521 is a 5.24" 1280x720 DSI panel, and the backlight is > managed through DSI link. > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > --- > .../bindings/display/panel/truly,nt35521.yaml | 62 +++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/truly,nt35521.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/truly,nt35521.yaml b/Documentation/devicetree/bindings/display/panel/truly,nt35521.yaml > new file mode 100644 > index 000000000000..4727c3df6eb8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/truly,nt35521.yaml > @@ -0,0 +1,62 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/truly,nt35521.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Truly NT35521 5.24" 1280x720 MIPI-DSI Panel > + > +maintainers: > + - Shawn Guo <shawn.guo@linaro.org> > + > +description: | > + The Truly NT35521 is a 5.24" 1280x720 MIPI-DSI panel. The panel backlight > + is managed through DSI link. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: truly,nt35521 > + > + reg: true > + > + reset-gpios: true > + > + enable-gpios: true > + > + pwr-positive5-gpios: > + maxItems: 1 > + > + pwr-negative5-gpios: > + maxItems: 1 Are these +/-5V supplies? If so, they should be modeled with gpio-regulator perhaps unless the panel connection could only ever be GPIOs. > + > +required: > + - compatible > + - reg > + - reset-gpios > + - enable-gpios > + - pwr-positive5-gpios > + - pwr-negative5-gpios > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + dsi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + panel@0 { > + compatible = "truly,nt35521"; > + reg = <0>; > + reset-gpios = <&msmgpio 25 GPIO_ACTIVE_LOW>; > + pwr-positive5-gpios = <&msmgpio 114 GPIO_ACTIVE_HIGH>; > + pwr-negative5-gpios = <&msmgpio 17 GPIO_ACTIVE_HIGH>; > + enable-gpios = <&msmgpio 10 GPIO_ACTIVE_HIGH>; > + }; > + }; > +... > -- > 2.17.1 > >
On Wed, Aug 11, 2021 at 12:51:56PM -0600, Rob Herring wrote: > On Wed, Aug 04, 2021 at 04:13:51PM +0800, Shawn Guo wrote: > > The Truly NT35521 is a 5.24" 1280x720 DSI panel, and the backlight is > > managed through DSI link. > > > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > > --- > > .../bindings/display/panel/truly,nt35521.yaml | 62 +++++++++++++++++++ > > 1 file changed, 62 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/panel/truly,nt35521.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/panel/truly,nt35521.yaml b/Documentation/devicetree/bindings/display/panel/truly,nt35521.yaml > > new file mode 100644 > > index 000000000000..4727c3df6eb8 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/panel/truly,nt35521.yaml > > @@ -0,0 +1,62 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/panel/truly,nt35521.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Truly NT35521 5.24" 1280x720 MIPI-DSI Panel > > + > > +maintainers: > > + - Shawn Guo <shawn.guo@linaro.org> > > + > > +description: | > > + The Truly NT35521 is a 5.24" 1280x720 MIPI-DSI panel. The panel backlight > > + is managed through DSI link. > > + > > +allOf: > > + - $ref: panel-common.yaml# > > + > > +properties: > > + compatible: > > + const: truly,nt35521 > > + > > + reg: true > > + > > + reset-gpios: true > > + > > + enable-gpios: true > > + > > + pwr-positive5-gpios: > > + maxItems: 1 > > + > > + pwr-negative5-gpios: > > + maxItems: 1 > > Are these +/-5V supplies? If so, they should be modeled with > gpio-regulator perhaps unless the panel connection could only ever be > GPIOs. Hi Rob, The binding has been updated in v2 [1]. Please help review that. Thanks! Shawn [1] https://lore.kernel.org/linux-arm-msm/20210809051008.6172-2-shawn.guo@linaro.org/T/#m587035a602b1be6c5326dcf24af01b3e8a5d2cc9 > > > + > > +required: > > + - compatible > > + - reg > > + - reset-gpios > > + - enable-gpios > > + - pwr-positive5-gpios > > + - pwr-negative5-gpios > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/gpio/gpio.h> > > + > > + dsi { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + panel@0 { > > + compatible = "truly,nt35521"; > > + reg = <0>; > > + reset-gpios = <&msmgpio 25 GPIO_ACTIVE_LOW>; > > + pwr-positive5-gpios = <&msmgpio 114 GPIO_ACTIVE_HIGH>; > > + pwr-negative5-gpios = <&msmgpio 17 GPIO_ACTIVE_HIGH>; > > + enable-gpios = <&msmgpio 10 GPIO_ACTIVE_HIGH>; > > + }; > > + }; > > +... > > -- > > 2.17.1 > > > >
diff --git a/Documentation/devicetree/bindings/display/panel/truly,nt35521.yaml b/Documentation/devicetree/bindings/display/panel/truly,nt35521.yaml new file mode 100644 index 000000000000..4727c3df6eb8 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/truly,nt35521.yaml @@ -0,0 +1,62 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/truly,nt35521.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Truly NT35521 5.24" 1280x720 MIPI-DSI Panel + +maintainers: + - Shawn Guo <shawn.guo@linaro.org> + +description: | + The Truly NT35521 is a 5.24" 1280x720 MIPI-DSI panel. The panel backlight + is managed through DSI link. + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: truly,nt35521 + + reg: true + + reset-gpios: true + + enable-gpios: true + + pwr-positive5-gpios: + maxItems: 1 + + pwr-negative5-gpios: + maxItems: 1 + +required: + - compatible + - reg + - reset-gpios + - enable-gpios + - pwr-positive5-gpios + - pwr-negative5-gpios + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + dsi { + #address-cells = <1>; + #size-cells = <0>; + + panel@0 { + compatible = "truly,nt35521"; + reg = <0>; + reset-gpios = <&msmgpio 25 GPIO_ACTIVE_LOW>; + pwr-positive5-gpios = <&msmgpio 114 GPIO_ACTIVE_HIGH>; + pwr-negative5-gpios = <&msmgpio 17 GPIO_ACTIVE_HIGH>; + enable-gpios = <&msmgpio 10 GPIO_ACTIVE_HIGH>; + }; + }; +...
The Truly NT35521 is a 5.24" 1280x720 DSI panel, and the backlight is managed through DSI link. Signed-off-by: Shawn Guo <shawn.guo@linaro.org> --- .../bindings/display/panel/truly,nt35521.yaml | 62 +++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/truly,nt35521.yaml