| Message ID | 20210423172450.4885-3-jonathan@marek.ca |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | drm/msm/dsi: support CPHY mode for 7nm pll/phy | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Fri, Apr 23, 2021 at 01:24:40PM -0400, Jonathan Marek wrote: > Document qcom,dsi-phy-cphy-mode option, which can be used to control > whether DSI will operate in D-PHY (default) or C-PHY mode. Given this is a standard MIPI thing, I think this needs to be a common property. We already have phy bindings that use the phy cells to set the phy type which I think you should use here. See include/dt-bindings/phy/phy.h. > > Signed-off-by: Jonathan Marek <jonathan@marek.ca> > --- > Documentation/devicetree/bindings/display/msm/dsi.txt | 1 + > 1 file changed, 1 insertion(+) Note that this file is in the process of being converted to schema. That's been going on for at least the last year... :(
On 5/3/21 1:11 PM, Rob Herring wrote: > On Fri, Apr 23, 2021 at 01:24:40PM -0400, Jonathan Marek wrote: >> Document qcom,dsi-phy-cphy-mode option, which can be used to control >> whether DSI will operate in D-PHY (default) or C-PHY mode. > > Given this is a standard MIPI thing, I think this needs to be a common > property. We already have phy bindings that use the phy cells to set the > phy type which I think you should use here. See > include/dt-bindings/phy/phy.h. > Is it OK to simply change the option to something like "phy-mode = <PHY_TYPE_DSI_CPHY>;"? (using phy-cells would be annoying to implement, with no benefit IMO)
On 28/05/2021 15:57, Jonathan Marek wrote: > On 5/3/21 1:11 PM, Rob Herring wrote: >> On Fri, Apr 23, 2021 at 01:24:40PM -0400, Jonathan Marek wrote: >>> Document qcom,dsi-phy-cphy-mode option, which can be used to control >>> whether DSI will operate in D-PHY (default) or C-PHY mode. >> >> Given this is a standard MIPI thing, I think this needs to be a common >> property. We already have phy bindings that use the phy cells to set the >> phy type which I think you should use here. See >> include/dt-bindings/phy/phy.h. >> > > Is it OK to simply change the option to something like "phy-mode = > <PHY_TYPE_DSI_CPHY>;"? > > (using phy-cells would be annoying to implement, with no benefit IMO) To add another feather to the balance scales: - `phys = <&dsi0_phy PHY_TYPE_DSI_CPHY>;` would bring knowledge about PHY mode to the DSI host (which does not really care about PHY mode) - `phy-mode = <PHY_TYPE_DSI_CPHY>;` would stay in the PHY node, where this information belongs.
diff --git a/Documentation/devicetree/bindings/display/msm/dsi.txt b/Documentation/devicetree/bindings/display/msm/dsi.txt index b9a64d3ff184..7ffc86a9816b 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi.txt +++ b/Documentation/devicetree/bindings/display/msm/dsi.txt @@ -124,6 +124,7 @@ Required properties: Optional properties: - qcom,dsi-phy-regulator-ldo-mode: Boolean value indicating if the LDO mode PHY regulator is wanted. +- qcom,dsi-phy-cphy-mode: Boolean value indicating if CPHY mode is wanted. - qcom,mdss-mdp-transfer-time-us: Specifies the dsi transfer time for command mode panels in microseconds. Driver uses this number to adjust the clock rate according to the expected transfer time.
Document qcom,dsi-phy-cphy-mode option, which can be used to control whether DSI will operate in D-PHY (default) or C-PHY mode. Signed-off-by: Jonathan Marek <jonathan@marek.ca> --- Documentation/devicetree/bindings/display/msm/dsi.txt | 1 + 1 file changed, 1 insertion(+)