| Message ID | 20210419051325.147314-1-joe_hung@ilitek.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [RESEND,v7,1/2] dt-bindings: input: touchscreen: ilitek_ts_i2c: Add bindings | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | success |
Hi Joe, On Mon, Apr 19, 2021 at 01:13:25PM +0800, Joe Hung wrote: > Add support for ILITEK Lego series of touch devices. > Lego series includes ILITEK 213X/23XX/25XX. > > Tested/passed with evaluation board with ILI2520/2322 IC. Sorry, I mean to send the email earlier, but I did apply the patches with some minor formatting changes and ... > + > + /* Single touch input setup */ > + input_set_abs_params(input, ABS_X, ts->screen_min_x, > + ts->screen_max_x, 0, 0); > + input_set_abs_params(input, ABS_Y, ts->screen_min_y, > + ts->screen_max_y, 0, 0); You do not need to set up single-axis as ... > + > + /* Multi-touch input setup */ > + input_set_abs_params(input, ABS_MT_POSITION_X, > + ts->screen_min_x, > + ts->screen_max_x, 0, 0); > + input_set_abs_params(input, ABS_MT_POSITION_Y, > + ts->screen_min_y, > + ts->screen_max_y, 0, 0); > + > + touchscreen_parse_properties(input, true, &ts->prop); > + > + error = input_mt_init_slots(input, ts->max_tp, > + INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED); this will do it for you. Thanks.
Hello Dmitry, Thank you for your reply, agreed on your comments. I didn't notice the patches you applied before. Please ignored the PATCH v8, I just mailed. Appreciate your time, thank you very much. On Tue, Apr 20, 2021 at 22:40:12PM -0700, Dmitry Torokhov wrote: > Hi Joe, > > On Mon, Apr 19, 2021 at 01:13:25PM +0800, Joe Hung wrote: > > Add support for ILITEK Lego series of touch devices. > > Lego series includes ILITEK 213X/23XX/25XX. > > > > Tested/passed with evaluation board with ILI2520/2322 IC. > > Sorry, I mean to send the email earlier, but I did apply the patches > with some minor formatting changes and ... > > > + > > + /* Single touch input setup */ > > + input_set_abs_params(input, ABS_X, ts->screen_min_x, > > + ts->screen_max_x, 0, 0); > > + input_set_abs_params(input, ABS_Y, ts->screen_min_y, > > + ts->screen_max_y, 0, 0); > > You do not need to set up single-axis as ... > > > + > > + /* Multi-touch input setup */ > > + input_set_abs_params(input, ABS_MT_POSITION_X, > > + ts->screen_min_x, > > + ts->screen_max_x, 0, 0); > > + input_set_abs_params(input, ABS_MT_POSITION_Y, > > + ts->screen_min_y, > > + ts->screen_max_y, 0, 0); > > + > > + touchscreen_parse_properties(input, true, &ts->prop); > > + > > + error = input_mt_init_slots(input, ts->max_tp, > > + INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED); > > this will do it for you. > > Thanks. > > -- > Dmitry -- Joe Hung
diff --git a/Documentation/devicetree/bindings/input/touchscreen/ilitek_ts_i2c.yaml b/Documentation/devicetree/bindings/input/touchscreen/ilitek_ts_i2c.yaml new file mode 100644 index 000000000000..a190e7baac31 --- /dev/null +++ b/Documentation/devicetree/bindings/input/touchscreen/ilitek_ts_i2c.yaml @@ -0,0 +1,73 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/touchscreen/ilitek_ts_i2c.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Ilitek I2C Touchscreen Controller + +maintainers: + - Dmitry Torokhov <dmitry.torokhov@gmail.com> + +allOf: + - $ref: touchscreen.yaml# + +properties: + compatible: + enum: + - ilitek,ili2130 + - ilitek,ili2131 + - ilitek,ili2132 + - ilitek,ili2316 + - ilitek,ili2322 + - ilitek,ili2323 + - ilitek,ili2326 + - ilitek,ili2520 + - ilitek,ili2521 + + reg: + const: 0x41 + + interrupts: + maxItems: 1 + + reset-gpios: + maxItems: 1 + + wakeup-source: + type: boolean + description: touchscreen can be used as a wakeup source. + + touchscreen-size-x: true + touchscreen-size-y: true + touchscreen-inverted-x: true + touchscreen-inverted-y: true + touchscreen-swapped-x-y: true + +additionalProperties: false + +required: + - compatible + - reg + - interrupts + - reset-gpios + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/gpio/gpio.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + + touchscreen@41 { + compatible = "ilitek,ili2520"; + reg = <0x41>; + + interrupt-parent = <&gpio1>; + interrupts = <7 IRQ_TYPE_LEVEL_LOW>; + reset-gpios = <&gpio1 8 GPIO_ACTIVE_LOW>; + touchscreen-inverted-y; + wakeup-source; + }; + };