diff mbox series

[1/7] dt-bindings: mfd: mediatek: Fix regulator description

Message ID 20210312145545.26050-1-matthias.bgg@kernel.org
State Not Applicable, archived
Headers show
Series [1/7] dt-bindings: mfd: mediatek: Fix regulator description | expand

Checks

Context Check Description
robh/checkpatch success

Commit Message

Matthias Brugger March 12, 2021, 2:55 p.m. UTC
From: Matthias Brugger <mbrugger@suse.com>

Having a separate compatible for the regulator node is redundant and not
needed. Delete the corresponding requierement.

Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---

 Documentation/devicetree/bindings/mfd/mt6397.txt | 3 ---
 1 file changed, 3 deletions(-)

Comments

Mark Brown March 18, 2021, 1:31 p.m. UTC | #1
On Fri, Mar 12, 2021 at 03:55:42PM +0100, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
> 
> Define the regulator node under which the regulators are described.

Acked-by: Mark Brown <broonie@kernel.org>
Enric Balletbo Serra March 18, 2021, 2:14 p.m. UTC | #2
Hi Matthias,

Thank you for your patch.

Missatge de l'adreça <matthias.bgg@kernel.org> del dia dv., 12 de març
2021 a les 15:57:
>
> From: Matthias Brugger <mbrugger@suse.com>
>
> The regulator framework does not need compatible, it's actually
> superfluous. Drop it from the DT.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>
> Series-to: lee.jones@linaro.org
> Series-to: robh+dt@kernel.org
> Series-to: matthias.bgg@gmail.com
> Series-to: lgirdwood@gmail.com
> Series-to: broonie@kernel.org
> Series-cc: devicetree@vger.kernel.org
> Series-cc: linux-arm-kernel@lists.infradead.org
> Series-cc: linux-mediatek@lists.infradead.org
> Series-cc: linux-kernel@vger.kernel.org
> ---
>  arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 4 +---
>  arch/arm64/boot/dts/mediatek/mt8173-evb.dts  | 4 +---
>  2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index 21452c51a20a8..db06a986f763e 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -916,9 +916,7 @@ pio6397: pinctrl {
>                         #gpio-cells = <2>;
>                 };
>
> -               regulator: mt6397regulator {
> -                       compatible = "mediatek,mt6397-regulator";
> -
> +               mt6397regulator {

The same happens here, it is not checked because the mt6397 is not in
YAML format yet, but once we do this it'll trigger an error as the
node name should be 'regulators'


>                         mt6397_vpca15_reg: buck_vpca15 {
>                                 regulator-compatible = "buck_vpca15";
>                                 regulator-name = "vpca15";
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> index 6dffada2e66b4..c3f2a85d55fe7 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> @@ -303,9 +303,7 @@ pmic: mt6397 {
>                 interrupt-controller;
>                 #interrupt-cells = <2>;
>
> -               mt6397regulator: mt6397regulator {
> -                       compatible = "mediatek,mt6397-regulator";
> -
> +               mt6397regulator {
>                         mt6397_vpca15_reg: buck_vpca15 {
>                                 regulator-compatible = "buck_vpca15";
>                                 regulator-name = "vpca15";
> --
> 2.30.1
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
Lee Jones March 23, 2021, 9:05 a.m. UTC | #3
On Fri, 12 Mar 2021, matthias.bgg@kernel.org wrote:

> From: Matthias Brugger <mbrugger@suse.com>
> 
> For regulators a compatible string is superfluous. Drop the string.
> 
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> ---
>  drivers/mfd/mt6397-core.c | 3 ---
>  1 file changed, 3 deletions(-)

Acked-by: Lee Jones <lee.jones@linaro.org>
Rob Herring March 24, 2021, 4:12 p.m. UTC | #4
On Fri, 12 Mar 2021 15:55:39 +0100, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
> 
> Having a separate compatible for the regulator node is redundant and not
> needed. Delete the corresponding requierement.
> 
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> ---
> 
>  Documentation/devicetree/bindings/mfd/mt6397.txt | 3 ---
>  1 file changed, 3 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt
index 2661775a38251..28a69728e6fe2 100644
--- a/Documentation/devicetree/bindings/mfd/mt6397.txt
+++ b/Documentation/devicetree/bindings/mfd/mt6397.txt
@@ -33,11 +33,8 @@  Optional subnodes:
 	For details, see ../rtc/rtc-mt6397.txt
 - regulators
 	Required properties:
-		- compatible: "mediatek,mt6323-regulator"
 	see ../regulator/mt6323-regulator.txt
-		- compatible: "mediatek,mt6358-regulator"
 	see ../regulator/mt6358-regulator.txt
-		- compatible: "mediatek,mt6397-regulator"
 	see ../regulator/mt6397-regulator.txt
 - codec
 	Required properties: