| Message ID | 20210311100313.3591254-4-badhri@google.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | success |
On Thu, Mar 11, 2021 at 02:03:13AM -0800, Badhri Jagan Sridharan wrote: > chg-psy-name is an optional string property used to indicate the > power supply object for which the current/voltage_max limits have > to be set. > > Signed-off-by: Badhri Jagan Sridharan <badhri@google.com> > --- > Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml > index 93a19eda610b..3a278969109e 100644 > --- a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml > +++ b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml > @@ -28,6 +28,11 @@ properties: > description: > Properties for usb c connector. > > + chg-psy-name: > + description: Power supply whose current/voltage_max values to be > + configured. > + $ref: /schemas/types.yaml#definitions/string If you want a non-vendor specific property, this needs to be documented in a common binding. I think this needs a better explaination and examples of multiple chargers. Rob
Hi Rob, Thanks for the feedback ! From the feedback that I received from the other patches in the stack, we have identified an alternate approach of doing this without introducing this device tree addition. So, for now this patch is no longer needed. While the alternate approach is still being validated, will resurface this patch if I identify any drawbacks of the alternate approach. Regards, Badhri On Wed, Mar 24, 2021 at 7:50 AM Rob Herring <robh@kernel.org> wrote: > > On Thu, Mar 11, 2021 at 02:03:13AM -0800, Badhri Jagan Sridharan wrote: > > chg-psy-name is an optional string property used to indicate the > > power supply object for which the current/voltage_max limits have > > to be set. > > > > Signed-off-by: Badhri Jagan Sridharan <badhri@google.com> > > --- > > Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml > > index 93a19eda610b..3a278969109e 100644 > > --- a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml > > +++ b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml > > @@ -28,6 +28,11 @@ properties: > > description: > > Properties for usb c connector. > > > > + chg-psy-name: > > + description: Power supply whose current/voltage_max values to be > > + configured. > > + $ref: /schemas/types.yaml#definitions/string > > If you want a non-vendor specific property, this needs to be documented > in a common binding. I think this needs a better explaination and > examples of multiple chargers. > > Rob
diff --git a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml index 93a19eda610b..3a278969109e 100644 --- a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml +++ b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml @@ -28,6 +28,11 @@ properties: description: Properties for usb c connector. + chg-psy-name: + description: Power supply whose current/voltage_max values to be + configured. + $ref: /schemas/types.yaml#definitions/string + required: - compatible - reg @@ -49,7 +54,7 @@ examples: reg = <0x25>; interrupt-parent = <&gpa8>; interrupts = <2 IRQ_TYPE_LEVEL_LOW>; - + chg-psy-name = "main_charger"; connector { compatible = "usb-c-connector"; label = "USB-C";
chg-psy-name is an optional string property used to indicate the power supply object for which the current/voltage_max limits have to be set. Signed-off-by: Badhri Jagan Sridharan <badhri@google.com> --- Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)