| Message ID | 20210225194201.17001-3-noltari@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | clk: add BCM63268 timer clock and reset | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Thu, Feb 25, 2021 at 08:41:59PM +0100, Álvaro Fernández Rojas wrote: > Add missing timer reset definitions for BCM63268. > > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> > --- > include/dt-bindings/reset/bcm63268-reset.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/dt-bindings/reset/bcm63268-reset.h b/include/dt-bindings/reset/bcm63268-reset.h > index 6a6403a4c2d5..d87a7882782a 100644 > --- a/include/dt-bindings/reset/bcm63268-reset.h > +++ b/include/dt-bindings/reset/bcm63268-reset.h > @@ -23,4 +23,8 @@ > #define BCM63268_RST_PCIE_HARD 17 > #define BCM63268_RST_GPHY 18 > > +#define BCM63268_TRST_SW 29 > +#define BCM63268_TRST_HW 30 > +#define BCM63268_TRST_POR 31 Numbering should be local to the provider, so shouldn't this be 0-2? Unless these numbers correspond to something in the h/w (bit positions for example). > + > #endif /* __DT_BINDINGS_RESET_BCM63268_H */ > -- > 2.20.1 >
Hi Rob, El 06/03/2021 a las 22:17, Rob Herring escribió: > On Thu, Feb 25, 2021 at 08:41:59PM +0100, Álvaro Fernández Rojas wrote: >> Add missing timer reset definitions for BCM63268. >> >> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> >> --- >> include/dt-bindings/reset/bcm63268-reset.h | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/include/dt-bindings/reset/bcm63268-reset.h b/include/dt-bindings/reset/bcm63268-reset.h >> index 6a6403a4c2d5..d87a7882782a 100644 >> --- a/include/dt-bindings/reset/bcm63268-reset.h >> +++ b/include/dt-bindings/reset/bcm63268-reset.h >> @@ -23,4 +23,8 @@ >> #define BCM63268_RST_PCIE_HARD 17 >> #define BCM63268_RST_GPHY 18 >> >> +#define BCM63268_TRST_SW 29 >> +#define BCM63268_TRST_HW 30 >> +#define BCM63268_TRST_POR 31 > > Numbering should be local to the provider, so shouldn't this be 0-2? > Unless these numbers correspond to something in the h/w (bit positions > for example). Numbering corresponds to bit positions in the HW: uint32 ClkRstCtl; #define POR_RESET_STATUS (1 << 31) #define HW_RESET_STATUS (1 << 30) #define SW_RESET_STATUS (1 << 29) #define USB_REF_CLKEN (1 << 18) #define UTO_EXTIN_CLKEN (1 << 17) #define UTO_CLK50_SEL (1 << 16) #define FAP2_PLL_CLKEN (1 << 15) #define FAP2_PLL_FREQ_SHIFT 12 #define FAP1_PLL_CLKEN (1 << 11) #define FAP1_PLL_FREQ_SHIFT 8 #define WAKEON_DSL (1 << 7) #define WAKEON_EPHY (1 << 6) #define DSL_ENERGY_DETECT_ENABLE (1 << 4) #define GPHY_1_ENERGY_DETECT_ENABLE (1 << 3) #define EPHY_3_ENERGY_DETECT_ENABLE (1 << 2) #define EPHY_2_ENERGY_DETECT_ENABLE (1 << 1) #define EPHY_1_ENERGY_DETECT_ENABLE (1 << 0) http://datashed.science/misc/bcm/gpl/broadcom-sdk-416L05/shared/opensource/include/bcm963xx/63268_map_part.h > >> + >> #endif /* __DT_BINDINGS_RESET_BCM63268_H */ >> -- >> 2.20.1 >> Best regards, Álvaro.
On Sun, Mar 7, 2021 at 3:08 AM Álvaro Fernández Rojas <noltari@gmail.com> wrote: > > Hi Rob, > > El 06/03/2021 a las 22:17, Rob Herring escribió: > > On Thu, Feb 25, 2021 at 08:41:59PM +0100, Álvaro Fernández Rojas wrote: > >> Add missing timer reset definitions for BCM63268. > >> > >> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> > >> --- > >> include/dt-bindings/reset/bcm63268-reset.h | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/include/dt-bindings/reset/bcm63268-reset.h b/include/dt-bindings/reset/bcm63268-reset.h > >> index 6a6403a4c2d5..d87a7882782a 100644 > >> --- a/include/dt-bindings/reset/bcm63268-reset.h > >> +++ b/include/dt-bindings/reset/bcm63268-reset.h > >> @@ -23,4 +23,8 @@ > >> #define BCM63268_RST_PCIE_HARD 17 > >> #define BCM63268_RST_GPHY 18 > >> > >> +#define BCM63268_TRST_SW 29 > >> +#define BCM63268_TRST_HW 30 > >> +#define BCM63268_TRST_POR 31 > > > > Numbering should be local to the provider, so shouldn't this be 0-2? > > Unless these numbers correspond to something in the h/w (bit positions > > for example). > > Numbering corresponds to bit positions in the HW: Okay, good. Acked-by: Rob Herring <robh@kernel.org>
diff --git a/include/dt-bindings/reset/bcm63268-reset.h b/include/dt-bindings/reset/bcm63268-reset.h index 6a6403a4c2d5..d87a7882782a 100644 --- a/include/dt-bindings/reset/bcm63268-reset.h +++ b/include/dt-bindings/reset/bcm63268-reset.h @@ -23,4 +23,8 @@ #define BCM63268_RST_PCIE_HARD 17 #define BCM63268_RST_GPHY 18 +#define BCM63268_TRST_SW 29 +#define BCM63268_TRST_HW 30 +#define BCM63268_TRST_POR 31 + #endif /* __DT_BINDINGS_RESET_BCM63268_H */
Add missing timer reset definitions for BCM63268. Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> --- include/dt-bindings/reset/bcm63268-reset.h | 4 ++++ 1 file changed, 4 insertions(+)