diff mbox series

[v3,1/4] dt-bindings: PCI: ti,j721e: Add binding to represent refclk to the connector

Message ID 20210222114030.26445-2-kishon@ti.com
State Superseded
Headers show
Series AM64: Add PCIe bindings and driver support | expand

Checks

Context Check Description
robh/dtbs-check fail build log
robh/dt-meta-schema success
robh/checkpatch success

Commit Message

Kishon Vijay Abraham I Feb. 22, 2021, 11:40 a.m. UTC
Add binding to represent refclk to the PCIe connector.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 .../devicetree/bindings/pci/ti,j721e-pci-host.yaml        | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Krzysztof Wilczyński Feb. 22, 2021, 5:29 p.m. UTC | #1
Hi Kishon,

[...]
>    clocks:
> -    maxItems: 1
> -    description: clock-specifier to represent input to the PCIe
> +    minItems: 1
> +    maxItems: 2
> +    description: clock-specifier to represent input to the PCIe for 1 item.
> +      2nd item if present represents reference clock to the connector.
[...]

I am not an expert on device trees, but what do you think of making this
description to be as follows:

  description: |+
    clock-specifier to represent input to the PCIe for 1 item.
    2nd item if present represents reference clock to the connector.

What do you think?

Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
index 0880a613ece6..50dc99ac35d9 100644
--- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
@@ -46,12 +46,16 @@  properties:
     maxItems: 1
 
   clocks:
-    maxItems: 1
-    description: clock-specifier to represent input to the PCIe
+    minItems: 1
+    maxItems: 2
+    description: clock-specifier to represent input to the PCIe for 1 item.
+      2nd item if present represents reference clock to the connector.
 
   clock-names:
+    minItems: 1
     items:
       - const: fck
+      - const: pcie_refclk
 
   vendor-id:
     const: 0x104c