| Message ID | 20210211175015.200772-7-angelogioacchino.delregno@somainline.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add support for IPA v3.1, GSI v1.0, MSM8998 IPA | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | fail | build log |
On 2/11/21 11:50 AM, AngeloGioacchino Del Regno wrote: > The driver supports SC7180, but the binding was not documented. > Just add it. I hadn't noticed that! I'm trying to get through reviewing your series today and this will take another hour or so to go validate to my satisfaction. Would you be willing to submit just this patch as a fix, and when you do I will give it a proper review? -Alex > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> > --- > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > index 8a2d12644675..b063c6c1077a 100644 > --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml > +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > @@ -43,7 +43,11 @@ description: > > properties: > compatible: > - const: "qcom,sdm845-ipa" > + oneOf: > + - items: > + - enum: > + - "qcom,sdm845-ipa" > + - "qcom,sc7180-ipa" > > reg: > items: >
On Thu, Feb 11, 2021 at 06:50:14PM +0100, AngeloGioacchino Del Regno wrote: > The driver supports SC7180, but the binding was not documented. > Just add it. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> > --- > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > index 8a2d12644675..b063c6c1077a 100644 > --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml > +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > @@ -43,7 +43,11 @@ description: > > properties: > compatible: > - const: "qcom,sdm845-ipa" > + oneOf: > + - items: > + - enum: Just enum, you don't need oneOf when only 1. And items is implied when only 1 entry. > + - "qcom,sdm845-ipa" > + - "qcom,sc7180-ipa" > > reg: > items: > -- > 2.30.0 >
On 2/11/21 11:50 AM, AngeloGioacchino Del Regno wrote: > The driver supports SC7180, but the binding was not documented. > Just add it. This has been fixed upstream now. c3264fee72e7 dt-bindings: net: qcom,ipa: add some compatible strings -Alex > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> > --- > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > index 8a2d12644675..b063c6c1077a 100644 > --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml > +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > @@ -43,7 +43,11 @@ description: > > properties: > compatible: > - const: "qcom,sdm845-ipa" > + oneOf: > + - items: > + - enum: > + - "qcom,sdm845-ipa" > + - "qcom,sc7180-ipa" > > reg: > items: >
diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml index 8a2d12644675..b063c6c1077a 100644 --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml @@ -43,7 +43,11 @@ description: properties: compatible: - const: "qcom,sdm845-ipa" + oneOf: + - items: + - enum: + - "qcom,sdm845-ipa" + - "qcom,sc7180-ipa" reg: items:
The driver supports SC7180, but the binding was not documented. Just add it. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> --- Documentation/devicetree/bindings/net/qcom,ipa.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)