| Message ID | 20210202215503.114113-1-robh@kernel.org |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v2] dt-bindings: iio: dac: Fix AD5686 references | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | success |
On 2/2/21 10:55 PM, Rob Herring wrote: > The example and filename use 'adi,ad5686', but the schema doesn't > document it. The AD5686 is also a SPI interface variant while all the > documented variants have an I2C interface. So let's update all the > references to AD5686 to AD5696. > > Cc: Lars-Peter Clausen <lars@metafoo.de> > Cc: Michael Hennerich <Michael.Hennerich@analog.com> > Cc: Jonathan Cameron <jic23@kernel.org> > Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> > Cc: Michael Auchter <michael.auchter@ni.com> > Cc: linux-iio@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> Acked-by: Lars-Peter Clausen <lars@metafoo.de> Thanks Rob. > --- > v2: > - Rename instead of adding AD5686 > > .../iio/dac/{adi,ad5686.yaml => adi,ad5696.yaml} | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > rename Documentation/devicetree/bindings/iio/dac/{adi,ad5686.yaml => adi,ad5696.yaml} (77%) > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml > similarity index 77% > rename from Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > rename to Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml > index 8065228e5df8..56b0cda0f30a 100644 > --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml > @@ -1,16 +1,16 @@ > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > %YAML 1.2 > --- > -$id: http://devicetree.org/schemas/iio/dac/adi,ad5686.yaml# > +$id: http://devicetree.org/schemas/iio/dac/adi,ad5696.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Analog Devices AD5686 and similar multi-channel DACs > +title: Analog Devices AD5696 and similar multi-channel DACs > > maintainers: > - Michael Auchter <michael.auchter@ni.com> > > description: | > - Binding for Analog Devices AD5686 and similar multi-channel DACs > + Binding for Analog Devices AD5696 and similar multi-channel DACs > > properties: > compatible: > @@ -48,8 +48,8 @@ examples: > #address-cells = <1>; > #size-cells = <0>; > > - ad5686: dac@0 { > - compatible = "adi,ad5686"; > + ad5696: dac@0 { > + compatible = "adi,ad5696"; > reg = <0>; > vcc-supply = <&dac_vref>; > };
On Tue, 2 Feb 2021 22:56:21 +0100 Lars-Peter Clausen <lars@metafoo.de> wrote: > On 2/2/21 10:55 PM, Rob Herring wrote: > > The example and filename use 'adi,ad5686', but the schema doesn't > > document it. The AD5686 is also a SPI interface variant while all the > > documented variants have an I2C interface. So let's update all the > > references to AD5686 to AD5696. > > > > Cc: Lars-Peter Clausen <lars@metafoo.de> > > Cc: Michael Hennerich <Michael.Hennerich@analog.com> > > Cc: Jonathan Cameron <jic23@kernel.org> > > Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> > > Cc: Michael Auchter <michael.auchter@ni.com> > > Cc: linux-iio@vger.kernel.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > Acked-by: Lars-Peter Clausen <lars@metafoo.de> > > Thanks Rob. > Hi Rob, So what seems to have happened here is only the i2c parts of a dual bus driver got documented. That happened as part of a series adding a new part to the driver a while back. (it's an old driver so probably only picked up dt support by accident) An alternative would be to add the docs for the rest of the parts supported by the driver - so have a unified doc for the i2c and SPI parts. Meh, it's probably simpler to just put that in as a separate doc though rather than merge it with this one. So we'll probably have an adi,ad5686.yaml file again doing that once I get round to writing one. I'm assuming you'll pick this up? Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > --- > > v2: > > - Rename instead of adding AD5686 > > > > .../iio/dac/{adi,ad5686.yaml => adi,ad5696.yaml} | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > rename Documentation/devicetree/bindings/iio/dac/{adi,ad5686.yaml => adi,ad5696.yaml} (77%) > > > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml > > similarity index 77% > > rename from Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > > rename to Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml > > index 8065228e5df8..56b0cda0f30a 100644 > > --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml > > @@ -1,16 +1,16 @@ > > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > %YAML 1.2 > > --- > > -$id: http://devicetree.org/schemas/iio/dac/adi,ad5686.yaml# > > +$id: http://devicetree.org/schemas/iio/dac/adi,ad5696.yaml# > > $schema: http://devicetree.org/meta-schemas/core.yaml# > > > > -title: Analog Devices AD5686 and similar multi-channel DACs > > +title: Analog Devices AD5696 and similar multi-channel DACs > > > > maintainers: > > - Michael Auchter <michael.auchter@ni.com> > > > > description: | > > - Binding for Analog Devices AD5686 and similar multi-channel DACs > > + Binding for Analog Devices AD5696 and similar multi-channel DACs > > > > properties: > > compatible: > > @@ -48,8 +48,8 @@ examples: > > #address-cells = <1>; > > #size-cells = <0>; > > > > - ad5686: dac@0 { > > - compatible = "adi,ad5686"; > > + ad5696: dac@0 { > > + compatible = "adi,ad5696"; > > reg = <0>; > > vcc-supply = <&dac_vref>; > > }; > >
diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml similarity index 77% rename from Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml rename to Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml index 8065228e5df8..56b0cda0f30a 100644 --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml @@ -1,16 +1,16 @@ # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 --- -$id: http://devicetree.org/schemas/iio/dac/adi,ad5686.yaml# +$id: http://devicetree.org/schemas/iio/dac/adi,ad5696.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Analog Devices AD5686 and similar multi-channel DACs +title: Analog Devices AD5696 and similar multi-channel DACs maintainers: - Michael Auchter <michael.auchter@ni.com> description: | - Binding for Analog Devices AD5686 and similar multi-channel DACs + Binding for Analog Devices AD5696 and similar multi-channel DACs properties: compatible: @@ -48,8 +48,8 @@ examples: #address-cells = <1>; #size-cells = <0>; - ad5686: dac@0 { - compatible = "adi,ad5686"; + ad5696: dac@0 { + compatible = "adi,ad5696"; reg = <0>; vcc-supply = <&dac_vref>; };
The example and filename use 'adi,ad5686', but the schema doesn't document it. The AD5686 is also a SPI interface variant while all the documented variants have an I2C interface. So let's update all the references to AD5686 to AD5696. Cc: Lars-Peter Clausen <lars@metafoo.de> Cc: Michael Hennerich <Michael.Hennerich@analog.com> Cc: Jonathan Cameron <jic23@kernel.org> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> Cc: Michael Auchter <michael.auchter@ni.com> Cc: linux-iio@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- v2: - Rename instead of adding AD5686 .../iio/dac/{adi,ad5686.yaml => adi,ad5696.yaml} | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) rename Documentation/devicetree/bindings/iio/dac/{adi,ad5686.yaml => adi,ad5696.yaml} (77%)