| Message ID | 20210120080522.471120-2-saravanak@google.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | of: property: Add fw_devlink support for more props | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 31 lines checked |
On Wed, Jan 20, 2021 at 2:05 AM Saravana Kannan <saravanak@google.com> wrote: > > To provide backward compatibility for boards that use deprecated DT > bindings, we need to add fw_devlink support for "gpio" and "gpios". > > Cc: linux-tegra <linux-tegra@vger.kernel.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") > Tested-by: Jon Hunter <jonathanh@nvidia.com> > Signed-off-by: Saravana Kannan <saravanak@google.com> > --- > drivers/of/property.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) Reviewed-by: Rob Herring <robh@kernel.org>
On Wed, Jan 20, 2021 at 12:05:20AM -0800, Saravana Kannan wrote: > To provide backward compatibility for boards that use deprecated DT > bindings, we need to add fw_devlink support for "gpio" and "gpios". > > Cc: linux-tegra <linux-tegra@vger.kernel.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") > Tested-by: Jon Hunter <jonathanh@nvidia.com> > Signed-off-by: Saravana Kannan <saravanak@google.com> > --- > drivers/of/property.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) Reviewed-by: Thierry Reding <treding@nvidia.com>
On Wed, Jan 20, 2021 at 9:05 AM Saravana Kannan <saravanak@google.com> wrote: > To provide backward compatibility for boards that use deprecated DT > bindings, we need to add fw_devlink support for "gpio" and "gpios". You do some more stuff in the patch so describe that too. Especially the check for hogs and #gpio-cells. Describe why you do that. Maybe even with a comment in the code because I don't think everyone will understand. > + if (strcmp(prop_name, "gpio") && strcmp(prop_name, "gpios")) > + return NULL; This part is easy to understand. > + if (of_find_property(np, "gpio-hog", NULL)) > + return NULL; > + > + if (of_parse_phandle_with_args(np, prop_name, "#gpio-cells", index, > + &sup_args)) > + return NULL; This part is hard to understand. Insert comments and tell the reader of the code what is going on and why. Yours, Linus Walleij
On Thu, Jan 21, 2021 at 5:11 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Wed, Jan 20, 2021 at 9:05 AM Saravana Kannan <saravanak@google.com> wrote: > > > To provide backward compatibility for boards that use deprecated DT > > bindings, we need to add fw_devlink support for "gpio" and "gpios". > > You do some more stuff in the patch so describe that too. > Especially the check for hogs and #gpio-cells. > Describe why you do that. Maybe even with a comment in > the code because I don't think everyone will understand. Ack > > > + if (strcmp(prop_name, "gpio") && strcmp(prop_name, "gpios")) > > + return NULL; > > This part is easy to understand. > > > + if (of_find_property(np, "gpio-hog", NULL)) > > + return NULL; > > + > > + if (of_parse_phandle_with_args(np, prop_name, "#gpio-cells", index, > > + &sup_args)) > > + return NULL; > > This part is hard to understand. Insert comments and tell the reader > of the code what is going on and why. I assume the "hard to understand" part is the gpio-hog part? Because the last line is pretty straightforward -- it's returning the index-th phandle. Also, it's a copy-paste from the DEFINE_SIMPLE_PROP macro. -Saravana
diff --git a/drivers/of/property.c b/drivers/of/property.c index 5f9eed79a8aa..0b256ce9d7d5 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1271,6 +1271,24 @@ static struct device_node *parse_iommu_maps(struct device_node *np, return of_parse_phandle(np, prop_name, (index * 4) + 1); } +static struct device_node *parse_gpio_compat(struct device_node *np, + const char *prop_name, int index) +{ + struct of_phandle_args sup_args; + + if (strcmp(prop_name, "gpio") && strcmp(prop_name, "gpios")) + return NULL; + + if (of_find_property(np, "gpio-hog", NULL)) + return NULL; + + if (of_parse_phandle_with_args(np, prop_name, "#gpio-cells", index, + &sup_args)) + return NULL; + + return sup_args.np; +} + static const struct supplier_bindings of_supplier_bindings[] = { { .parse_prop = parse_clocks, }, { .parse_prop = parse_interconnects, }, @@ -1296,6 +1314,7 @@ static const struct supplier_bindings of_supplier_bindings[] = { { .parse_prop = parse_pinctrl6, }, { .parse_prop = parse_pinctrl7, }, { .parse_prop = parse_pinctrl8, }, + { .parse_prop = parse_gpio_compat, }, { .parse_prop = parse_regulators, }, { .parse_prop = parse_gpio, }, { .parse_prop = parse_gpios, },
To provide backward compatibility for boards that use deprecated DT bindings, we need to add fw_devlink support for "gpio" and "gpios". Cc: linux-tegra <linux-tegra@vger.kernel.org> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Tested-by: Jon Hunter <jonathanh@nvidia.com> Signed-off-by: Saravana Kannan <saravanak@google.com> --- drivers/of/property.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)