| Message ID | 20210116090656.11752-4-chunfeng.yun@mediatek.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [next,01/15] dt-bindings: usb: fix yamllint check warning | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
Hi, Chunfeng: Chunfeng Yun <chunfeng.yun@mediatek.com> 於 2021年1月16日 週六 下午5:07寫道： > > The compatilbe "mediatek,mt7623-hdmi-tx" is not supported in driver, > and in fact uses "mediatek,mt2701-hdmi-tx" instead on MT7623, so changes > the compatible items to make dependence clear. > > Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > .../devicetree/bindings/phy/mediatek,hdmi-phy.yaml | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml > index 4752517a1446..0d94950b84ca 100644 > --- a/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml > @@ -21,10 +21,13 @@ properties: > pattern: "^hdmi-phy@[0-9a-f]+$" > > compatible: > - enum: > - - mediatek,mt2701-hdmi-phy > - - mediatek,mt7623-hdmi-phy > - - mediatek,mt8173-hdmi-phy > + oneOf: > + - items: > + - enum: > + - mediatek,mt7623-hdmi-phy > + - const: mediatek,mt2701-hdmi-phy > + - const: mediatek,mt2701-hdmi-phy > + - const: mediatek,mt8173-hdmi-phy > I like move 'items' to the bottom. - const: mediatek,mt2701-hdmi-phy - const: mediatek,mt8173-hdmi-phy - items: - enum: - mediatek,mt7623-hdmi-phy - const: mediatek,mt2701-hdmi-phy Regards, Chun-Kuang. > reg: > maxItems: 1 > -- > 2.18.0
On Mon, 2021-01-18 at 23:05 +0800, Chun-Kuang Hu wrote: > Hi, Chunfeng: > > Chunfeng Yun <chunfeng.yun@mediatek.com> 於 2021年1月16日 週六 下午5:07寫道： > > > > The compatilbe "mediatek,mt7623-hdmi-tx" is not supported in driver, > > and in fact uses "mediatek,mt2701-hdmi-tx" instead on MT7623, so changes > > the compatible items to make dependence clear. > > > > Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org> > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > > --- > > .../devicetree/bindings/phy/mediatek,hdmi-phy.yaml | 11 +++++++---- > > 1 file changed, 7 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml > > index 4752517a1446..0d94950b84ca 100644 > > --- a/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml > > @@ -21,10 +21,13 @@ properties: > > pattern: "^hdmi-phy@[0-9a-f]+$" > > > > compatible: > > - enum: > > - - mediatek,mt2701-hdmi-phy > > - - mediatek,mt7623-hdmi-phy > > - - mediatek,mt8173-hdmi-phy > > + oneOf: > > + - items: > > + - enum: > > + - mediatek,mt7623-hdmi-phy > > + - const: mediatek,mt2701-hdmi-phy > > + - const: mediatek,mt2701-hdmi-phy > > + - const: mediatek,mt8173-hdmi-phy > > > > I like move 'items' to the bottom. I follow the same style as other bindings > > - const: mediatek,mt2701-hdmi-phy > - const: mediatek,mt8173-hdmi-phy > > - items: > - enum: > - mediatek,mt7623-hdmi-phy > - const: mediatek,mt2701-hdmi-phy > > Regards, > Chun-Kuang. > > > reg: > > maxItems: 1 > > -- > > 2.18.0
diff --git a/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml index 4752517a1446..0d94950b84ca 100644 --- a/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml +++ b/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml @@ -21,10 +21,13 @@ properties: pattern: "^hdmi-phy@[0-9a-f]+$" compatible: - enum: - - mediatek,mt2701-hdmi-phy - - mediatek,mt7623-hdmi-phy - - mediatek,mt8173-hdmi-phy + oneOf: + - items: + - enum: + - mediatek,mt7623-hdmi-phy + - const: mediatek,mt2701-hdmi-phy + - const: mediatek,mt2701-hdmi-phy + - const: mediatek,mt8173-hdmi-phy reg: maxItems: 1
The compatilbe "mediatek,mt7623-hdmi-tx" is not supported in driver, and in fact uses "mediatek,mt2701-hdmi-tx" instead on MT7623, so changes the compatible items to make dependence clear. Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org> Cc: Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- .../devicetree/bindings/phy/mediatek,hdmi-phy.yaml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)