| Message ID | 20210112192831.686-3-elder@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | net: ipa: remove a build dependency | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Tue, 12 Jan 2021 13:28:29 -0600, Alex Elder wrote: > The IPA driver uses the remoteproc SSR notifier now, rather than the > temporary IPA notification system used initially. As a result it no > longer needs a property identifying the modem subsystem DT node. > > Use GIC_SPI rather than 0 in the example interrupt definition. > > Signed-off-by: Alex Elder <elder@linaro.org> > --- > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/net/qcom,ipa.example.dts:49.46-47 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:344: Documentation/devicetree/bindings/net/qcom,ipa.example.dt.yaml] Error 1 make: *** [Makefile:1370: dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1425462 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Tue, Jan 12, 2021 at 01:28:29PM -0600, Alex Elder wrote: > The IPA driver uses the remoteproc SSR notifier now, rather than the > temporary IPA notification system used initially. As a result it no > longer needs a property identifying the modem subsystem DT node. > > Use GIC_SPI rather than 0 in the example interrupt definition. > > Signed-off-by: Alex Elder <elder@linaro.org> > --- > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > index 8a2d12644675b..a8cff214ee11f 100644 > --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml > +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > @@ -113,13 +113,6 @@ properties: > performing early IPA initialization, including loading and > validating firwmare used by the GSI. > > - modem-remoteproc: > - $ref: /schemas/types.yaml#/definitions/phandle > - description: > - This defines the phandle to the remoteproc node representing > - the modem subsystem. This is requied so the IPA driver can > - receive and act on notifications of modem up/down events. > - > memory-region: > maxItems: 1 > description: > @@ -135,7 +128,6 @@ required: > - interrupts > - interconnects > - qcom,smem-states > - - modem-remoteproc > > oneOf: > - required: > @@ -168,7 +160,6 @@ examples: > compatible = "qcom,sdm845-ipa"; > > modem-init; > - modem-remoteproc = <&mss_pil>; > > iommus = <&apps_smmu 0x720 0x3>; > reg = <0x1e40000 0x7000>, > @@ -178,8 +169,8 @@ examples: > "ipa-shared", > "gsi"; > > - interrupts-extended = <&intc 0 311 IRQ_TYPE_EDGE_RISING>, > - <&intc 0 432 IRQ_TYPE_LEVEL_HIGH>, > + interrupts-extended = <&intc GIC_SPI 311 IRQ_TYPE_EDGE_RISING>, > + <&intc GIC_SPI 432 IRQ_TYPE_LEVEL_HIGH>, You need the include file. > <&ipa_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, > <&ipa_smp2p_in 1 IRQ_TYPE_EDGE_RISING>; > interrupt-names = "ipa", > -- > 2.20.1 >
diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml index 8a2d12644675b..a8cff214ee11f 100644 --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml @@ -113,13 +113,6 @@ properties: performing early IPA initialization, including loading and validating firwmare used by the GSI. - modem-remoteproc: - $ref: /schemas/types.yaml#/definitions/phandle - description: - This defines the phandle to the remoteproc node representing - the modem subsystem. This is requied so the IPA driver can - receive and act on notifications of modem up/down events. - memory-region: maxItems: 1 description: @@ -135,7 +128,6 @@ required: - interrupts - interconnects - qcom,smem-states - - modem-remoteproc oneOf: - required: @@ -168,7 +160,6 @@ examples: compatible = "qcom,sdm845-ipa"; modem-init; - modem-remoteproc = <&mss_pil>; iommus = <&apps_smmu 0x720 0x3>; reg = <0x1e40000 0x7000>, @@ -178,8 +169,8 @@ examples: "ipa-shared", "gsi"; - interrupts-extended = <&intc 0 311 IRQ_TYPE_EDGE_RISING>, - <&intc 0 432 IRQ_TYPE_LEVEL_HIGH>, + interrupts-extended = <&intc GIC_SPI 311 IRQ_TYPE_EDGE_RISING>, + <&intc GIC_SPI 432 IRQ_TYPE_LEVEL_HIGH>, <&ipa_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, <&ipa_smp2p_in 1 IRQ_TYPE_EDGE_RISING>; interrupt-names = "ipa",
The IPA driver uses the remoteproc SSR notifier now, rather than the temporary IPA notification system used initially. As a result it no longer needs a property identifying the modem subsystem DT node. Use GIC_SPI rather than 0 in the example interrupt definition. Signed-off-by: Alex Elder <elder@linaro.org> --- Documentation/devicetree/bindings/net/qcom,ipa.yaml | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-)