diff mbox series

[v3,3/6] regulator: dt-bindings: pf8x00: remove nxp,ilim-ma property

Message ID 20210108225006.153700-4-adrien.grassein@gmail.com
State Not Applicable, archived
Headers show
Series Fix issues on pf8x00 driver | expand

Checks

Context Check Description
robh/checkpatch success
robh/checkpatch success

Commit Message

Adrien Grassein Jan. 8, 2021, 10:50 p.m. UTC 
This property seems useless because we can use the
regulator-max-microamp generic property to do the same
and using generic code.

The only things it changes is the default value. The original
code was using "2100" (mA) as default one, but I think we should
keep the value in the OTP memory as the default one. This value
is automatically loaded in the register by the chip.

Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 .../bindings/regulator/nxp,pf8x00-regulator.yaml    | 13 -------------
 1 file changed, 13 deletions(-)

Comments

Mark Brown Jan. 11, 2021, 5:20 p.m. UTC | #1 
On Fri, Jan 08, 2021 at 11:50:03PM +0100, Adrien Grassein wrote:
> This property seems useless because we can use the
> regulator-max-microamp generic property to do the same
> and using generic code.

This made it into a kernel release so we should continue to honour it,
it's fine to deprecate it though.
Adrien Grassein Jan. 11, 2021, 5:27 p.m. UTC | #2 
Hello,

Is there a way to declare it deprecated in the DTB ?
I never saw a deprecated value.

Thanks,

Le lun. 11 janv. 2021 à 18:20, Mark Brown <broonie@kernel.org> a écrit :
>
> On Fri, Jan 08, 2021 at 11:50:03PM +0100, Adrien Grassein wrote:
> > This property seems useless because we can use the
> > regulator-max-microamp generic property to do the same
> > and using generic code.
>
> This made it into a kernel release so we should continue to honour it,
> it's fine to deprecate it though.
Mark Brown Jan. 11, 2021, 5:32 p.m. UTC | #3 
On Mon, Jan 11, 2021 at 06:27:52PM +0100, Adrien Grassein wrote:
> Hello,

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

> Is there a way to declare it deprecated in the DTB ?
> I never saw a deprecated value.

If nothing else you can put a note in the text description, I don't know
about the YAML format stuff.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml
index 095cfdae7b67..05d5e9a2219c 100644
--- a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml
@@ -58,19 +58,6 @@  properties:
             description:
               should be "buck1", ..., "buck7"
 
-          nxp,ilim-ma:
-            $ref: "/schemas/types.yaml#/definitions/uint32"
-            minimum: 2100
-            maximum: 4500
-            description:
-              BUCK regulators current limit in mA.
-
-              Listed current limits in mA are,
-              2100 (default)
-              2600
-              3000
-              4500
-
           nxp,phase-shift:
             $ref: "/schemas/types.yaml#/definitions/uint32"
             default: 0