Message ID | 20210108212600.36850-20-mgross@linux.intel.com |
---|---|
State | Changes Requested, archived |
Headers | show |
Series | None | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success | |
robh/dt-meta-schema | fail | build log |
robh/checkpatch | success | |
robh/dt-meta-schema | fail | build log |
On Fri, 08 Jan 2021 13:25:45 -0800, mgross@linux.intel.com wrote: > From: Seamus Kelly <seamus.kelly@intel.com> > > Add device tree bindings for keembay-xlink. > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: devicetree@vger.kernel.org > Reviewed-by: Mark Gross <mgross@linux.intel.com> > Signed-off-by: Seamus Kelly <seamus.kelly@intel.com> > Signed-off-by: Ryan Carnaghi <ryan.r.carnaghi@intel.com> > --- > .../bindings/misc/intel,keembay-xlink.yaml | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml:21:9: [warning] wrong indentation: expected 10 but found 8 (indentation) dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml: 'additionalProperties' is a required property /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml: ignoring, error in schema: warning: no schema found in file: ./Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml See https://patchwork.ozlabs.org/patch/1423961 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Fri, Jan 08, 2021 at 01:25:45PM -0800, mgross@linux.intel.com wrote: > From: Seamus Kelly <seamus.kelly@intel.com> > > Add device tree bindings for keembay-xlink. > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: devicetree@vger.kernel.org > Reviewed-by: Mark Gross <mgross@linux.intel.com> > Signed-off-by: Seamus Kelly <seamus.kelly@intel.com> > Signed-off-by: Ryan Carnaghi <ryan.r.carnaghi@intel.com> > --- > .../bindings/misc/intel,keembay-xlink.yaml | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml > > diff --git a/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml b/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml > new file mode 100644 > index 000000000000..89c34018fa04 > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml > @@ -0,0 +1,27 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright (c) Intel Corporation. All rights reserved. > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/misc/intel,keembay-xlink.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Intel Keem Bay xlink > + > +maintainers: > + - Seamus Kelly <seamus.kelly@intel.com> > + > +description: | > + The Keem Bay xlink driver enables the communication/control sub-system > + for internal and external communications to the Intel Keem Bay SoC. > + > +properties: > + compatible: > + oneOf: > + - items: > + - const: intel,keembay-xlink > + > +examples: > + - | > + xlink { > + compatible = "intel,keembay-xlink"; > + }; A node with a compatible and nothing else is generally a sign of abusing DT to instantiate a driver. You don't need DT for that. Rob
diff --git a/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml b/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml new file mode 100644 index 000000000000..89c34018fa04 --- /dev/null +++ b/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml @@ -0,0 +1,27 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright (c) Intel Corporation. All rights reserved. +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/misc/intel,keembay-xlink.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Intel Keem Bay xlink + +maintainers: + - Seamus Kelly <seamus.kelly@intel.com> + +description: | + The Keem Bay xlink driver enables the communication/control sub-system + for internal and external communications to the Intel Keem Bay SoC. + +properties: + compatible: + oneOf: + - items: + - const: intel,keembay-xlink + +examples: + - | + xlink { + compatible = "intel,keembay-xlink"; + };