diff mbox series

[v2,1/2] dt-bindings: pwm: allwinner: Add V3s compatible description

Message ID 20201218205436.2326872-1-contact@paulk.fr
State Not Applicable, archived
Headers show
Series [v2,1/2] dt-bindings: pwm: allwinner: Add V3s compatible description | expand

Checks

Context Check Description
robh/checkpatch success
robh/dt-meta-schema success
robh/dtbs-check success

Commit Message

Paul Kocialkowski Dec. 18, 2020, 8:54 p.m. UTC
Introduce bindings description for the V3s PWM, which is
register-compatible with the A20 PWM.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
 .../devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml       | 3 +++
 1 file changed, 3 insertions(+)

Comments

Jernej Škrabec Dec. 22, 2020, 8:21 a.m. UTC | #1
Hi!

Dne petek, 18. december 2020 ob 21:54:35 CET je Paul Kocialkowski napisal(a):
> Introduce bindings description for the V3s PWM, which is
> register-compatible with the A20 PWM.
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>

This is meant to be used together with V3s PWM patch you recently send? Can 
you please resend them together, with fixed compatible in DT node? Currently 
it's not clear why this patch is needed and PWM patch will need fix anyway.

Best regards,
Jernej

> ---
>  .../devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml       | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git
> a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
> b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml index
> 7dcab2bf8128..04ff708fdc86 100644
> --- a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
> @@ -24,6 +24,9 @@ properties:
>        - items:
>            - const: allwinner,sun8i-a83t-pwm
>            - const: allwinner,sun8i-h3-pwm
> +      - items:
> +          - const: allwinner,sun8i-v3s-pwm
> +          - const: allwinner,sun7i-a20-pwm
>        - items:
>            - const: allwinner,sun50i-a64-pwm
>            - const: allwinner,sun5i-a13-pwm
Paul Kocialkowski Dec. 24, 2020, 9:23 a.m. UTC | #2
Hi,

Le Tue 22 Dec 20, 09:21, Jernej Škrabec a écrit :
> Dne petek, 18. december 2020 ob 21:54:35 CET je Paul Kocialkowski napisal(a):
> > Introduce bindings description for the V3s PWM, which is
> > register-compatible with the A20 PWM.
> > 
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> 
> This is meant to be used together with V3s PWM patch you recently send? Can 
> you please resend them together, with fixed compatible in DT node? Currently 
> it's not clear why this patch is needed and PWM patch will need fix anyway.

I've sent them together (this one is v2 1/2 and 2/2 is the PWM dt patch).

You can grab it at: https://lore.kernel.org/patchwork/patch/1355289/
if it didn't reach your emails.

Cheers,

Paul

> > ---
> >  .../devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml       | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
> > b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml index
> > 7dcab2bf8128..04ff708fdc86 100644
> > --- a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
> > +++ b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
> > @@ -24,6 +24,9 @@ properties:
> >        - items:
> >            - const: allwinner,sun8i-a83t-pwm
> >            - const: allwinner,sun8i-h3-pwm
> > +      - items:
> > +          - const: allwinner,sun8i-v3s-pwm
> > +          - const: allwinner,sun7i-a20-pwm
> >        - items:
> >            - const: allwinner,sun50i-a64-pwm
> >            - const: allwinner,sun5i-a13-pwm
> 
> 
> 
>
Rob Herring (Arm) Dec. 31, 2020, 8:45 p.m. UTC | #3
On Fri, 18 Dec 2020 21:54:35 +0100, Paul Kocialkowski wrote:
> Introduce bindings description for the V3s PWM, which is
> register-compatible with the A20 PWM.
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
>  .../devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml       | 3 +++
>  1 file changed, 3 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
index 7dcab2bf8128..04ff708fdc86 100644
--- a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
@@ -24,6 +24,9 @@  properties:
       - items:
           - const: allwinner,sun8i-a83t-pwm
           - const: allwinner,sun8i-h3-pwm
+      - items:
+          - const: allwinner,sun8i-v3s-pwm
+          - const: allwinner,sun7i-a20-pwm
       - items:
           - const: allwinner,sun50i-a64-pwm
           - const: allwinner,sun5i-a13-pwm