diff mbox series

[1/2] dt-bindings: arm: qcom: Document SDX55 Modem and boards

Message ID 20201124140011.134751-2-manivannan.sadhasivam@linaro.org
State Changes Requested
Headers show
Series [1/2] dt-bindings: arm: qcom: Document SDX55 Modem and boards | expand

Checks

Context Check Description
robh/checkpatch success

Commit Message

Manivannan Sadhasivam Nov. 24, 2020, 2 p.m. UTC
From: Vinod Koul <vkoul@kernel.org>

Document the SDX55 Modem binding and also the boards using it.

Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Bjorn Andersson Nov. 24, 2020, 2:57 p.m. UTC | #1
On Tue 24 Nov 08:00 CST 2020, Manivannan Sadhasivam wrote:

> From: Vinod Koul <vkoul@kernel.org>
> 
> Document the SDX55 Modem binding and also the boards using it.

It's not really the "SDX55 Modem", it's the "SDX55 platform". That way
things become less confusing when we actually add the modem on SDX55
later.

> 
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index ad25deba4d86..4362e8f0d495 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -39,6 +39,7 @@ description: |
>          sc7180
>          sdm630
>          sdm660
> +        sdx55

'x' > 'm', so this should go one line down.

Regards,
Bjorn

>          sdm845
>          sm8250
>  
> @@ -178,4 +179,9 @@ properties:
>                - qcom,sm8250-mtp
>            - const: qcom,sm8250
>  
> +      - items:
> +          - enum:
> +              - qcom,sdx55-mtp
> +          - const: qcom,sdx55
> +
>  ...
> -- 
> 2.25.1
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index ad25deba4d86..4362e8f0d495 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -39,6 +39,7 @@  description: |
         sc7180
         sdm630
         sdm660
+        sdx55
         sdm845
         sm8250
 
@@ -178,4 +179,9 @@  properties:
               - qcom,sm8250-mtp
           - const: qcom,sm8250
 
+      - items:
+          - enum:
+              - qcom,sdx55-mtp
+          - const: qcom,sdx55
+
 ...