| Message ID | 20201120142803.308-2-martinax.krasteva@linux.intel.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/2] dt-bindings: media: Add bindings for imx334 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 72 lines checked |
| robh/dt-meta-schema | fail | build log |
On Fri, 20 Nov 2020 14:28:02 +0000, Martina Krasteva wrote: > From: Martina Krasteva <martinax.krasteva@intel.com> > > - Add dt-bindings documentation for Sony imx334 sensor driver. > - Add MAINTAINERS entry for Sony imx334 binding documentation. > > Signed-off-by: Martina Krasteva <martinax.krasteva@intel.com> > Reviewed-by: Gjorgji Rosikopulos <gjorgjix.rosikopulos@intel.com> > Acked-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com> > --- > .../devicetree/bindings/media/i2c/sony,imx334.yaml | 59 ++++++++++++++++++++++ > MAINTAINERS | 7 +++ > 2 files changed, 66 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml:34:15: [warning] wrong indentation: expected 12 but found 14 (indentation) ./Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml:36:15: [warning] wrong indentation: expected 12 but found 14 (indentation) dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml: 'additionalProperties' is a required property /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml: ignoring, error in schema: warning: no schema found in file: ./Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml See https://patchwork.ozlabs.org/patch/1403740 The base for the patch is generally the last rc1. Any dependencies should be noted. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Hi Rob, > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: Friday, November 20, 2020 8:59 PM > To: Martina Krasteva <martinax.krasteva@linux.intel.com> > Cc: linux-media@vger.kernel.org; robh+dt@kernel.org; mchehab@kernel.org; > devicetree@vger.kernel.org; daniele.alessandrelli@linux.intel.com; > gjorgjix.rosikopulos@linux.intel.com; sakari.ailus@linux.intel.com > Subject: Re: [PATCH 1/2] dt-bindings: media: Add bindings for imx334 > > On Fri, 20 Nov 2020 14:28:02 +0000, Martina Krasteva wrote: > > From: Martina Krasteva <martinax.krasteva@intel.com> > > > > - Add dt-bindings documentation for Sony imx334 sensor driver. > > - Add MAINTAINERS entry for Sony imx334 binding documentation. > > > > Signed-off-by: Martina Krasteva <martinax.krasteva@intel.com> > > Reviewed-by: Gjorgji Rosikopulos <gjorgjix.rosikopulos@intel.com> > > Acked-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com> > > --- > > .../devicetree/bindings/media/i2c/sony,imx334.yaml | 59 > ++++++++++++++++++++++ > > MAINTAINERS | 7 +++ > > 2 files changed, 66 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml:34:15: > [warning] wrong indentation: expected 12 but found 14 (indentation) > ./Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml:36:15: > [warning] wrong indentation: expected 12 but found 14 (indentation) > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml: > 'additionalProperties' is a required property > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml: > ignoring, error in schema: > warning: no schema found in file: > ./Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > > > See https://patchwork.ozlabs.org/patch/1403740 > > The base for the patch is generally the last rc1. Any dependencies should be > noted. > > If you already ran 'make dt_binding_check' and didn't see the above error(s), > then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. Thank you, I will fix these warnings in the next version Best Regards, Martina
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml new file mode 100644 index 000000000000..ff6385cd6e9e --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml @@ -0,0 +1,59 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) 2020 Intel Corporation +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/sony,imx334.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sony IMX334 Sensor + +maintainers: + - Daniele Alessandrelli <daniele.alessandrelli@intel.com> + +description: + IMX334 sensor is a Sony CMOS active pixel digital image sensor with an active + array size of 3864H x 2202V. It is programmable through I2C interface. The + I2C client address is fixed to 0x1a as per sensor data sheet. Image data is + sent through MIPI CSI-2. + +properties: + compatible: + const: sony,imx334 + reg: + description: I2C address + maxItems: 1 + + # See ../video-interfaces.txt for more details + port: + type: object + properties: + endpoint: + type: object + properties: + remote-endpoint: + description: See ../video-interfaces.txt + data-lanes: + description: See ../video-interfaces.txt + +required: + - compatible + - port + +examples: + - | + i2c0 { + #address-cells = <1>; + #size-cells = <0>; + + camera@1a { + compatible = "sony,imx334"; + reg = <0x1a>; + + port { + imx334: endpoint { + remote-endpoint = <&cam>; + data-lanes = <1 2 3 4>; + }; + }; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index e451dcce054f..6cfce99be4bb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -16320,6 +16320,13 @@ S: Maintained T: git git://linuxtv.org/media_tree.git F: drivers/media/i2c/imx319.c +SONY IMX334 SENSOR DRIVER +M: Daniele Alessandrelli <daniele.alessandrelli@intel.com> +L: linux-media@vger.kernel.org +S: Maintained +T: git git://linuxtv.org/media_tree.git +F: Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml + SONY IMX355 SENSOR DRIVER M: Tianshu Qiu <tian.shu.qiu@intel.com> L: linux-media@vger.kernel.org