diff mbox series

[3/3] dt-bindings: mailbox: mu: add imx8qm support

Message ID 20201119125304.1279-3-aisheng.dong@nxp.com
State Superseded
Headers show
Series [1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string | expand

Checks

Context Check Description
robh/dt-meta-schema success
robh/checkpatch success

Commit Message

Dong Aisheng Nov. 19, 2020, 12:53 p.m. UTC
Add imx8qm support

Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
 Documentation/devicetree/bindings/mailbox/fsl,mu.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Nov. 19, 2020, 1:23 p.m. UTC | #1
On Thu, Nov 19, 2020 at 08:53:04PM +0800, Dong Aisheng wrote:
> Add imx8qm support
> 
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
>  Documentation/devicetree/bindings/mailbox/fsl,mu.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> index 15cef82cd356..1a3dff277e2b 100644
> --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> @@ -34,12 +34,15 @@ properties:
>                - fsl,imx8mm-mu
>                - fsl,imx8mn-mu
>                - fsl,imx8mp-mu
> +              - fsl,imx8qm-mu

You add the compatible below, so decide which one is it. Please provide
also users of this compatible - DTS.

Best regards,
Krzysztof

>                - fsl,imx8qxp-mu
>            - const: fsl,imx6sx-mu
>        - description: To communicate with i.MX8 SCU with fast IPC
>          items:
>            - const: fsl,imx8-mu-scu
> -          - const: fsl,imx8qxp-mu
> +          - enum:
> +              - fsl,imx8qm-mu
> +              - fsl,imx8qxp-mu
>            - const: fsl,imx6sx-mu
>  
>    reg:
> -- 
> 2.23.0
>
Dong Aisheng Nov. 19, 2020, 3:24 p.m. UTC | #2
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Thursday, November 19, 2020 9:23 PM
> 
> On Thu, Nov 19, 2020 at 08:53:04PM +0800, Dong Aisheng wrote:
> > Add imx8qm support
> >
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: devicetree@vger.kernel.org
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/mailbox/fsl,mu.yaml | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > index 15cef82cd356..1a3dff277e2b 100644
> > --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > @@ -34,12 +34,15 @@ properties:
> >                - fsl,imx8mm-mu
> >                - fsl,imx8mn-mu
> >                - fsl,imx8mp-mu
> > +              - fsl,imx8qm-mu
> 
> You add the compatible below, so decide which one is it. Please provide also
> users of this compatible - DTS.

There're two SCU MU protocol bindings, both can be used, just like exist fsl,imx8qxp-mu.

Regards
Aisheng

Both can be used, depends on which proto
> 
> Best regards,
> Krzysztof
> 
> >                - fsl,imx8qxp-mu
> >            - const: fsl,imx6sx-mu
> >        - description: To communicate with i.MX8 SCU with fast IPC
> >          items:
> >            - const: fsl,imx8-mu-scu
> > -          - const: fsl,imx8qxp-mu
> > +          - enum:
> > +              - fsl,imx8qm-mu
> > +              - fsl,imx8qxp-mu
> >            - const: fsl,imx6sx-mu
> >
> >    reg:
> > --
> > 2.23.0
> >
Krzysztof Kozlowski Nov. 19, 2020, 3:27 p.m. UTC | #3
On Thu, Nov 19, 2020 at 03:24:21PM +0000, Aisheng Dong wrote:
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > Sent: Thursday, November 19, 2020 9:23 PM
> > 
> > On Thu, Nov 19, 2020 at 08:53:04PM +0800, Dong Aisheng wrote:
> > > Add imx8qm support
> > >
> > > Cc: Rob Herring <robh+dt@kernel.org>
> > > Cc: devicetree@vger.kernel.org
> > > Cc: Shawn Guo <shawnguo@kernel.org>
> > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > > ---
> > >  Documentation/devicetree/bindings/mailbox/fsl,mu.yaml | 5 ++++-
> > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > > b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > > index 15cef82cd356..1a3dff277e2b 100644
> > > --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > > +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > > @@ -34,12 +34,15 @@ properties:
> > >                - fsl,imx8mm-mu
> > >                - fsl,imx8mn-mu
> > >                - fsl,imx8mp-mu
> > > +              - fsl,imx8qm-mu
> > 
> > You add the compatible below, so decide which one is it. Please provide also
> > users of this compatible - DTS.
> 
> There're two SCU MU protocol bindings, both can be used, just like exist fsl,imx8qxp-mu.

Makes sense. Still please send the bindings as first patch in series
implementing them. Upstream also the DTS with the bindings - the best in
the same series.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
index 15cef82cd356..1a3dff277e2b 100644
--- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
+++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
@@ -34,12 +34,15 @@  properties:
               - fsl,imx8mm-mu
               - fsl,imx8mn-mu
               - fsl,imx8mp-mu
+              - fsl,imx8qm-mu
               - fsl,imx8qxp-mu
           - const: fsl,imx6sx-mu
       - description: To communicate with i.MX8 SCU with fast IPC
         items:
           - const: fsl,imx8-mu-scu
-          - const: fsl,imx8qxp-mu
+          - enum:
+              - fsl,imx8qm-mu
+              - fsl,imx8qxp-mu
           - const: fsl,imx6sx-mu
 
   reg: