diff mbox series

[3/3] dt-bindings: Update Synopsis DW apb ssi bindings

Message ID 20201119120253.390883-4-damien.lemoal@wdc.com
State Needs Review / ACK
Headers show
Series DW apb_ssi V4 support for Kendryte K210 RISC-V SoC | expand

Checks

Context Check Description
robh/dt-meta-schema success
robh/checkpatch success

Commit Message

Damien Le Moal Nov. 19, 2020, 12:02 p.m. UTC
Update the snps,dw-apb-ssi.yaml document to include the compatibility
string "canaan,k210-spi" compatible string for the Canaan Kendryte K210
RISC-V SoC DW apb_ssi V4 SPI controller.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
---
 Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Serge Semin Nov. 25, 2020, 12:50 p.m. UTC | #1
Hello Damien,

> [PATCH 3/3] dt-bindings: Update Synopsis DW apb ssi bindings

The patch subject is too uncertain. There is no subsystem name and
what is added to the bindings. I'd suggest something like:
"dt-bindings: spi: dw-apb-ssi: Add Canaan K210 SPI controller"

Then feel free to add
Acked-by: Serge Semin <fancer.lancer@gmail.com>

-Sergey

On Thu, Nov 19, 2020 at 09:02:53PM +0900, Damien Le Moal wrote:
> Update the snps,dw-apb-ssi.yaml document to include the compatibility
> string "canaan,k210-spi" compatible string for the Canaan Kendryte K210
> RISC-V SoC DW apb_ssi V4 SPI controller.
> 
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
>  Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> index 99ed9b416e94..4825157cd92e 100644
> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> @@ -65,6 +65,8 @@ properties:
>          const: baikal,bt1-ssi
>        - description: Baikal-T1 System Boot SPI Controller
>          const: baikal,bt1-sys-ssi
> +      - description: Canaan Kendryte K210 SoS SPI Controller
> +        const: canaan,k210-spi
>  
>    reg:
>      minItems: 1
> -- 
> 2.28.0
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
index 99ed9b416e94..4825157cd92e 100644
--- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
+++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
@@ -65,6 +65,8 @@  properties:
         const: baikal,bt1-ssi
       - description: Baikal-T1 System Boot SPI Controller
         const: baikal,bt1-sys-ssi
+      - description: Canaan Kendryte K210 SoS SPI Controller
+        const: canaan,k210-spi
 
   reg:
     minItems: 1