diff mbox series

[2/3] of: property: add debug info for supplier devices still unavailable

Message ID 20201119110036.19959-2-aisheng.dong@nxp.com
State Needs Review / ACK
Headers show
Series None | expand

Checks

Context Check Description
robh/checkpatch success

Commit Message

Aisheng Dong Nov. 19, 2020, 11 a.m. UTC
It's normal that supplier devices may still unavaiable when parse DT to
create dependency. e.g. supplier devices populated by drivers.
Add debug info for this case.

Cc: devicetree@vger.kernel.org
Cc: Saravana Kannan <saravanak@google.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
 drivers/of/property.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Saravana Kannan Nov. 19, 2020, 5:48 p.m. UTC | #1
On Thu, Nov 19, 2020 at 3:18 AM Dong Aisheng <aisheng.dong@nxp.com> wrote:
>
> It's normal that supplier devices may still unavaiable when parse DT to
> create dependency. e.g. supplier devices populated by drivers.
> Add debug info for this case.
>
> Cc: devicetree@vger.kernel.org
> Cc: Saravana Kannan <saravanak@google.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
>  drivers/of/property.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/of/property.c b/drivers/of/property.c
> index 408a7b5f06a9..21a854e85234 100644
> --- a/drivers/of/property.c
> +++ b/drivers/of/property.c
> @@ -1150,6 +1150,8 @@ static int of_link_to_phandle(struct device *dev, struct device_node *sup_np,
>                          * Can't check for cycles or no cycles. So let's try
>                          * again later.
>                          */
> +                       dev_dbg(dev, "Not linking to %pOFP - device may still unavailable\n",
> +                               sup_np);
>                         ret = -EAGAIN;
>                 }
>

All of this is going away[1].
So, Nack.

-Saravana
[1] - https://lore.kernel.org/lkml/20201104232356.4038506-1-saravanak@google.com/
diff mbox series

Patch

diff --git a/drivers/of/property.c b/drivers/of/property.c
index 408a7b5f06a9..21a854e85234 100644
--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -1150,6 +1150,8 @@  static int of_link_to_phandle(struct device *dev, struct device_node *sup_np,
 			 * Can't check for cycles or no cycles. So let's try
 			 * again later.
 			 */
+			dev_dbg(dev, "Not linking to %pOFP - device may still unavailable\n",
+				sup_np);
 			ret = -EAGAIN;
 		}