diff mbox series

dt-bindings: pwm: pca9685: Add staggered-outputs property

Message ID 20201118174515.278067-1-clemens.gruber@pqgruber.com
State Superseded
Headers show
Series dt-bindings: pwm: pca9685: Add staggered-outputs property | expand

Checks

Context Check Description
robh/checkpatch success

Commit Message

Clemens Gruber Nov. 18, 2020, 5:45 p.m. UTC
The pca9685 driver supports a new staggered-outputs property for reduced
current surges and EMI. This adds documentation for the new DT property.

Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
---
 Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt | 2 ++
 1 file changed, 2 insertions(+)

Comments

Uwe Kleine-König Nov. 20, 2020, 8:21 a.m. UTC | #1
On Wed, Nov 18, 2020 at 06:45:15PM +0100, Clemens Gruber wrote:
> The pca9685 driver supports a new staggered-outputs property for reduced
> current surges and EMI. This adds documentation for the new DT property.

Maybe point out the commit that added this support here?

Best regards
Uwe
Clemens Gruber Nov. 20, 2020, 12:36 p.m. UTC | #2
Hi,

On Fri, Nov 20, 2020 at 09:21:50AM +0100, Uwe Kleine-König wrote:
> On Wed, Nov 18, 2020 at 06:45:15PM +0100, Clemens Gruber wrote:
> > The pca9685 driver supports a new staggered-outputs property for reduced
> > current surges and EMI. This adds documentation for the new DT property.
> 
> Maybe point out the commit that added this support here?

The pca9685 driver patch was not yet accepted and there will be a v2.

Should I wait until the support is in Linus' tree and only then send a
dt-bindings documentation patch, mentioning the commit?

Best regards,
Clemens
Uwe Kleine-König Nov. 20, 2020, 12:48 p.m. UTC | #3
On Fri, Nov 20, 2020 at 01:36:54PM +0100, Clemens Gruber wrote:
> Hi,
> 
> On Fri, Nov 20, 2020 at 09:21:50AM +0100, Uwe Kleine-König wrote:
> > On Wed, Nov 18, 2020 at 06:45:15PM +0100, Clemens Gruber wrote:
> > > The pca9685 driver supports a new staggered-outputs property for reduced
> > > current surges and EMI. This adds documentation for the new DT property.
> > 
> > Maybe point out the commit that added this support here?
> 
> The pca9685 driver patch was not yet accepted and there will be a v2.
> 
> Should I wait until the support is in Linus' tree and only then send a
> dt-bindings documentation patch, mentioning the commit?

Then I'd say add the dt-bindings patch to the series adding this
support.

Best regards
Uwe
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt b/Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt
index f21b55c95738..911bbb65984e 100644
--- a/Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt
+++ b/Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt
@@ -12,6 +12,8 @@  Optional properties:
   - invert (bool): boolean to enable inverted logic
   - open-drain (bool): boolean to configure outputs with open-drain structure;
 		       if omitted use totem-pole structure
+  - staggered-outputs (bool): boolean to enable staggered output ON times to
+			      minimize current surges and EMI
 
 Example: