| Message ID | 20201112215451.2606136-1-linus.walleij@linaro.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [1/3,v2] iio: accel: bmc150-accel: Add DT bindings | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
On Thu, 12 Nov 2020 22:54:49 +0100 Linus Walleij <linus.walleij@linaro.org> wrote: > These accelerometers have bindings used in the kernel and > several device trees but no proper bindings documentation. > Add it. > > Also add a compatible for the BMA222 that I am right now > adding support for in the driver. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> One little note inline on consistency. Jonathan > --- > ChangeLog v1->v2: > - Rename to simply bosch,bma255.yaml after one of the > common accelerometers. > - Specify that the SPI uses a 4-wire interface. > - Specify maximum SPI clock frequency to 10MHz. (Checked > all the datasheets.) > --- > .../bindings/iio/accel/bosch,bma255.yaml | 73 +++++++++++++++++++ > 1 file changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml > > diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml > new file mode 100644 > index 000000000000..5f48bdcf382c > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml > @@ -0,0 +1,73 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/accel/bosch,bma255.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Bosch BMA255 and Similar Accelerometers > + > +maintainers: > + - Linus Walleij <linus.walleij@linaro.org> > + > +description: > + 3 axis accelerometers with varying range and I2C or SPI > + 4-wire interface. > + > +properties: > + compatible: > + enum: > + - bosch,bmc150 > + - bosch,bmi055 > + - bosch,bma255 > + - bosch,bma250e > + - bosch,bma222 > + - bosch,bma222e > + - bosch,bma280 > + > + reg: > + maxItems: 1 > + > + vdd-supply: true > + vddio-supply: true > + > + interrupts: > + maxItems: 1 > + > + mount-matrix: > + description: an optional 3x3 mounting rotation matrix. > + > + spi-max-frequency: > + maximum: 10000000 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #include <dt-bindings/interrupt-controller/irq.h> Off the top of my head I'm not sure it matters, but this placement of the include is inconsistent with the spi case below. Move it outside the i2c { If that's all that comes up in this round I'll do it whilst applying. > + #address-cells = <1>; > + #size-cells = <0>; > + accelerometer@8 { > + compatible = "bosch,bma222"; > + reg = <0x08>; > + vddio-supply = <&vddio>; > + vdd-supply = <&vdd>; > + interrupts = <57 IRQ_TYPE_EDGE_FALLING>; > + }; > + }; > + - | > + # include <dt-bindings/interrupt-controller/irq.h> > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + accel@0 { > + compatible = "bosch,bma222"; > + reg = <0>; > + spi-max-frequency = <10000000>; > + }; > + }; > +...
diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml new file mode 100644 index 000000000000..5f48bdcf382c --- /dev/null +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml @@ -0,0 +1,73 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/accel/bosch,bma255.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Bosch BMA255 and Similar Accelerometers + +maintainers: + - Linus Walleij <linus.walleij@linaro.org> + +description: + 3 axis accelerometers with varying range and I2C or SPI + 4-wire interface. + +properties: + compatible: + enum: + - bosch,bmc150 + - bosch,bmi055 + - bosch,bma255 + - bosch,bma250e + - bosch,bma222 + - bosch,bma222e + - bosch,bma280 + + reg: + maxItems: 1 + + vdd-supply: true + vddio-supply: true + + interrupts: + maxItems: 1 + + mount-matrix: + description: an optional 3x3 mounting rotation matrix. + + spi-max-frequency: + maximum: 10000000 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #include <dt-bindings/interrupt-controller/irq.h> + #address-cells = <1>; + #size-cells = <0>; + accelerometer@8 { + compatible = "bosch,bma222"; + reg = <0x08>; + vddio-supply = <&vddio>; + vdd-supply = <&vdd>; + interrupts = <57 IRQ_TYPE_EDGE_FALLING>; + }; + }; + - | + # include <dt-bindings/interrupt-controller/irq.h> + spi { + #address-cells = <1>; + #size-cells = <0>; + accel@0 { + compatible = "bosch,bma222"; + reg = <0>; + spi-max-frequency = <10000000>; + }; + }; +...
These accelerometers have bindings used in the kernel and several device trees but no proper bindings documentation. Add it. Also add a compatible for the BMA222 that I am right now adding support for in the driver. Cc: devicetree@vger.kernel.org Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- ChangeLog v1->v2: - Rename to simply bosch,bma255.yaml after one of the common accelerometers. - Specify that the SPI uses a 4-wire interface. - Specify maximum SPI clock frequency to 10MHz. (Checked all the datasheets.) --- .../bindings/iio/accel/bosch,bma255.yaml | 73 +++++++++++++++++++ 1 file changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml