| Message ID | 20201112175632.42234-2-james.quinlan@broadcom.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | firmware: arm_scmi: Augment SMC/HVC to allow optional interrupt | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Thu, Nov 12, 2020 at 12:56 PM Jim Quinlan <james.quinlan@broadcom.com> wrote: > > In normal use of smc/hvc transport in SCMI the message completion is > indicated by the return of the SMC call. This commit provides for an > optional interrupt named "message-serviced" which is used instead to > indicate the completion of a message. > > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com> > --- > Documentation/devicetree/bindings/arm/arm,scmi.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/arm,scmi.txt b/Documentation/devicetree/bindings/arm/arm,scmi.txt > index 55deb68230eb..7cdad11f40b1 100644 > --- a/Documentation/devicetree/bindings/arm/arm,scmi.txt > +++ b/Documentation/devicetree/bindings/arm/arm,scmi.txt > @@ -31,6 +31,14 @@ Optional properties: > > - mbox-names: shall be "tx" or "rx" depending on mboxes entries. > > +- interrupts : when using smc or hvc transports, this optional > + property indicates that msg completion by the platform is indicated > + by an interrupt rather than by the return of the smc call. This > + should not be used except when the platform requires such behavior. > + > +- interrupt-names : if "interrupts" is present, interrupt-names must also > + be present and have the value "message-serviced". > + > See Documentation/devicetree/bindings/mailbox/mailbox.txt for more details > about the generic mailbox controller and client driver bindings. Hi Rob, Are you okay with this commit? Regards, Jim Quinlan Broadcom STB > > -- > 2.17.1 >
On Thu, Nov 12, 2020 at 12:56:26PM -0500, Jim Quinlan wrote: > In normal use of smc/hvc transport in SCMI the message completion is > indicated by the return of the SMC call. This commit provides for an > optional interrupt named "message-serviced" which is used instead to > indicate the completion of a message. > > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com> > --- > Documentation/devicetree/bindings/arm/arm,scmi.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/arm,scmi.txt b/Documentation/devicetree/bindings/arm/arm,scmi.txt > index 55deb68230eb..7cdad11f40b1 100644 > --- a/Documentation/devicetree/bindings/arm/arm,scmi.txt > +++ b/Documentation/devicetree/bindings/arm/arm,scmi.txt > @@ -31,6 +31,14 @@ Optional properties: > > - mbox-names: shall be "tx" or "rx" depending on mboxes entries. > > +- interrupts : when using smc or hvc transports, this optional > + property indicates that msg completion by the platform is indicated > + by an interrupt rather than by the return of the smc call. This > + should not be used except when the platform requires such behavior. > + > +- interrupt-names : if "interrupts" is present, interrupt-names must also > + be present and have the value "message-serviced". Don't really need names when only one, but wouldn't 'a2p' be more concise and based on SCMI spec (just guessing...). > + > See Documentation/devicetree/bindings/mailbox/mailbox.txt for more details > about the generic mailbox controller and client driver bindings. > > -- > 2.17.1 >
On Mon, Dec 7, 2020 at 2:01 PM Rob Herring <robh@kernel.org> wrote: > > On Thu, Nov 12, 2020 at 12:56:26PM -0500, Jim Quinlan wrote: > > In normal use of smc/hvc transport in SCMI the message completion is > > indicated by the return of the SMC call. This commit provides for an > > optional interrupt named "message-serviced" which is used instead to > > indicate the completion of a message. > > > > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com> > > --- > > Documentation/devicetree/bindings/arm/arm,scmi.txt | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/arm,scmi.txt b/Documentation/devicetree/bindings/arm/arm,scmi.txt > > index 55deb68230eb..7cdad11f40b1 100644 > > --- a/Documentation/devicetree/bindings/arm/arm,scmi.txt > > +++ b/Documentation/devicetree/bindings/arm/arm,scmi.txt > > @@ -31,6 +31,14 @@ Optional properties: > > > > - mbox-names: shall be "tx" or "rx" depending on mboxes entries. > > > > +- interrupts : when using smc or hvc transports, this optional > > + property indicates that msg completion by the platform is indicated > > + by an interrupt rather than by the return of the smc call. This > > + should not be used except when the platform requires such behavior. > > + > > +- interrupt-names : if "interrupts" is present, interrupt-names must also > > + be present and have the value "message-serviced". > > Don't really need names when only one, but wouldn't 'a2p' be more > concise and based on SCMI spec (just guessing...). I gave it a name because (a) its presence is atypical/not common and (b) future changes may add more interrupts and I don't want this interrupt at index 0. As far as "message-serviced", this was Sudeep's suggestion, IIRC, although I had a similarly long name. Sudeep, are you okay with "a2p". Thanks, Jim > > > + > > See Documentation/devicetree/bindings/mailbox/mailbox.txt for more details > > about the generic mailbox controller and client driver bindings. > > > > -- > > 2.17.1 > > > >
diff --git a/Documentation/devicetree/bindings/arm/arm,scmi.txt b/Documentation/devicetree/bindings/arm/arm,scmi.txt index 55deb68230eb..7cdad11f40b1 100644 --- a/Documentation/devicetree/bindings/arm/arm,scmi.txt +++ b/Documentation/devicetree/bindings/arm/arm,scmi.txt @@ -31,6 +31,14 @@ Optional properties: - mbox-names: shall be "tx" or "rx" depending on mboxes entries. +- interrupts : when using smc or hvc transports, this optional + property indicates that msg completion by the platform is indicated + by an interrupt rather than by the return of the smc call. This + should not be used except when the platform requires such behavior. + +- interrupt-names : if "interrupts" is present, interrupt-names must also + be present and have the value "message-serviced". + See Documentation/devicetree/bindings/mailbox/mailbox.txt for more details about the generic mailbox controller and client driver bindings.
In normal use of smc/hvc transport in SCMI the message completion is indicated by the return of the SMC call. This commit provides for an optional interrupt named "message-serviced" which is used instead to indicate the completion of a message. Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com> --- Documentation/devicetree/bindings/arm/arm,scmi.txt | 8 ++++++++ 1 file changed, 8 insertions(+)