| Message ID | 20201112083704.1173908-1-hsinyi@chromium.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/2] dt-bindings: drm/bridge: anx7625: Add power supplies | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Thu, Nov 12, 2020 at 04:37:04PM +0800, Hsin-Yi Wang wrote: > When suspending the driver, anx7625_power_standby() will be called to > turn off reset-gpios and enable-gpios. However, power supplies are not > disabled. To save power, the driver can get the power supply regulators > and turn off them in anx7625_power_standby(). > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 25 +++++++++++++++++++++++ > drivers/gpu/drm/bridge/analogix/anx7625.h | 1 + > 2 files changed, 26 insertions(+) Reviewed-by: Xin Ji <xji@analogixsemi.com>
On Thu, Nov 12, 2020 at 04:37:03PM +0800, Hsin-Yi Wang wrote: > anx7625 requires 3 power supply regulators. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > .../display/bridge/analogix,anx7625.yaml | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > Reviewed-by: Xin Ji <xji@analogixsemi.com>
On Thu, Nov 12, 2020 at 04:37:03PM +0800, Hsin-Yi Wang wrote: > anx7625 requires 3 power supply regulators. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > .../display/bridge/analogix,anx7625.yaml | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > index 60585a4fc22b..1aa08f10d894 100644 > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > @@ -34,6 +34,18 @@ properties: > description: used for reset chip control, RESET_N pin B7. > maxItems: 1 > > + vdd10-supply: > + description: Regulator that provides the supply 1.0V power. > + maxItems: 1 > + > + vdd18-supply: > + description: Regulator that provides the supply 1.8V power. > + maxItems: 1 > + > + vdd33-supply: > + description: Regulator that provides the supply 3.3V power. > + maxItems: 1 Supplies are always a single item, so you can drop maxItems. > + > ports: > type: object > > @@ -55,6 +67,9 @@ properties: > required: > - compatible > - reg > + - vdd10-supply > + - vdd18-supply > + - vdd33-supply > - ports > > additionalProperties: false > @@ -72,6 +87,9 @@ examples: > reg = <0x58>; > enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; > reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; > + vdd10-supply = <&pp1000_mipibrdg>; > + vdd18-supply = <&pp1800_mipibrdg>; > + vdd33-supply = <&pp3300_mipibrdg>; > > ports { > #address-cells = <1>; > -- > 2.29.2.222.g5d2a92d10f8-goog >
diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml index 60585a4fc22b..1aa08f10d894 100644 --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml @@ -34,6 +34,18 @@ properties: description: used for reset chip control, RESET_N pin B7. maxItems: 1 + vdd10-supply: + description: Regulator that provides the supply 1.0V power. + maxItems: 1 + + vdd18-supply: + description: Regulator that provides the supply 1.8V power. + maxItems: 1 + + vdd33-supply: + description: Regulator that provides the supply 3.3V power. + maxItems: 1 + ports: type: object @@ -55,6 +67,9 @@ properties: required: - compatible - reg + - vdd10-supply + - vdd18-supply + - vdd33-supply - ports additionalProperties: false @@ -72,6 +87,9 @@ examples: reg = <0x58>; enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; + vdd10-supply = <&pp1000_mipibrdg>; + vdd18-supply = <&pp1800_mipibrdg>; + vdd33-supply = <&pp3300_mipibrdg>; ports { #address-cells = <1>;
anx7625 requires 3 power supply regulators. Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> --- .../display/bridge/analogix,anx7625.yaml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)