diff mbox series

dt-bindings: clock: imx5: fix example

Message ID 20201111213548.1621094-1-mkl@pengutronix.de
State Accepted
Headers show
Series dt-bindings: clock: imx5: fix example | expand

Checks

Context Check Description
robh/dt-meta-schema success
robh/checkpatch warning total: 0 errors, 2 warnings, 8 lines checked

Commit Message

Marc Kleine-Budde Nov. 11, 2020, 9:35 p.m. UTC
Since commit:

    0e030a373df3 ("can: flexcan: fix endianess detection")

the fsl,imx53-flexcan isn't compatible with the fsl,p1010-flexcan any more. As
the former accesses the IP core in Little Endian mode and the latter uses Big
Endian mode.

With the conversion of the flexcan DT bindings to yaml, the dt_binding_check
this throws the following error:

Documentation/devicetree/bindings/clock/imx5-clock.example.dt.yaml: can@53fc8000: compatible: 'oneOf' conditional failed, one must be fixed:
        ['fsl,imx53-flexcan', 'fsl,imx25-flexcan'] is too long
        Additional items are not allowed ('fsl,imx25-flexcan' was unexpected)
        'fsl,imx53-flexcan' is not one of ['fsl,imx7d-flexcan', 'fsl,imx6ul-flexcan', 'fsl,imx6sx-flexcan']
        'fsl,imx53-flexcan' is not one of ['fsl,ls1028ar1-flexcan']
        'fsl,imx6q-flexcan' was expected
        'fsl,lx2160ar1-flexcan' was expected
        From schema: Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml

The error is fixed by removing the "fsl,p1010-flexcan" compatible (which turned
out the be incompatible) from the binding example.

Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: devicetree@vger.kernel.org
Reported-by: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 Documentation/devicetree/bindings/clock/imx5-clock.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rob Herring Nov. 11, 2020, 11:09 p.m. UTC | #1
On Wed, Nov 11, 2020 at 10:35:48PM +0100, Marc Kleine-Budde wrote:
> Since commit:
> 
>     0e030a373df3 ("can: flexcan: fix endianess detection")
> 
> the fsl,imx53-flexcan isn't compatible with the fsl,p1010-flexcan any more. As
> the former accesses the IP core in Little Endian mode and the latter uses Big
> Endian mode.
> 
> With the conversion of the flexcan DT bindings to yaml, the dt_binding_check
> this throws the following error:
> 
> Documentation/devicetree/bindings/clock/imx5-clock.example.dt.yaml: can@53fc8000: compatible: 'oneOf' conditional failed, one must be fixed:
>         ['fsl,imx53-flexcan', 'fsl,imx25-flexcan'] is too long
>         Additional items are not allowed ('fsl,imx25-flexcan' was unexpected)
>         'fsl,imx53-flexcan' is not one of ['fsl,imx7d-flexcan', 'fsl,imx6ul-flexcan', 'fsl,imx6sx-flexcan']
>         'fsl,imx53-flexcan' is not one of ['fsl,ls1028ar1-flexcan']
>         'fsl,imx6q-flexcan' was expected
>         'fsl,lx2160ar1-flexcan' was expected
>         From schema: Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> 
> The error is fixed by removing the "fsl,p1010-flexcan" compatible (which turned
> out the be incompatible) from the binding example.
> 
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: devicetree@vger.kernel.org
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/clock/imx5-clock.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/imx5-clock.yaml b/Documentation/devicetree/bindings/clock/imx5-clock.yaml
> index 4d9e7c73dce9..155379c3c41e 100644
> --- a/Documentation/devicetree/bindings/clock/imx5-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/imx5-clock.yaml
> @@ -57,7 +57,7 @@ examples:
>      };
>  
>      can@53fc8000 {
> -        compatible = "fsl,imx53-flexcan", "fsl,p1010-flexcan";
> +        compatible = "fsl,imx53-flexcan";

But you just added that "fsl,imx53-flexcan" has a fallback of 
'fsl,imx25-flexcan'. 

Looks like "fsl,imx53-flexcan" alone needs to be dropped. Decide the one 
way that is valid please. I've dropped the schema change until sorted 
out.

Rob
Rob Herring Nov. 13, 2020, 3 p.m. UTC | #2
On Wed, 11 Nov 2020 22:35:48 +0100, Marc Kleine-Budde wrote:
> Since commit:
> 
>     0e030a373df3 ("can: flexcan: fix endianess detection")
> 
> the fsl,imx53-flexcan isn't compatible with the fsl,p1010-flexcan any more. As
> the former accesses the IP core in Little Endian mode and the latter uses Big
> Endian mode.
> 
> With the conversion of the flexcan DT bindings to yaml, the dt_binding_check
> this throws the following error:
> 
> Documentation/devicetree/bindings/clock/imx5-clock.example.dt.yaml: can@53fc8000: compatible: 'oneOf' conditional failed, one must be fixed:
>         ['fsl,imx53-flexcan', 'fsl,imx25-flexcan'] is too long
>         Additional items are not allowed ('fsl,imx25-flexcan' was unexpected)
>         'fsl,imx53-flexcan' is not one of ['fsl,imx7d-flexcan', 'fsl,imx6ul-flexcan', 'fsl,imx6sx-flexcan']
>         'fsl,imx53-flexcan' is not one of ['fsl,ls1028ar1-flexcan']
>         'fsl,imx6q-flexcan' was expected
>         'fsl,lx2160ar1-flexcan' was expected
>         From schema: Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> 
> The error is fixed by removing the "fsl,p1010-flexcan" compatible (which turned
> out the be incompatible) from the binding example.
> 
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: devicetree@vger.kernel.org
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/clock/imx5-clock.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

I've fixed things up with this and the compatible fixes and applied as 
this needs to get into rc4.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/imx5-clock.yaml b/Documentation/devicetree/bindings/clock/imx5-clock.yaml
index 4d9e7c73dce9..155379c3c41e 100644
--- a/Documentation/devicetree/bindings/clock/imx5-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/imx5-clock.yaml
@@ -57,7 +57,7 @@  examples:
     };
 
     can@53fc8000 {
-        compatible = "fsl,imx53-flexcan", "fsl,p1010-flexcan";
+        compatible = "fsl,imx53-flexcan";
         reg = <0x53fc8000 0x4000>;
         interrupts = <82>;
         clocks = <&clks IMX5_CLK_CAN1_IPG_GATE>, <&clks IMX5_CLK_CAN1_SERIAL_GATE>;