| Message ID | 20201030023906.24259-4-kabel@kernel.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 28 lines checked |
Marek On 10/29/20 9:39 PM, Marek Behún wrote: > Commit 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now") > disallows LED_COLOR_ID_MULTI for now, and instead LED_COLOR_ID_RGB > should be used. Fix this is leds-class-multicolor binding. > > After we have some usecases for non-RGB multicolor LEDs, this can be > changed. > > Signed-off-by: Marek Behún <kabel@kernel.org> > Fixes: 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now") > Cc: devicetree@vger.kernel.org > Cc: robh+dt@kernel.org > --- > .../devicetree/bindings/leds/cznic,turris-omnia-leds.yaml | 4 ++-- > .../devicetree/bindings/leds/leds-class-multicolor.yaml | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml > index fe7fa25877fd..2015db9b7618 100644 > --- a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml > +++ b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml > @@ -73,14 +73,14 @@ examples: > * LEDs. > */ > reg = <0>; > - color = <LED_COLOR_ID_MULTI>; > + color = <LED_COLOR_ID_RGB>; > function = LED_FUNCTION_POWER; > linux,default-trigger = "heartbeat"; > }; > > multi-led@a { > reg = <0xa>; > - color = <LED_COLOR_ID_MULTI>; > + color = <LED_COLOR_ID_RGB>; > function = LED_FUNCTION_INDICATOR; > function-enumerator = <1>; > }; > diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml > index b1a53f054b89..9faa3609a6bb 100644 > --- a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml > +++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml Why are you resubmitting the multicolor.yaml? https://lore.kernel.org/patchwork/patch/1320863/ This is waiting on DT review. Dan
On Fri, 30 Oct 2020 08:08:01 -0500 Dan Murphy <dmurphy@ti.com> wrote: > Why are you resubmitting the multicolor.yaml? > > https://lore.kernel.org/patchwork/patch/1320863/ > > This is waiting on DT review. > > Dan > I must have overlooked that patch, sorry.
On Fri, Oct 30, 2020 at 08:08:01AM -0500, Dan Murphy wrote: > Marek > > On 10/29/20 9:39 PM, Marek Behún wrote: > > Commit 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now") > > disallows LED_COLOR_ID_MULTI for now, and instead LED_COLOR_ID_RGB > > should be used. Fix this is leds-class-multicolor binding. > > > > After we have some usecases for non-RGB multicolor LEDs, this can be > > changed. > > > > Signed-off-by: Marek Behún <kabel@kernel.org> > > Fixes: 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now") > > Cc: devicetree@vger.kernel.org > > Cc: robh+dt@kernel.org > > --- > > .../devicetree/bindings/leds/cznic,turris-omnia-leds.yaml | 4 ++-- > > .../devicetree/bindings/leds/leds-class-multicolor.yaml | 4 ++-- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml > > index fe7fa25877fd..2015db9b7618 100644 > > --- a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml > > +++ b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml > > @@ -73,14 +73,14 @@ examples: > > * LEDs. > > */ > > reg = <0>; > > - color = <LED_COLOR_ID_MULTI>; > > + color = <LED_COLOR_ID_RGB>; > > function = LED_FUNCTION_POWER; > > linux,default-trigger = "heartbeat"; > > }; > > multi-led@a { > > reg = <0xa>; > > - color = <LED_COLOR_ID_MULTI>; > > + color = <LED_COLOR_ID_RGB>; > > function = LED_FUNCTION_INDICATOR; > > function-enumerator = <1>; > > }; > > diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml > > index b1a53f054b89..9faa3609a6bb 100644 > > --- a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml > > +++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml > > Why are you resubmitting the multicolor.yaml? > > https://lore.kernel.org/patchwork/patch/1320863/ > > This is waiting on DT review. I'm expecting another version as you commented on it. Rob
Rob On 11/4/20 3:55 PM, Rob Herring wrote: > On Fri, Oct 30, 2020 at 08:08:01AM -0500, Dan Murphy wrote: >> Marek >> >> On 10/29/20 9:39 PM, Marek Behún wrote: >>> Commit 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now") >>> disallows LED_COLOR_ID_MULTI for now, and instead LED_COLOR_ID_RGB >>> should be used. Fix this is leds-class-multicolor binding. >>> >>> After we have some usecases for non-RGB multicolor LEDs, this can be >>> changed. >>> >>> Signed-off-by: Marek Behún <kabel@kernel.org> >>> Fixes: 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now") >>> Cc: devicetree@vger.kernel.org >>> Cc: robh+dt@kernel.org >>> --- >>> .../devicetree/bindings/leds/cznic,turris-omnia-leds.yaml | 4 ++-- >>> .../devicetree/bindings/leds/leds-class-multicolor.yaml | 4 ++-- >>> 2 files changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml >>> index fe7fa25877fd..2015db9b7618 100644 >>> --- a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml >>> +++ b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml >>> @@ -73,14 +73,14 @@ examples: >>> * LEDs. >>> */ >>> reg = <0>; >>> - color = <LED_COLOR_ID_MULTI>; >>> + color = <LED_COLOR_ID_RGB>; >>> function = LED_FUNCTION_POWER; >>> linux,default-trigger = "heartbeat"; >>> }; >>> multi-led@a { >>> reg = <0xa>; >>> - color = <LED_COLOR_ID_MULTI>; >>> + color = <LED_COLOR_ID_RGB>; >>> function = LED_FUNCTION_INDICATOR; >>> function-enumerator = <1>; >>> }; >>> diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml >>> index b1a53f054b89..9faa3609a6bb 100644 >>> --- a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml >>> +++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml >> Why are you resubmitting the multicolor.yaml? >> >> https://lore.kernel.org/patchwork/patch/1320863/ >> >> This is waiting on DT review. > I'm expecting another version as you commented on it. Yes you applied v2 https://www.spinics.net/lists/devicetree/msg384974.html Dan > Rob
diff --git a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml index fe7fa25877fd..2015db9b7618 100644 --- a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml +++ b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml @@ -73,14 +73,14 @@ examples: * LEDs. */ reg = <0>; - color = <LED_COLOR_ID_MULTI>; + color = <LED_COLOR_ID_RGB>; function = LED_FUNCTION_POWER; linux,default-trigger = "heartbeat"; }; multi-led@a { reg = <0xa>; - color = <LED_COLOR_ID_MULTI>; + color = <LED_COLOR_ID_RGB>; function = LED_FUNCTION_INDICATOR; function-enumerator = <1>; }; diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml index b1a53f054b89..9faa3609a6bb 100644 --- a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml +++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml @@ -25,10 +25,10 @@ patternProperties: description: Represents the LEDs that are to be grouped. properties: color: - const: 8 # LED_COLOR_ID_MULTI + const: 9 # LED_COLOR_ID_RGB description: | For multicolor LED support this property should be defined as - LED_COLOR_ID_MULTI which can be found in include/linux/leds/common.h. + LED_COLOR_ID_RGB which can be found in include/linux/leds/common.h. $ref: "common.yaml#"
Commit 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now") disallows LED_COLOR_ID_MULTI for now, and instead LED_COLOR_ID_RGB should be used. Fix this is leds-class-multicolor binding. After we have some usecases for non-RGB multicolor LEDs, this can be changed. Signed-off-by: Marek Behún <kabel@kernel.org> Fixes: 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now") Cc: devicetree@vger.kernel.org Cc: robh+dt@kernel.org --- .../devicetree/bindings/leds/cznic,turris-omnia-leds.yaml | 4 ++-- .../devicetree/bindings/leds/leds-class-multicolor.yaml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)