diff mbox series

[6/6] doc: dt-binding: cdns,usb3: add wakeup-irq

Message ID 20201022014411.2343-1-peter.chen@nxp.com
State Changes Requested
Headers show
Series None | expand

Checks

Context Check Description
robh/checkpatch success

Commit Message

Peter Chen Oct. 22, 2020, 1:44 a.m. UTC
To support low power mode for controller, the driver needs wakeup-irq
to reflect the signal changing after controller is stopped, and waking
the controller up accordingly.

Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
 Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rob Herring Oct. 30, 2020, 3:22 p.m. UTC | #1
On Thu, Oct 22, 2020 at 09:44:11AM +0800, Peter Chen wrote:
> To support low power mode for controller, the driver needs wakeup-irq
> to reflect the signal changing after controller is stopped, and waking
> the controller up accordingly.
> 
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
>  Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
> index ac20b98e9910..0171e64ef95e 100644
> --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
> +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
> @@ -30,12 +30,15 @@ properties:
>        - description: OTG/DRD controller interrupt
>        - description: XHCI host controller interrupt
>        - description: Device controller interrupt
> +      - description: interrupt used to wake up core, eg: when usbcmd.rs is
> +      cleared by xhci core, this interrupt is optional.

You need 'minItems: 3' here and below to make this optional. I guess we 
don't have an example for this binding or it would fail.

>  
>    interrupt-names:
>      items:
>        - const: host
>        - const: peripheral
>        - const: otg
> +      - const: wakeup
>  
>    dr_mode:
>      enum: [host, otg, peripheral]
> -- 
> 2.17.1
>
Peter Chen Oct. 30, 2020, 11:10 p.m. UTC | #2
> > @@ -30,12 +30,15 @@ properties:
> >        - description: OTG/DRD controller interrupt
> >        - description: XHCI host controller interrupt
> >        - description: Device controller interrupt
> > +      - description: interrupt used to wake up core, eg: when usbcmd.rs is
> > +      cleared by xhci core, this interrupt is optional.
> 
> You need 'minItems: 3' here and below to make this optional. I guess we don't
> have an example for this binding or it would fail.
> 

Updated, and sent v2. Yes, we don't need it for example, the probe will not fail even
this property is not there.

Peter

> >
> >    interrupt-names:
> >      items:
> >        - const: host
> >        - const: peripheral
> >        - const: otg
> > +      - const: wakeup
> >
> >    dr_mode:
> >      enum: [host, otg, peripheral]
> > --
> > 2.17.1
> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
index ac20b98e9910..0171e64ef95e 100644
--- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
+++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
@@ -30,12 +30,15 @@  properties:
       - description: OTG/DRD controller interrupt
       - description: XHCI host controller interrupt
       - description: Device controller interrupt
+      - description: interrupt used to wake up core, eg: when usbcmd.rs is
+      cleared by xhci core, this interrupt is optional.
 
   interrupt-names:
     items:
       - const: host
       - const: peripheral
       - const: otg
+      - const: wakeup
 
   dr_mode:
     enum: [host, otg, peripheral]