diff mbox series

dt-bindings: power/supply: Add ltc4162-l-charger

Message ID 20201021141030.27751-1-mike.looijmans@topic.nl
State Changes Requested
Headers show
Series dt-bindings: power/supply: Add ltc4162-l-charger | expand

Checks

Context Check Description
robh/dt-meta-schema success
robh/checkpatch success

Commit Message

Mike Looijmans Oct. 21, 2020, 2:10 p.m. UTC
Add support for the LTC4162-L Li-Ion battery charger. The driver allows
reading back telemetry and to set some charging options like the input
current limit.

This adds the devicetree bindings.

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
---
 .../bindings/power/supply/ltc4162-l.yaml      | 60 +++++++++++++++++++
 1 file changed, 60 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml

Comments

Rob Herring Oct. 26, 2020, 2:43 p.m. UTC | #1
On Wed, Oct 21, 2020 at 04:10:30PM +0200, Mike Looijmans wrote:
> Add support for the LTC4162-L Li-Ion battery charger. The driver allows
> reading back telemetry and to set some charging options like the input
> current limit.
> 
> This adds the devicetree bindings.
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> ---
>  .../bindings/power/supply/ltc4162-l.yaml      | 60 +++++++++++++++++++
>  1 file changed, 60 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml b/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
> new file mode 100644
> index 000000000000..a23dd6f3fae0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (C) 2020 Topic Embedded Products
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/power/supply/ltc4162-l.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Linear Technology (Analog Devices) LTC4162-L Charger
> +
> +maintainers:
> +  - Mike Looijmans <mike.looijmans@topic.nl>
> +
> +description: |
> +  The LTC ® 4162-L is an advanced monolithic synchronous step-down switching
> +  battery charger and PowerPath (TM) manager that seamlessly manages power
> +  distribution between input sources such as wall adapters, backplanes, solar
> +  panels, etc., and a rechargeable Lithium-Ion/Polymer battery.
> +
> +  Specifications about the charger can be found at:
> +    https://www.analog.com/en/products/ltc4162-s.html
> +
> +properties:
> +  compatible:
> +    enum:
> +      - lltc,ltc4162-l
> +
> +  reg:
> +    maxItems: 1
> +    description: I2C address of the charger.
> +
> +  lltc,rsnsb:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Battery sense resistor in milli Ohm.
> +    minimum: 1
> +
> +  lltc,rsnsi:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Input current sense resistor in milli Ohm.
> +    minimum: 1

These should have a unit suffix as defined in property-units.txt. 
There's not one for milli Ohms, does micro Ohms give you enough range? 
If not, you can add it though that's discouraged simply so that we don't 
have differring units in each binding for the same thing.

Rob
Mike Looijmans Oct. 26, 2020, 3:08 p.m. UTC | #2
Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@topicproducts.com
W: www.topicproducts.com

Please consider the environment before printing this e-mail
On 26-10-2020 15:43, Rob Herring wrote:
> On Wed, Oct 21, 2020 at 04:10:30PM +0200, Mike Looijmans wrote:
>> Add support for the LTC4162-L Li-Ion battery charger. The driver allows
>> reading back telemetry and to set some charging options like the input
>> current limit.
>>
>> This adds the devicetree bindings.
>>
>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
>> ---
>>   .../bindings/power/supply/ltc4162-l.yaml      | 60 +++++++++++++++++++
>>   1 file changed, 60 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml b/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
>> new file mode 100644
>> index 000000000000..a23dd6f3fae0
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
>> @@ -0,0 +1,60 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +# Copyright (C) 2020 Topic Embedded Products
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/power/supply/ltc4162-l.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>> +
>> +title: Linear Technology (Analog Devices) LTC4162-L Charger
>> +
>> +maintainers:
>> +  - Mike Looijmans <mike.looijmans@topic.nl>
>> +
>> +description: |
>> +  The LTC ® 4162-L is an advanced monolithic synchronous step-down switching
>> +  battery charger and PowerPath (TM) manager that seamlessly manages power
>> +  distribution between input sources such as wall adapters, backplanes, solar
>> +  panels, etc., and a rechargeable Lithium-Ion/Polymer battery.
>> +
>> +  Specifications about the charger can be found at:
>> +    https://www.analog.com/en/products/ltc4162-s.html
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - lltc,ltc4162-l
>> +
>> +  reg:
>> +    maxItems: 1
>> +    description: I2C address of the charger.
>> +
>> +  lltc,rsnsb:
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    description: Battery sense resistor in milli Ohm.
>> +    minimum: 1
>> +
>> +  lltc,rsnsi:
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    description: Input current sense resistor in milli Ohm.
>> +    minimum: 1
> These should have a unit suffix as defined in property-units.txt.
> There's not one for milli Ohms, does micro Ohms give you enough range?
> If not, you can add it though that's discouraged simply so that we don't
> have differring units in each binding for the same thing.

Micro Ohms is fine, might even be beneficial. Expected values are in the 
10 milliohm range. Sorry to have missed that. I'll adapt the driver to 
use this value without overflowing.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml b/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
new file mode 100644
index 000000000000..a23dd6f3fae0
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
@@ -0,0 +1,60 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright (C) 2020 Topic Embedded Products
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/power/supply/ltc4162-l.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Linear Technology (Analog Devices) LTC4162-L Charger
+
+maintainers:
+  - Mike Looijmans <mike.looijmans@topic.nl>
+
+description: |
+  The LTC ® 4162-L is an advanced monolithic synchronous step-down switching
+  battery charger and PowerPath (TM) manager that seamlessly manages power
+  distribution between input sources such as wall adapters, backplanes, solar
+  panels, etc., and a rechargeable Lithium-Ion/Polymer battery.
+
+  Specifications about the charger can be found at:
+    https://www.analog.com/en/products/ltc4162-s.html
+
+properties:
+  compatible:
+    enum:
+      - lltc,ltc4162-l
+
+  reg:
+    maxItems: 1
+    description: I2C address of the charger.
+
+  lltc,rsnsb:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: Battery sense resistor in milli Ohm.
+    minimum: 1
+
+  lltc,rsnsi:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: Input current sense resistor in milli Ohm.
+    minimum: 1
+
+required:
+  - compatible
+  - reg
+  - lltc,rsnsb
+  - lltc,rsnsi
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c0 {
+      #address-cells = <1>;
+      #size-cells = <0>;
+      charger: battery-charger@68 {
+              compatible = "lltc,ltc4162-l";
+              reg =  <0x68>;
+              lltc,rsnsb = <10>;
+              lltc,rsnsi = <16>;
+      };
+    };