diff mbox series

dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value

Message ID 20201018193016.3339045-1-fparent@baylibre.com
State Accepted
Headers show
Series dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value | expand

Checks

Context Check Description
robh/checkpatch success

Commit Message

Fabien Parent Oct. 18, 2020, 7:30 p.m. UTC
As the binding documentation says, #mbox-cells must have a value of 2,
but the example use a value 3. The MT8173 device tree correctly use
mbox-cells = <2>. This commit fixes the example.

Signed-off-by: Fabien Parent <fparent@baylibre.com>
---
 Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Matthias Brugger Oct. 19, 2020, 10:18 a.m. UTC | #1
On 18/10/2020 21:30, Fabien Parent wrote:
> As the binding documentation says, #mbox-cells must have a value of 2,
> but the example use a value 3. The MT8173 device tree correctly use
> mbox-cells = <2>. This commit fixes the example.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> ---

Fixes: 19d8e335d58a ("dt-binding: gce: remove atomic_exec in mboxes property")

With that:
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

>   Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> index cf48cd806e00..7771ecaac586 100644
> --- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> +++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> @@ -47,7 +47,7 @@ Example:
>   		interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_LOW>;
>   		clocks = <&infracfg CLK_INFRA_GCE>;
>   		clock-names = "gce";
> -		#mbox-cells = <3>;
> +		#mbox-cells = <2>;
>   	};
>   
>   Example for a client device:
>
Rob Herring Oct. 23, 2020, 4:49 p.m. UTC | #2
On Sun, 18 Oct 2020 21:30:16 +0200, Fabien Parent wrote:
> As the binding documentation says, #mbox-cells must have a value of 2,
> but the example use a value 3. The MT8173 device tree correctly use
> mbox-cells = <2>. This commit fixes the example.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> ---
>  Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
index cf48cd806e00..7771ecaac586 100644
--- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
+++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
@@ -47,7 +47,7 @@  Example:
 		interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_LOW>;
 		clocks = <&infracfg CLK_INFRA_GCE>;
 		clock-names = "gce";
-		#mbox-cells = <3>;
+		#mbox-cells = <2>;
 	};
 
 Example for a client device: