diff mbox series

[v3,4/5] media: dt-bindings: media: renesas,drif: Add r8a77965 support

Message ID 20201013150150.14801-5-fabrizio.castro.jz@renesas.com
State Superseded
Headers show
Series Add r8a77965 DRIF support | expand

Checks

Context Check Description
robh/dt-meta-schema success
robh/checkpatch success

Commit Message

Fabrizio Castro Oct. 13, 2020, 3:01 p.m. UTC
The r8a77965 (a.k.a. R-Car M3-N) device tree schema is
compatible with the already documented R-Car Gen3 devices.

Document r8a77965 support within renesas,drif.yaml.

Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
---
v2->v3:
* New patch

 Documentation/devicetree/bindings/media/renesas,drif.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Laurent Pinchart Oct. 13, 2020, 8:47 p.m. UTC | #1
Hi Fabrizio,

Thank you for the patch.

On Tue, Oct 13, 2020 at 04:01:49PM +0100, Fabrizio Castro wrote:
> The r8a77965 (a.k.a. R-Car M3-N) device tree schema is
> compatible with the already documented R-Car Gen3 devices.
> 
> Document r8a77965 support within renesas,drif.yaml.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> v2->v3:
> * New patch
> 
>  Documentation/devicetree/bindings/media/renesas,drif.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,drif.yaml b/Documentation/devicetree/bindings/media/renesas,drif.yaml
> index ae50b1448320..89445ddd598e 100644
> --- a/Documentation/devicetree/bindings/media/renesas,drif.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
> @@ -53,6 +53,7 @@ properties:
>        - enum:
>          - renesas,r8a7795-drif        # R-Car H3
>          - renesas,r8a7796-drif        # R-Car M3-W
> +        - renesas,r8a77965-drif       # R-Car M3-N
>          - renesas,r8a77990-drif       # R-Car E3
>        - const: renesas,rcar-gen3-drif # Generic R-Car Gen3 compatible device
>
Lad, Prabhakar Oct. 13, 2020, 9:50 p.m. UTC | #2
Hi Fabrizio,

Thank you for the patch.

On Tue, Oct 13, 2020 at 6:25 PM Fabrizio Castro
<fabrizio.castro.jz@renesas.com> wrote:
>
> The r8a77965 (a.k.a. R-Car M3-N) device tree schema is
> compatible with the already documented R-Car Gen3 devices.
>
> Document r8a77965 support within renesas,drif.yaml.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> ---
> v2->v3:
> * New patch
>
>  Documentation/devicetree/bindings/media/renesas,drif.yaml | 1 +
>  1 file changed, 1 insertion(+)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar

> diff --git a/Documentation/devicetree/bindings/media/renesas,drif.yaml b/Documentation/devicetree/bindings/media/renesas,drif.yaml
> index ae50b1448320..89445ddd598e 100644
> --- a/Documentation/devicetree/bindings/media/renesas,drif.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
> @@ -53,6 +53,7 @@ properties:
>        - enum:
>          - renesas,r8a7795-drif        # R-Car H3
>          - renesas,r8a7796-drif        # R-Car M3-W
> +        - renesas,r8a77965-drif       # R-Car M3-N
>          - renesas,r8a77990-drif       # R-Car E3
>        - const: renesas,rcar-gen3-drif # Generic R-Car Gen3 compatible device
>
> --
> 2.25.1
>
Geert Uytterhoeven Oct. 14, 2020, 1:37 p.m. UTC | #3
Hi Fabrizio,

On Tue, Oct 13, 2020 at 5:02 PM Fabrizio Castro
<fabrizio.castro.jz@renesas.com> wrote:
> The r8a77965 (a.k.a. R-Car M3-N) device tree schema is
> compatible with the already documented R-Car Gen3 devices.
>
> Document r8a77965 support within renesas,drif.yaml.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/Documentation/devicetree/bindings/media/renesas,drif.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
> @@ -53,6 +53,7 @@ properties:
>        - enum:
>          - renesas,r8a7795-drif        # R-Car H3
>          - renesas,r8a7796-drif        # R-Car M3-W
> +        - renesas,r8a77965-drif       # R-Car M3-N
>          - renesas,r8a77990-drif       # R-Car E3
>        - const: renesas,rcar-gen3-drif # Generic R-Car Gen3 compatible device

I guess you're aware M3-N (and E3) have an extra register?
Probably the driver just relies on its initial value, but it never hurts to be
explicit and initialize it properly.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Fabrizio Castro Oct. 14, 2020, 2:35 p.m. UTC | #4
Hi Geert,

Thank you for your feedback!

> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 14 October 2020 14:38
> Subject: Re: [PATCH v3 4/5] media: dt-bindings: media: renesas,drif: Add
> r8a77965 support
>
> Hi Fabrizio,
>
> On Tue, Oct 13, 2020 at 5:02 PM Fabrizio Castro
> <fabrizio.castro.jz@renesas.com> wrote:
> > The r8a77965 (a.k.a. R-Car M3-N) device tree schema is
> > compatible with the already documented R-Car Gen3 devices.
> >
> > Document r8a77965 support within renesas,drif.yaml.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
>
> Thanks for your patch!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > --- a/Documentation/devicetree/bindings/media/renesas,drif.yaml
> > +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
> > @@ -53,6 +53,7 @@ properties:
> >        - enum:
> >          - renesas,r8a7795-drif        # R-Car H3
> >          - renesas,r8a7796-drif        # R-Car M3-W
> > +        - renesas,r8a77965-drif       # R-Car M3-N
> >          - renesas,r8a77990-drif       # R-Car E3
> >        - const: renesas,rcar-gen3-drif # Generic R-Car Gen3 compatible device
>
> I guess you're aware M3-N (and E3) have an extra register?
> Probably the driver just relies on its initial value, but it never hurts to be
> explicit and initialize it properly.

Yes, I am aware of the extra register, and that's reflected in the DRIF nodes
definition within the SoC specific device trees.
I'll tackle initialization and configuration of the extra register at some point,
do you think we could use the default value for now?

>
> Gr{oetje,eeting}s,
>
>                         Geert
>
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
Geert Uytterhoeven Oct. 14, 2020, 2:51 p.m. UTC | #5
Hi Fabrizio,

On Wed, Oct 14, 2020 at 4:35 PM Fabrizio Castro
<fabrizio.castro.jz@renesas.com> wrote:
> > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > On Tue, Oct 13, 2020 at 5:02 PM Fabrizio Castro
> > <fabrizio.castro.jz@renesas.com> wrote:
> > > The r8a77965 (a.k.a. R-Car M3-N) device tree schema is
> > > compatible with the already documented R-Car Gen3 devices.
> > >
> > > Document r8a77965 support within renesas,drif.yaml.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> >
> > Thanks for your patch!
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > > --- a/Documentation/devicetree/bindings/media/renesas,drif.yaml
> > > +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
> > > @@ -53,6 +53,7 @@ properties:
> > >        - enum:
> > >          - renesas,r8a7795-drif        # R-Car H3
> > >          - renesas,r8a7796-drif        # R-Car M3-W
> > > +        - renesas,r8a77965-drif       # R-Car M3-N
> > >          - renesas,r8a77990-drif       # R-Car E3
> > >        - const: renesas,rcar-gen3-drif # Generic R-Car Gen3 compatible device
> >
> > I guess you're aware M3-N (and E3) have an extra register?
> > Probably the driver just relies on its initial value, but it never hurts to be
> > explicit and initialize it properly.
>
> Yes, I am aware of the extra register, and that's reflected in the DRIF nodes
> definition within the SoC specific device trees.
> I'll tackle initialization and configuration of the extra register at some point,
> do you think we could use the default value for now?

Yes, that's fine for me, if it works with the current driver.

Gr{oetje,eeting}s,

                        Geert
Fabrizio Castro Oct. 14, 2020, 4:01 p.m. UTC | #6
Hi Geert,

> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 14 October 2020 15:52
> Subject: Re: [PATCH v3 4/5] media: dt-bindings: media: renesas,drif: Add
> r8a77965 support
>
> Hi Fabrizio,
>
> On Wed, Oct 14, 2020 at 4:35 PM Fabrizio Castro
> <fabrizio.castro.jz@renesas.com> wrote:
> > > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > > On Tue, Oct 13, 2020 at 5:02 PM Fabrizio Castro
> > > <fabrizio.castro.jz@renesas.com> wrote:
> > > > The r8a77965 (a.k.a. R-Car M3-N) device tree schema is
> > > > compatible with the already documented R-Car Gen3 devices.
> > > >
> > > > Document r8a77965 support within renesas,drif.yaml.
> > > >
> > > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> > >
> > > Thanks for your patch!
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > >
> > > > --- a/Documentation/devicetree/bindings/media/renesas,drif.yaml
> > > > +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
> > > > @@ -53,6 +53,7 @@ properties:
> > > >        - enum:
> > > >          - renesas,r8a7795-drif        # R-Car H3
> > > >          - renesas,r8a7796-drif        # R-Car M3-W
> > > > +        - renesas,r8a77965-drif       # R-Car M3-N
> > > >          - renesas,r8a77990-drif       # R-Car E3
> > > >        - const: renesas,rcar-gen3-drif # Generic R-Car Gen3 compatible
> device
> > >
> > > I guess you're aware M3-N (and E3) have an extra register?
> > > Probably the driver just relies on its initial value, but it never hurts to be
> > > explicit and initialize it properly.
> >
> > Yes, I am aware of the extra register, and that's reflected in the DRIF nodes
> > definition within the SoC specific device trees.
> > I'll tackle initialization and configuration of the extra register at some point,
> > do you think we could use the default value for now?
>
> Yes, that's fine for me, if it works with the current driver.

Yes, and thank you.

Cheers,
Fab

>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/renesas,drif.yaml b/Documentation/devicetree/bindings/media/renesas,drif.yaml
index ae50b1448320..89445ddd598e 100644
--- a/Documentation/devicetree/bindings/media/renesas,drif.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
@@ -53,6 +53,7 @@  properties:
       - enum:
         - renesas,r8a7795-drif        # R-Car H3
         - renesas,r8a7796-drif        # R-Car M3-W
+        - renesas,r8a77965-drif       # R-Car M3-N
         - renesas,r8a77990-drif       # R-Car E3
       - const: renesas,rcar-gen3-drif # Generic R-Car Gen3 compatible device