diff mbox series

[1/2] dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC

Message ID 20201012205218.3010868-1-fparent@baylibre.com
State Not Applicable
Headers show
Series [1/2] dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC | expand

Checks

Context Check Description
robh/checkpatch success

Commit Message

Fabien Parent Oct. 12, 2020, 8:52 p.m. UTC
Add documentation for the auxadc binding for MT8516 SoC.

Signed-off-by: Fabien Parent <fparent@baylibre.com>
---
 Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Matthias Brugger Oct. 13, 2020, 6 a.m. UTC | #1
On 12/10/2020 22:52, Fabien Parent wrote:
> Add documentation for the auxadc binding for MT8516 SoC.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
>   Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> index 78c06e05c8e5..1b7ff9e5615a 100644
> --- a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> @@ -17,6 +17,7 @@ Required properties:
>       - "mediatek,mt7622-auxadc": For MT7622 family of SoCs
>       - "mediatek,mt8173-auxadc": For MT8173 family of SoCs
>       - "mediatek,mt8183-auxadc", "mediatek,mt8173-auxadc": For MT8183 family of SoCs
> +    - "mediatek,mt8516-auxadc", "mediatek,mt8173-auxadc": For MT8516 family of SoCs
>     - reg: Address range of the AUXADC unit.
>     - clocks: Should contain a clock specifier for each entry in clock-names
>     - clock-names: Should contain "main".
>
Matthias Brugger Oct. 13, 2020, 6:01 a.m. UTC | #2
On 12/10/2020 22:52, Fabien Parent wrote:
> Add node for the auxadc IP. The IP is compatible with the one found
> in MT8173 SoC.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> ---
>   arch/arm64/boot/dts/mediatek/mt8516.dtsi | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8516.dtsi b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> index 89af661e7f63..943c426e9aaf 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> @@ -470,5 +470,15 @@ usb0_port: usb-phy@11110800 {
>   				#phy-cells = <1>;
>   			};
>   		};
> +
> +		auxadc: adc@11003000 {
> +			compatible = "mediatek,mt8516-auxadc",
> +				     "mediatek,mt8173-auxadc";
> +			reg = <0 0x11003000 0 0x1000>;
> +			clocks = <&topckgen CLK_TOP_AUX_ADC>;
> +			clock-names = "main";
> +			#io-channel-cells = <1>;
> +			status = "disabled";
> +		};
>   	};
>   };
> 

Any reason you don't enable the status in the pumpkin dts?

Regards,
Matthias
Fabien Parent Oct. 13, 2020, 9:06 a.m. UTC | #3
Hi Matthias,

> Any reason you don't enable the status in the pumpkin dts?

No particular reasons. I looked at what other MTK SoC did for this IP,
and half went with the status to be disabled and the other half went
with an enabled status.  So I went the mt8183 way since it is the last
MTK SoC to have been merged and disabled by default. If you think it
is better to be enabled by default, I can change it, I don't have any
strong opinion about this.
Matthias Brugger Oct. 13, 2020, 3:29 p.m. UTC | #4
On 13/10/2020 11:06, Fabien Parent wrote:
> Hi Matthias,
> 
>> Any reason you don't enable the status in the pumpkin dts?
> 
> No particular reasons. I looked at what other MTK SoC did for this IP,
> and half went with the status to be disabled and the other half went
> with an enabled status.  So I went the mt8183 way since it is the last
> MTK SoC to have been merged and disabled by default. If you think it
> is better to be enabled by default, I can change it, I don't have any
> strong opinion about this.
> 

Well on mt8183 it is missing the thermal driver although as you can read the 
values via sysfs I'd say to enable it. No need to resend just because of that. 
I'll take the patch as-is as soon as Jonathan takes 1/2.

Regards,
Matthias
Rob Herring Oct. 13, 2020, 5:22 p.m. UTC | #5
On Mon, 12 Oct 2020 22:52:17 +0200, Fabien Parent wrote:
> Add documentation for the auxadc binding for MT8516 SoC.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Jonathan Cameron Oct. 18, 2020, 10:11 a.m. UTC | #6
On Tue, 13 Oct 2020 08:00:25 +0200
Matthias Brugger <matthias.bgg@gmail.com> wrote:

> On 12/10/2020 22:52, Fabien Parent wrote:
> > Add documentation for the auxadc binding for MT8516 SoC.
> > 
> > Signed-off-by: Fabien Parent <fparent@baylibre.com>  
> 
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to poke at it (or do nothing given it's
a txt file ;)

Jonathan

> 
> > ---
> >   Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> > index 78c06e05c8e5..1b7ff9e5615a 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> > +++ b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> > @@ -17,6 +17,7 @@ Required properties:
> >       - "mediatek,mt7622-auxadc": For MT7622 family of SoCs
> >       - "mediatek,mt8173-auxadc": For MT8173 family of SoCs
> >       - "mediatek,mt8183-auxadc", "mediatek,mt8173-auxadc": For MT8183 family of SoCs
> > +    - "mediatek,mt8516-auxadc", "mediatek,mt8173-auxadc": For MT8516 family of SoCs
> >     - reg: Address range of the AUXADC unit.
> >     - clocks: Should contain a clock specifier for each entry in clock-names
> >     - clock-names: Should contain "main".
> >
Matthias Brugger Oct. 19, 2020, 10:21 a.m. UTC | #7
On 12/10/2020 22:52, Fabien Parent wrote:
> Add node for the auxadc IP. The IP is compatible with the one found
> in MT8173 SoC.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>

Applied to v5.10-tmp/dts64

Thanks!

> ---
>   arch/arm64/boot/dts/mediatek/mt8516.dtsi | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8516.dtsi b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> index 89af661e7f63..943c426e9aaf 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> @@ -470,5 +470,15 @@ usb0_port: usb-phy@11110800 {
>   				#phy-cells = <1>;
>   			};
>   		};
> +
> +		auxadc: adc@11003000 {
> +			compatible = "mediatek,mt8516-auxadc",
> +				     "mediatek,mt8173-auxadc";
> +			reg = <0 0x11003000 0 0x1000>;
> +			clocks = <&topckgen CLK_TOP_AUX_ADC>;
> +			clock-names = "main";
> +			#io-channel-cells = <1>;
> +			status = "disabled";
> +		};
>   	};
>   };
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
index 78c06e05c8e5..1b7ff9e5615a 100644
--- a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
+++ b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
@@ -17,6 +17,7 @@  Required properties:
     - "mediatek,mt7622-auxadc": For MT7622 family of SoCs
     - "mediatek,mt8173-auxadc": For MT8173 family of SoCs
     - "mediatek,mt8183-auxadc", "mediatek,mt8173-auxadc": For MT8183 family of SoCs
+    - "mediatek,mt8516-auxadc", "mediatek,mt8173-auxadc": For MT8516 family of SoCs
   - reg: Address range of the AUXADC unit.
   - clocks: Should contain a clock specifier for each entry in clock-names
   - clock-names: Should contain "main".