| Message ID | 20201010224121.12672-5-Sergey.Semin@baikalelectronics.ru |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: usb: Add generic USB HCD, xHCI, DWC USB3 DT schema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
On 11.10.2020 1:41, Serge Semin wrote: > Aside from the UTMI+ there are also ULPI, Serial and HSIC PHY types "That" missing after "types"? > can be specified in the phy_type HCD property. Add them to the > enumeration of the acceptable values. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> [...] MBR, Sergei
On Sun, Oct 11, 2020 at 11:49:10AM +0300, Sergei Shtylyov wrote: > On 11.10.2020 1:41, Serge Semin wrote: > > > Aside from the UTMI+ there are also ULPI, Serial and HSIC PHY types > > "That" missing after "types"? Thanks. It really is. I'll fix it in v2. -Sergey > > > can be specified in the phy_type HCD property. Add them to the > > enumeration of the acceptable values. > > > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > [...] > > MBR, Sergei
diff --git a/Documentation/devicetree/bindings/usb/usb-hcd.yaml b/Documentation/devicetree/bindings/usb/usb-hcd.yaml index 39e90147dfcc..1eddcbf0a9d8 100644 --- a/Documentation/devicetree/bindings/usb/usb-hcd.yaml +++ b/Documentation/devicetree/bindings/usb/usb-hcd.yaml @@ -42,11 +42,13 @@ properties: phy_type: description: | Tells USB controllers that we want to configure the core to support a - UTMI+ PHY with an 8- or 16-bit interface if UTMI+ is selected. In case - this isn't passed via DT, USB controllers should default to HW - capability. + UTMI+ PHY with an 8- or 16-bit interface if UTMI+ is selected, UTMI+ low + pin interface if ULPI is specified, Serial core/PHY interconnect if + serial is specified and High-Speed Inter-Chip feature if HSIC is + selected. In case this isn't passed via DT, USB controllers should + default to HW capability. $ref: /schemas/types.yaml#/definitions/string - enum: ["utmi", "utmi_wide"] + enum: ["utmi", "utmi_wide", "ulpi", "serial", "hsic"] otg-rev: description: |
Aside from the UTMI+ there are also ULPI, Serial and HSIC PHY types can be specified in the phy_type HCD property. Add them to the enumeration of the acceptable values. Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> --- Documentation/devicetree/bindings/usb/usb-hcd.yaml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)