diff mbox series

[13/18] dt-bindings: usb: dwc3: Add Tx De-emphasis restrictions

Message ID 20201010224121.12672-14-Sergey.Semin@baikalelectronics.ru
State Changes Requested
Headers show
Series dt-bindings: usb: Add generic USB HCD, xHCI, DWC USB3 DT schema | expand

Checks

Context Check Description
robh/checkpatch success

Commit Message

Serge Semin Oct. 10, 2020, 10:41 p.m. UTC
In accordance with the driver comments the PIPE3 de-emphasis can be tunned
to be either -6dB, or -2.5dB or disabled. Let's add the de-emphasis
property restriction so the DT schema would make sure the controller DT
node is equipped with correct values.

Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
---
 Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Sergei Shtylyov Oct. 11, 2020, 8:56 a.m. UTC | #1
On 11.10.2020 1:41, Serge Semin wrote:

> In accordance with the driver comments the PIPE3 de-emphasis can be tunned

    Tuned.

> to be either -6dB, or -2.5dB or disabled. Let's add the de-emphasis

    Either -6dB, -2.5dB, or disabled?

> property restriction so the DT schema would make sure the controller DT
> node is equipped with correct values.
> 
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
[...]

MBR, Sergei
Serge Semin Oct. 11, 2020, 6:14 p.m. UTC | #2
On Sun, Oct 11, 2020 at 11:56:21AM +0300, Sergei Shtylyov wrote:
> On 11.10.2020 1:41, Serge Semin wrote:
> 
> > In accordance with the driver comments the PIPE3 de-emphasis can be tunned
> 

>    Tuned.

Oh. My spell checker accepted this as past participle of the verb "tun" .)

> 
> > to be either -6dB, or -2.5dB or disabled. Let's add the de-emphasis
> 

>    Either -6dB, -2.5dB, or disabled?

Hm, I always thought that "or" is supposed to be placed before each alternative
in the either-or construction, like "either ... or ... or ... or ...". Am I wrong?

-Sergey

> 
> > property restriction so the DT schema would make sure the controller DT
> > node is equipped with correct values.
> > 
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> [...]
> 
> MBR, Sergei
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
index fe1b372fda80..36d4b8060d7c 100644
--- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
@@ -145,6 +145,10 @@  properties:
       The value driven to the PHY is controlled by the LTSSM during USB3
       Compliance mode.
     $ref: /schemas/types.yaml#/definitions/uint8
+    enum:
+      - 0 # -6dB de-emphasis
+      - 1 # -3.5dB de-emphasis
+      - 2 # No de-emphasis
 
   snps,dis_u3_susphy_quirk:
     description: When set core will disable USB3 suspend phy