diff mbox series

dt-bindings: mfd: ti,j721e-system-controller: Fix incorrect pattern property

Message ID 20201002230606.3522954-1-robh@kernel.org
State Accepted
Headers show
Series dt-bindings: mfd: ti,j721e-system-controller: Fix incorrect pattern property | expand

Checks

Context Check Description
robh/dt-meta-schema success
robh/checkpatch warning total: 0 errors, 1 warnings, 10 lines checked

Commit Message

Rob Herring Oct. 2, 2020, 11:06 p.m. UTC
Pattern properties go under 'patternProperties', not 'properties'.
Otherwise, the pattern is treated as a literal string.

A corresponding meta-schema check has been added to catch bad DT property
names like this.

Fixes: e0f946915b23 ("dt-bindings: mfd: ti,j721e-system-controller.yaml: Add J721e system controller")
Cc: Roger Quadros <rogerq@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Lee Jones Oct. 5, 2020, 8:08 a.m. UTC | #1
On Fri, 02 Oct 2020, Rob Herring wrote:

> Pattern properties go under 'patternProperties', not 'properties'.
> Otherwise, the pattern is treated as a literal string.
> 
> A corresponding meta-schema check has been added to catch bad DT property
> names like this.
> 
> Fixes: e0f946915b23 ("dt-bindings: mfd: ti,j721e-system-controller.yaml: Add J721e system controller")
> Cc: Roger Quadros <rogerq@ti.com>
> Cc: Tero Kristo <t-kristo@ti.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml   | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Lee Jones <lee.jones@linaro.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
index c8fd5d3e3071..da3d9ab758b9 100644
--- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
+++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
@@ -38,8 +38,8 @@  properties:
 
   ranges: true
 
-# Optional children
-
+patternProperties:
+  # Optional children
   "^serdes-ln-ctrl@[0-9a-f]+$":
     type: object
     description: |