diff mbox series

dt-bindings: arm: Add missing root node constraint for board/SoC bindings

Message ID 20201001200943.1193870-1-robh@kernel.org
State Accepted
Headers show
Series dt-bindings: arm: Add missing root node constraint for board/SoC bindings | expand

Checks

Context Check Description
robh/dt-meta-schema success
robh/checkpatch success

Commit Message

Rob Herring Oct. 1, 2020, 8:09 p.m. UTC
Board/SoC top-level compatible bindings should be constrained to the root
node. Add the missing constraints that the node name must be "/".

Cc: "Andreas Färber" <afaerber@suse.de>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Baruch Siach <baruch@tkos.co.il>
Cc: Linus Walleij <linusw@kernel.org>
Cc: Imre Kaloz <kaloz@openwrt.org>
Cc: Krzysztof Halasa <khalasa@piap.pl>
Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Dinh Nguyen <dinguyen@kernel.org>
Cc: Anders Berg <anders.berg@lsi.com>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/arm/actions.yaml      | 2 ++
 Documentation/devicetree/bindings/arm/altera.yaml       | 2 ++
 Documentation/devicetree/bindings/arm/axxia.yaml        | 2 ++
 Documentation/devicetree/bindings/arm/bitmain.yaml      | 2 ++
 Documentation/devicetree/bindings/arm/digicolor.yaml    | 2 ++
 Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml | 2 ++
 Documentation/devicetree/bindings/arm/qcom.yaml         | 2 ++
 Documentation/devicetree/bindings/arm/rda.yaml          | 2 ++
 Documentation/devicetree/bindings/arm/stm32/stm32.yaml  | 2 ++
 Documentation/devicetree/bindings/arm/tegra.yaml        | 2 ++
 10 files changed, 20 insertions(+)

Comments

Linus Walleij Oct. 1, 2020, 8:55 p.m. UTC | #1
On Thu, Oct 1, 2020 at 10:09 PM Rob Herring <robh@kernel.org> wrote:

> Board/SoC top-level compatible bindings should be constrained to the root
> node. Add the missing constraints that the node name must be "/".
>
> Cc: "Andreas Färber" <afaerber@suse.de>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Baruch Siach <baruch@tkos.co.il>
> Cc: Linus Walleij <linusw@kernel.org>
> Cc: Imre Kaloz <kaloz@openwrt.org>
> Cc: Krzysztof Halasa <khalasa@piap.pl>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: Dinh Nguyen <dinguyen@kernel.org>
> Cc: Anders Berg <anders.berg@lsi.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>

Makes sense.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Andreas Färber Oct. 2, 2020, 10:58 a.m. UTC | #2
Am 01.10.20 um 22:09 schrieb Rob Herring:
> Board/SoC top-level compatible bindings should be constrained to the root
> node. Add the missing constraints that the node name must be "/".
> 
> Cc: "Andreas Färber" <afaerber@suse.de>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Baruch Siach <baruch@tkos.co.il>
> Cc: Linus Walleij <linusw@kernel.org>
> Cc: Imre Kaloz <kaloz@openwrt.org>
> Cc: Krzysztof Halasa <khalasa@piap.pl>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: Dinh Nguyen <dinguyen@kernel.org>
> Cc: Anders Berg <anders.berg@lsi.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/arm/actions.yaml      | 2 ++
>  Documentation/devicetree/bindings/arm/altera.yaml       | 2 ++
>  Documentation/devicetree/bindings/arm/axxia.yaml        | 2 ++
>  Documentation/devicetree/bindings/arm/bitmain.yaml      | 2 ++
>  Documentation/devicetree/bindings/arm/digicolor.yaml    | 2 ++
>  Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml | 2 ++
>  Documentation/devicetree/bindings/arm/qcom.yaml         | 2 ++
>  Documentation/devicetree/bindings/arm/rda.yaml          | 2 ++
>  Documentation/devicetree/bindings/arm/stm32/stm32.yaml  | 2 ++
>  Documentation/devicetree/bindings/arm/tegra.yaml        | 2 ++
>  10 files changed, 20 insertions(+)

Reviewed-by: Andreas Färber <afaerber@suse.de>

Looks like for realtek.yaml we already have it, although in single
quotes, but I assume that's equivalent.

Regards,
Andreas
Manivannan Sadhasivam Oct. 2, 2020, 2:18 p.m. UTC | #3
On Thu, Oct 01, 2020 at 03:09:43PM -0500, Rob Herring wrote:
> Board/SoC top-level compatible bindings should be constrained to the root
> node. Add the missing constraints that the node name must be "/".
> 
> Cc: "Andreas Färber" <afaerber@suse.de>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Baruch Siach <baruch@tkos.co.il>
> Cc: Linus Walleij <linusw@kernel.org>
> Cc: Imre Kaloz <kaloz@openwrt.org>
> Cc: Krzysztof Halasa <khalasa@piap.pl>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: Dinh Nguyen <dinguyen@kernel.org>
> Cc: Anders Berg <anders.berg@lsi.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/arm/actions.yaml      | 2 ++

For actions,

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

>  Documentation/devicetree/bindings/arm/altera.yaml       | 2 ++
>  Documentation/devicetree/bindings/arm/axxia.yaml        | 2 ++
>  Documentation/devicetree/bindings/arm/bitmain.yaml      | 2 ++
>  Documentation/devicetree/bindings/arm/digicolor.yaml    | 2 ++
>  Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml | 2 ++
>  Documentation/devicetree/bindings/arm/qcom.yaml         | 2 ++
>  Documentation/devicetree/bindings/arm/rda.yaml          | 2 ++
>  Documentation/devicetree/bindings/arm/stm32/stm32.yaml  | 2 ++
>  Documentation/devicetree/bindings/arm/tegra.yaml        | 2 ++
>  10 files changed, 20 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/actions.yaml b/Documentation/devicetree/bindings/arm/actions.yaml
> index ace3fdaa8396..14023f0a8552 100644
> --- a/Documentation/devicetree/bindings/arm/actions.yaml
> +++ b/Documentation/devicetree/bindings/arm/actions.yaml
> @@ -11,6 +11,8 @@ maintainers:
>    - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>  
>  properties:
> +  $nodename:
> +    const: "/"
>    compatible:
>      oneOf:
>        # The Actions Semi S500 is a quad-core ARM Cortex-A9 SoC.
> diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
> index b388c5aa7984..0bc5020b7539 100644
> --- a/Documentation/devicetree/bindings/arm/altera.yaml
> +++ b/Documentation/devicetree/bindings/arm/altera.yaml
> @@ -10,6 +10,8 @@ maintainers:
>    - Dinh Nguyen <dinguyen@kernel.org>
>  
>  properties:
> +  $nodename:
> +    const: "/"
>    compatible:
>      items:
>        - enum:
> diff --git a/Documentation/devicetree/bindings/arm/axxia.yaml b/Documentation/devicetree/bindings/arm/axxia.yaml
> index 98780a569f22..3ea5f2fdcd96 100644
> --- a/Documentation/devicetree/bindings/arm/axxia.yaml
> +++ b/Documentation/devicetree/bindings/arm/axxia.yaml
> @@ -10,6 +10,8 @@ maintainers:
>    - Anders Berg <anders.berg@lsi.com>
>  
>  properties:
> +  $nodename:
> +    const: "/"
>    compatible:
>      description: LSI AXM5516 Validation board (Amarillo)
>      items:
> diff --git a/Documentation/devicetree/bindings/arm/bitmain.yaml b/Documentation/devicetree/bindings/arm/bitmain.yaml
> index 5cd5b36cff2d..5880083ab8d0 100644
> --- a/Documentation/devicetree/bindings/arm/bitmain.yaml
> +++ b/Documentation/devicetree/bindings/arm/bitmain.yaml
> @@ -10,6 +10,8 @@ maintainers:
>    - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>  
>  properties:
> +  $nodename:
> +    const: "/"
>    compatible:
>      items:
>        - enum:
> diff --git a/Documentation/devicetree/bindings/arm/digicolor.yaml b/Documentation/devicetree/bindings/arm/digicolor.yaml
> index d9c80b827e9b..849e20518339 100644
> --- a/Documentation/devicetree/bindings/arm/digicolor.yaml
> +++ b/Documentation/devicetree/bindings/arm/digicolor.yaml
> @@ -10,6 +10,8 @@ maintainers:
>    - Baruch Siach <baruch@tkos.co.il>
>  
>  properties:
> +  $nodename:
> +    const: "/"
>    compatible:
>      const: cnxt,cx92755
>  
> diff --git a/Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml b/Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml
> index f4f7451e5e8a..f18302efb90e 100644
> --- a/Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml
> +++ b/Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml
> @@ -10,6 +10,8 @@ maintainers:
>    - Linus Walleij <linus.walleij@linaro.org>
>  
>  properties:
> +  $nodename:
> +    const: "/"
>    compatible:
>      oneOf:
>        - items:
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 6031aee0f5a8..ae6284be9fef 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -73,6 +73,8 @@ description: |
>    foundry 2.
>  
>  properties:
> +  $nodename:
> +    const: "/"
>    compatible:
>      oneOf:
>        - items:
> diff --git a/Documentation/devicetree/bindings/arm/rda.yaml b/Documentation/devicetree/bindings/arm/rda.yaml
> index 51cec2b63b04..9672aa0c760d 100644
> --- a/Documentation/devicetree/bindings/arm/rda.yaml
> +++ b/Documentation/devicetree/bindings/arm/rda.yaml
> @@ -10,6 +10,8 @@ maintainers:
>    - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>  
>  properties:
> +  $nodename:
> +    const: "/"
>    compatible:
>      items:
>        - enum:
> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> index 790e6dd48e34..696a0101ebcc 100644
> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> @@ -10,6 +10,8 @@ maintainers:
>    - Alexandre Torgue <alexandre.torgue@st.com>
>  
>  properties:
> +  $nodename:
> +    const: "/"
>    compatible:
>      oneOf:
>        - items:
> diff --git a/Documentation/devicetree/bindings/arm/tegra.yaml b/Documentation/devicetree/bindings/arm/tegra.yaml
> index e0b3debaee9e..b4d53290c5f0 100644
> --- a/Documentation/devicetree/bindings/arm/tegra.yaml
> +++ b/Documentation/devicetree/bindings/arm/tegra.yaml
> @@ -11,6 +11,8 @@ maintainers:
>    - Jonathan Hunter <jonathanh@nvidia.com>
>  
>  properties:
> +  $nodename:
> +    const: "/"
>    compatible:
>      oneOf:
>        - items:
> -- 
> 2.25.1
>
Thierry Reding Oct. 5, 2020, 9:33 a.m. UTC | #4
On Thu, Oct 01, 2020 at 03:09:43PM -0500, Rob Herring wrote:
[...]
> diff --git a/Documentation/devicetree/bindings/arm/tegra.yaml b/Documentation/devicetree/bindings/arm/tegra.yaml
> index e0b3debaee9e..b4d53290c5f0 100644
> --- a/Documentation/devicetree/bindings/arm/tegra.yaml
> +++ b/Documentation/devicetree/bindings/arm/tegra.yaml
> @@ -11,6 +11,8 @@ maintainers:
>    - Jonathan Hunter <jonathanh@nvidia.com>
>  
>  properties:
> +  $nodename:
> +    const: "/"
>    compatible:
>      oneOf:
>        - items:

Acked-by: Thierry Reding <treding@nvidia.com>
Alexandre Torgue Oct. 5, 2020, 10:16 a.m. UTC | #5
Hi Rob,

On 10/1/20 10:09 PM, Rob Herring wrote:
> Board/SoC top-level compatible bindings should be constrained to the root
> node. Add the missing constraints that the node name must be "/".
> 

...

> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> index 790e6dd48e34..696a0101ebcc 100644
> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> @@ -10,6 +10,8 @@ maintainers:
>     - Alexandre Torgue <alexandre.torgue@st.com>
>   
>   properties:
> +  $nodename:
> +    const: "/"
>     compatible:
>       oneOf:
>         - items:

Reviewed-by: Alexandre TORGUE <alexandre.torgue@st.com>

thanks
Alex
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/actions.yaml b/Documentation/devicetree/bindings/arm/actions.yaml
index ace3fdaa8396..14023f0a8552 100644
--- a/Documentation/devicetree/bindings/arm/actions.yaml
+++ b/Documentation/devicetree/bindings/arm/actions.yaml
@@ -11,6 +11,8 @@  maintainers:
   - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     oneOf:
       # The Actions Semi S500 is a quad-core ARM Cortex-A9 SoC.
diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
index b388c5aa7984..0bc5020b7539 100644
--- a/Documentation/devicetree/bindings/arm/altera.yaml
+++ b/Documentation/devicetree/bindings/arm/altera.yaml
@@ -10,6 +10,8 @@  maintainers:
   - Dinh Nguyen <dinguyen@kernel.org>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     items:
       - enum:
diff --git a/Documentation/devicetree/bindings/arm/axxia.yaml b/Documentation/devicetree/bindings/arm/axxia.yaml
index 98780a569f22..3ea5f2fdcd96 100644
--- a/Documentation/devicetree/bindings/arm/axxia.yaml
+++ b/Documentation/devicetree/bindings/arm/axxia.yaml
@@ -10,6 +10,8 @@  maintainers:
   - Anders Berg <anders.berg@lsi.com>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     description: LSI AXM5516 Validation board (Amarillo)
     items:
diff --git a/Documentation/devicetree/bindings/arm/bitmain.yaml b/Documentation/devicetree/bindings/arm/bitmain.yaml
index 5cd5b36cff2d..5880083ab8d0 100644
--- a/Documentation/devicetree/bindings/arm/bitmain.yaml
+++ b/Documentation/devicetree/bindings/arm/bitmain.yaml
@@ -10,6 +10,8 @@  maintainers:
   - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     items:
       - enum:
diff --git a/Documentation/devicetree/bindings/arm/digicolor.yaml b/Documentation/devicetree/bindings/arm/digicolor.yaml
index d9c80b827e9b..849e20518339 100644
--- a/Documentation/devicetree/bindings/arm/digicolor.yaml
+++ b/Documentation/devicetree/bindings/arm/digicolor.yaml
@@ -10,6 +10,8 @@  maintainers:
   - Baruch Siach <baruch@tkos.co.il>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     const: cnxt,cx92755
 
diff --git a/Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml b/Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml
index f4f7451e5e8a..f18302efb90e 100644
--- a/Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml
+++ b/Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml
@@ -10,6 +10,8 @@  maintainers:
   - Linus Walleij <linus.walleij@linaro.org>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     oneOf:
       - items:
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 6031aee0f5a8..ae6284be9fef 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -73,6 +73,8 @@  description: |
   foundry 2.
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     oneOf:
       - items:
diff --git a/Documentation/devicetree/bindings/arm/rda.yaml b/Documentation/devicetree/bindings/arm/rda.yaml
index 51cec2b63b04..9672aa0c760d 100644
--- a/Documentation/devicetree/bindings/arm/rda.yaml
+++ b/Documentation/devicetree/bindings/arm/rda.yaml
@@ -10,6 +10,8 @@  maintainers:
   - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     items:
       - enum:
diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
index 790e6dd48e34..696a0101ebcc 100644
--- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
+++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
@@ -10,6 +10,8 @@  maintainers:
   - Alexandre Torgue <alexandre.torgue@st.com>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     oneOf:
       - items:
diff --git a/Documentation/devicetree/bindings/arm/tegra.yaml b/Documentation/devicetree/bindings/arm/tegra.yaml
index e0b3debaee9e..b4d53290c5f0 100644
--- a/Documentation/devicetree/bindings/arm/tegra.yaml
+++ b/Documentation/devicetree/bindings/arm/tegra.yaml
@@ -11,6 +11,8 @@  maintainers:
   - Jonathan Hunter <jonathanh@nvidia.com>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     oneOf:
       - items: